Re: [OpenBabel-Devel] MSVC, no prebuilt binaries and inttypes.h

2013-08-05 Thread Noel O'Boyle
I'll fix that. I think that's a recent commit (eec8d36899). The automatic builds have I think fallen behind so this wasn't picked up. My one at least is still running off SVN :-/ - Noel On 30 July 2013 18:35, Marcus D. Hanwell marcus.hanw...@kitware.com wrote: Just to confirm that this works if

Re: [OpenBabel-Devel] MSVC, no prebuilt binaries and inttypes.h

2013-07-30 Thread Marcus D. Hanwell
Just to confirm that this works if backported to d6c04d1, but we are seeing linking issues with Open Babel in Visual Studio 2010 on top of master, http://cdash.openchemistry.org/viewBuildError.php?buildid=12153 OpenBabel::OBPairTemplate seems to have symbol visibility issues, but cherry-picking

Re: [OpenBabel-Devel] MSVC, no prebuilt binaries and inttypes.h

2013-07-26 Thread Marcus D. Hanwell
I will do some more testing when in front of my Windows machine, but https://github.com/cryos/openbabel/commit/7f4db407e6dc4bdd27ab743d77b22ea1c79bf9f8 is my first attempt at fixing this. Reading the docs at windows-vc2008/libs/i386/readme.txt I think they should be left where they are and the

Re: [OpenBabel-Devel] MSVC, no prebuilt binaries and inttypes.h

2013-07-25 Thread Marcus D. Hanwell
I was looking at this, and my only remaining concern is that the cairo and rpc directories could be included before that headers of the library you are going to link against - if they ever change the API this would cause problems (largely for Windows builds), as they look like snapshots of the

[OpenBabel-Devel] MSVC, no prebuilt binaries and inttypes.h

2013-07-24 Thread Marcus D. Hanwell
Hi, We build Open Babel on Windows without prebuilt binaries, and have tracked down an issue with the C99 headers and MSVC. The headers in windows-vc2008/include/ don't seem to be Visual Studio 2008 specific, if there are no objections could I move inttypes.h and stdint.h to msvc-support or

Re: [OpenBabel-Devel] MSVC, no prebuilt binaries and inttypes.h

2013-07-24 Thread Noel O'Boyle
Would renaming windows-vc2008 to msvc solve the problem? - Noel On 24 July 2013 15:57, Marcus D. Hanwell marcus.hanw...@kitware.com wrote: Hi, We build Open Babel on Windows without prebuilt binaries, and have tracked down an issue with the C99 headers and MSVC. The headers in

Re: [OpenBabel-Devel] MSVC, no prebuilt binaries and inttypes.h

2013-07-24 Thread Marcus D. Hanwell
I don't know how generic the other headers are, or if they are tied to particular DLLs. I don't want to be tied to the prebuilt binaries, and so it seems like it might need some separation (assuming you want to continue using prebuilt binaries). Marcus On Wed, Jul 24, 2013 at 12:07 PM, Noel

Re: [OpenBabel-Devel] MSVC, no prebuilt binaries and inttypes.h

2013-07-24 Thread Chris Morley
I don't understand enough of this to contribute much, but all the components used to build with the Express versions of VS 2008, 2010, 2012 and 2013 must be freely available and distributable. One prebuilt binary that we would be better without is vcredist_x86.exe. Chris I On 24/07/2013