Re: [OpenBabel-Devel] Treat warnings as errors

2016-06-23 Thread Geoffrey Hutchison
> Hopefully we can put some pragmas in the InChI code or do some other > hack (e.g. google says "-isystem") to suppress warnings from those. Since all the InChI code is C, but ours is C++, it’s a matter of setting CXXFLAGS differently than CFLAGS. I already do this for warnings. -Geoff

Re: [OpenBabel-Devel] Treat warnings as errors

2016-06-23 Thread Geoff Hutchison
My big concern would be the inchi code, which has tons. If we do this for our C++ and Python, I think it's a good goal. Geoff > On Jun 23, 2016, at 4:39 AM, Noel O'Boyle wrote: > > Hi all, > > Over the last year, several developers have spent time fixing warnings >

[OpenBabel-Devel] Treat warnings as errors

2016-06-23 Thread Noel O'Boyle
Hi all, Over the last year, several developers have spent time fixing warnings reported by various tools. This sort of maintenance is best done by the original developer at the point of commiting. Warnings are fairly easy to fix and knowing about them improves programming skills. An easy way to