details: https://code.openbravo.com/erp/devel/pi/rev/db677cb3304b
changeset: 35520:db677cb3304b
user: Carlos Aristu <carlos.aristu <at> openbravo.com>
date: Fri Mar 08 13:59:19 2019 +0100
summary: related to issue 40272: code review improvements
Directly show the code in case it does not match with any existing support
status
diffstat:
src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diffs (26 lines):
diff -r e77b49e6d86d -r db677cb3304b
src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
--- a/src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java Fri Mar
08 10:08:46 2019 +0100
+++ b/src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java Fri Mar
08 13:59:19 2019 +0100
@@ -1991,13 +1991,19 @@
}
private String getSupportStatus(String supportCode, boolean detailed) {
- org.openbravo.model.ad.domain.List refValue = OBDal.getInstance()
+ Optional<org.openbravo.model.ad.domain.List> optRefValue =
OBDal.getInstance()
.get(Reference.class, SUPPORT_STATUS_REF)
.getADListList()
.stream()
.filter(l -> supportCode.equals(l.getSearchKey()))
- .findAny()
- .get();
+ .findAny();
+
+ if (!optRefValue.isPresent()) {
+ // Unknown support status code, can't get its corresponding label
+ return supportCode;
+ }
+
+ org.openbravo.model.ad.domain.List refValue = optRefValue.get();
Optional<String> trlListValue = refValue.getADListTrlList()
.stream()
_______________________________________________
Openbravo-commits mailing list
Openbravo-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbravo-commits
