[Openchrome-devel] [Bug 72088] cppcheck report

2013-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72088 Mario Rugiero changed: What|Removed |Added Attachment #90813|0 |1 is patch|

[Openchrome-devel] [Bug 72088] cppcheck report

2013-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72088 Mario Rugiero changed: What|Removed |Added Attachment #90810|0 |1 is patch|

[Openchrome-devel] [Bug 72088] cppcheck report

2013-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72088 --- Comment #8 from Mario Rugiero --- Forgot to mark as patches the patches for the duplicate branches and for the reassignment. If anyone is able to mark them (to ease review), I'll be thankful. Otherwise, I'll add the patches again with the cor

[Openchrome-devel] [Bug 72088] cppcheck report

2013-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72088 --- Comment #7 from Mario Rugiero --- Created attachment 90813 --> https://bugs.freedesktop.org/attachment.cgi?id=90813&action=edit A (possible?) fix for the duplicate branches error. Please, review that this actually is what was intended, as

[Openchrome-devel] [Bug 72088] cppcheck report

2013-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72088 --- Comment #6 from Mario Rugiero --- Created attachment 90811 --> https://bugs.freedesktop.org/attachment.cgi?id=90811&action=edit Formatting fixes for registers.c -- You are receiving this mail because: You are the assignee for the bug. ___

[Openchrome-devel] [Bug 72088] cppcheck report

2013-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72088 --- Comment #5 from Mario Rugiero --- Created attachment 90810 --> https://bugs.freedesktop.org/attachment.cgi?id=90810&action=edit (Trivial) Patch for a reassignment without using the previous value. -- You are receiving this mail because: Y

[Openchrome-devel] [Bug 72088] cppcheck report

2013-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72088 --- Comment #4 from Mario Rugiero --- Created attachment 90809 --> https://bugs.freedesktop.org/attachment.cgi?id=90809&action=edit Fixes double frees, see my previous comment for a complete explanation. -- You are receiving this mail because

[Openchrome-devel] [Bug 72088] cppcheck report

2013-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72088 --- Comment #3 from Mario Rugiero --- Just ran cppcheck again. I will explain the errors I'll fix here, and then provide the patch. First, this one: [src/via_driver.c:1109]: (error) Memory pointed to by 'pEnt' is freed twice. This error is ca