Re: [PATCH] Juniper: support password and 2FA fields in the same form

2020-06-24 Thread Daniel Lenski
On Wed, Jun 24, 2020 at 3:28 PM Ash Holland wrote: > I can send another patch with this corrected if you'd like. That's all right. Thanks for the explanation. I created this as a MR on Gitlab and added a few more clarifying remarks (https://gitlab.com/openconnect/openconnect/-/merge_requests/121)

Re: [PATCH] Juniper: support password and 2FA fields in the same form

2020-06-24 Thread Ash Holland
On Wed Jun 24, 2020 at 10:45 PM BST, Daniel Lenski wrote: > On Wed, Jun 24, 2020 at 2:27 PM Ash Holland wrote: > > auth-juniper.c | 12 > > 1 file changed, 12 insertions(+) > > > > diff --git a/auth-juniper.c b/auth-juniper.c > > index 19d439784..f4d9733fa 100644 > > --- a/auth-junip

Re: [PATCH] Juniper: support password and 2FA fields in the same form

2020-06-24 Thread Daniel Lenski
On Wed, Jun 24, 2020 at 2:27 PM Ash Holland wrote: > auth-juniper.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/auth-juniper.c b/auth-juniper.c > index 19d439784..f4d9733fa 100644 > --- a/auth-juniper.c > +++ b/auth-juniper.c > @@ -74,6 +74,18 @@ static int oncp_can_gen

[PATCH] Juniper: support password and 2FA fields in the same form

2020-06-24 Thread Ash Holland
Juniper login forms typically ask for the password in the first form, then put the 2FA field in a later form. However, some use a second password field in the first form (usually frmLogin) for the 2FA token. We now assume password fields after the first in a frmLogin to be 2FA fields to cope with t