On Thu, 2015-08-20 at 14:56 +0300, Ed Bartosh wrote:
> Write set of bitbake variables associated with the image into
> build/tmp/sysroots//imagedata/.env
>
> This is needed for wic to be able to get bitbake variables without
> running 'bitbake -e'.
I've just realised what this code is doing, its
On Sun, Aug 30, 2015 at 12:24:48PM +0100, Richard Purdie wrote:
> On Thu, 2015-08-20 at 14:56 +0300, Ed Bartosh wrote:
> > Write set of bitbake variables associated with the image into
> > build/tmp/sysroots//imagedata/.env
> >
> > This is needed for wic to be able to get bitbake variables without
Hi Paul,
Thank you for review!
My answers are below.
On Thu, Aug 27, 2015 at 03:07:37PM +0100, Paul Eggleton wrote:
> Hi Ed,
>
> On Monday 24 August 2015 10:33:31 Ed Bartosh wrote:
> > Implemented new plugin to build image from workspace packages.
> >
> > Plugin creates .bbappend file, adds
>
On Wed, 2015-08-26 at 22:31 -0400, Bruce Ashfield wrote:
> Updating the 3.14 SRCREVs to match the latest kernel meta data updates
> and also to merge four patches Richard Purdie located that fix the
> gcc 5.x ARM build (we still have boot issues, but building is the
> first step).
>
> Signed-off-b
On Sun, 2015-08-30 at 10:34 -0400, Bruce Ashfield wrote:
> On Sun, Aug 30, 2015 at 10:30 AM, Bruce Ashfield
> wrote:
> > On Sun, Aug 30, 2015 at 9:57 AM, Richard Purdie
> > wrote:
> >> On Wed, 2015-08-26 at 22:31 -0400, Bruce Ashfield wrote:
> >>> Updating the 3.14 SRCREVs to match the latest ker
Used logger variable name instead of LOG as it is used in the rest
of devtool code.
Although Pylint complains about 'logger' being invalid constant name,
but it's better to be consistent in naming than make Pylint happy.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 4 ++--
Moved standard.py:_parse_recipe -> __init__.py:parse_recipe and
standard.py:_get_recipe_file -> __init__.py:get_recipe_file
to be able to call them from other modules.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/__init__.py | 27 +++
scripts/lib/devtool/stand
Added couple of hopefully useful comments to the code.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/lib/devtool/build-image.py
b/scripts/lib/devtool/build-image.py
index 5bc8213..817703a 100644
--- a/scripts/lib/d
It doesn't make sense to use it as image recipe is not
in workspace. It means that we can't do 'devtool reset'
for the recipe, which is a main point of using add_md5.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff -
Added logger calls to show if image is modified by the
plugin or not.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/lib/devtool/build-image.py
b/scripts/lib/devtool/build-image.py
index d246fad..563563b 100644
This reverts commit 69c63728dae38d5b1cc9874268f235a07e04d3db.
Moved add_md5 back to standard.py as it's not used in
any plugin anymore.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/__init__.py | 7 ---
scripts/lib/devtool/standard.py | 15 +++
2 files changed, 11 insertion
Removed .bbappend before generating it again as
it may cause tinfoil to fail due to its wrong content.
It's safe to do as .bbappend is regenerated anyway.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/scripts/lib/devtoo
Added test case to test functionaly of build-image plugin:
Add two packages to workspace and run 'devtool build-image
core-image-minimal'.
Checked if command is successful.
Checked if expected package is added to generated
core-image-minimal.bbappend file.
Signed-off-by: Ed Bartosh
---
meta/l
Filtered out non-target recipes and recipes with
recipe name != package name in build-image plugin.
Isolated all logic of getting recipes in _get_recipes
function.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 25 +
1 file changed, 21 insertions(+),
Made parser help message and description more clear in
build-image plugin.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/scripts/lib/devtool/build-image.py
b/scripts/lib/devtool/build-image.py
inde
Added notification callback to .bbapend to notify
user that image is modified by build-image plugin.
Signed-off-by: Ed Bartosh
---
scripts/lib/devtool/build-image.py | 9 +
1 file changed, 9 insertions(+)
diff --git a/scripts/lib/devtool/build-image.py
b/scripts/lib/devtool/build-image
This set of improvements for build-image plugin hopefully addresses
Paul's review comments and suggestions.
Paul, thank you for review!
The following changes since commit 6b17c3831897ee1d46a763d807c5bd863d426bc1:
linux-yocto-3.14: Update to latest revisions (2015-08-30 12:47:51 +0100)
are ava
So far all devtool and recipetool plugins were expected
to have plugin_init function. This function is empty in
most of plugins as they don't require initialisation.
Making plugin_init optional would allow not having empty
plugin_init in every plugin.
Signed-off-by: Ed Bartosh
---
scripts/lib/d
Write set of bitbake variables used by wic into
build/tmp/sysroots//imagedata/.env
List of variables is defined in WICVARS variable in
meta/classes/image_types.bbclass.
This is needed for wic to be able to get bitbake variables without
running 'bitbake -e'.
Signed-off-by: Ed Bartosh
---
meta/c
Moved code of getting bitbake variables into separate class.
Created singleton object of this class in the module namespace.
Preserved existing API get_bitbake_var.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/utils/oe/misc.py | 91 +++-
1 file changed, 53
This option is used to point wic to the directory with .env
files containing list of bitbake variables and their values.
If this option is used wic will get bitbake variables from
files instead of parsing 'bitbake -e' output.
The main reason for this is to support new mode, when bitbake
runs wic
Added test case to check if .env file is generated
and contains bitbake variables used in wic code.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 20
1 file changed, 20 insertions(+)
diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py
If bitbake image is referenced in .ks file and --size is not used
there wic uses ROOTFS_SIZE variable to set minimum partition size.
ROOTFS_SIZE is calculated in meta/lib/oe/image.py when rootfs is
created. The calculation is done using other image parameters:
IMAGE_ROOTFS_SIZE, IMAGE_ROOTFS_ALIGN
Added test case to verify building of wic-image-minimal recipe
and produced artifacts: manifest and bzipped partitioned image.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/
Moved code that parses one line of 'bitbake -e' output
to separate method _parse_line.
This method will be also used later to parse lines of .env files.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/utils/oe/misc.py | 27 +--
1 file changed, 17 insertions(+), 10 deletion
Added example of recipe and .wks file to create partitioned image.
This image is using quite complex partitioning scheme.
It uses its own rootfs to populate two partitions in two different ways.
It also uses core-image-minimal rootfs to populate another partition.
This is how wic reports about ar
New attribute is used when bitbake variable is requested without
specifying image name. The attribute should be set from outside,
for example when wic is called with '-e ' option.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/utils/oe/misc.py | 6 ++
1 file changed, 6 insertions(+)
diff --g
Hi Reviewers,
This patchset adds new image type 'wic' to the list of image types
supported by bitbake. This should allow to build partitioned image
the same way as any other images.
New image type can be used in image recipes almost the same way as other
image types. There is just one difference
Set BitbakeVars.default_image when wic is called with -e option.
This makes get_bitbake_var API to use provided image as a default
source of variables.
Signed-off-by: Ed Bartosh
---
scripts/wic | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/scripts/wic b/scripts/wic
in
Added functionality of getting variables from .env files to
BitbakeVars class. env files will be parsed if the directory with
env files is known, i.e. when vars_dir attribute is set.
Otherwise 'bitbake -e' output will be parsed.
Signed-off-by: Ed Bartosh
---
scripts/lib/wic/utils/oe/misc.py | 59
wic image type is used to produce partitioned images.
Image configuration should be stored in either ..wks
or .wks file.
.wks file should be put to the same location as image recipe
and have the same name.
[YOCTO #7672]
Signed-off-by: Ed Bartosh
---
meta/classes/image_types.bbclass | 12 ++
On Sun, 2015-08-30 at 20:47 +0300, Ed Bartosh wrote:
> Added example of recipe and .wks file to create partitioned image.
>
> This image is using quite complex partitioning scheme.
> It uses its own rootfs to populate two partitions in two different ways.
> It also uses core-image-minimal rootfs t
Write set of bitbake variables used by wic into
build/tmp/sysroots//imagedata/.env
List of variables is defined in WICVARS variable in
meta/classes/image_types.bbclass.
This is needed for wic to be able to get bitbake variables without
running 'bitbake -e'.
Signed-off-by: Ed Bartosh
---
meta/c
Added example of recipe and .wks file to create partitioned image.
This image is using quite complex partitioning scheme.
It uses its own rootfs to populate two partitions in two different ways.
It also uses core-image-minimal rootfs to populate another partition.
This is how wic reports about ar
Added test case to verify building of wic-image-minimal recipe
and produced artifacts: manifest and bzipped partitioned image.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 14 ++
1 file changed, 14 insertions(+)
diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/
Hi,
This is hopefully last version of the patchset.
I've changed location of .wks and .bb files as Richard suggested.
The following changes since commit 0f84702f0811cba4b6e6e890d478f6e98937b831:
image_types.bbclass: add wic image type (2015-08-30 21:38:23 +0100)
are available in the git repos
Added test case to check if .env file is generated
and contains bitbake variables used in wic code.
Signed-off-by: Ed Bartosh
---
meta/lib/oeqa/selftest/wic.py | 20
1 file changed, 20 insertions(+)
diff --git a/meta/lib/oeqa/selftest/wic.py b/meta/lib/oeqa/selftest/wic.py
If bitbake image is referenced in .ks file and --size is not used
there wic uses ROOTFS_SIZE variable to set minimum partition size.
ROOTFS_SIZE is calculated in meta/lib/oe/image.py when rootfs is
created. The calculation is done using other image parameters:
IMAGE_ROOTFS_SIZE, IMAGE_ROOTFS_ALIGN
From: Leonardo Sandoval
Given a 'buildstats' path (created by bitbake when setting
USER_CLASSES ?= "buildstats" on local.conf) and task names, outputs
' ' for all recipes. Elapsed times are in
seconds, and task should be given without the 'do_' prefix.
Some useful pipelines
1. Tasks with large
On Sun, Aug 30, 2015 at 2:14 PM, Ed Bartosh
wrote:
> Write set of bitbake variables used by wic into
> build/tmp/sysroots//imagedata/.env
>
> List of variables is defined in WICVARS variable in
> meta/classes/image_types.bbclass.
>
> This is needed for wic to be able to get bitbake variables with
40 matches
Mail list logo
