[OE-core] [PATCH] resulttool/manualexecution: Refactor and remove duplicate code

2019-04-10 Thread Yeoh Ee Peng
Remove duplicate codes. Replace unnecessary class variables with local variables. Rename variables and arguments with simple and standard name. Signed-off-by: Yeoh Ee Peng --- scripts/lib/resulttool/manualexecution.py | 87 ++- 1 file changed, 40 insertions(+), 47

[OE-core] [PATCH] ccmake.bbclass: Fix up un-escaped quotes in output formatting

2019-04-10 Thread Nathan Rossi
The quotes should be generated in the output to match the expected cmake syntax for setting cache variables. Signed-off-by: Nathan Rossi --- meta/classes/ccmake.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/ccmake.bbclass b/meta/classes/ccmake.bbclass

Re: [OE-core] [yocto] Eclipse support dropped with immediate effect

2019-04-10 Thread akuster808
On 4/10/19 3:11 PM, richard.pur...@linuxfoundation.org wrote: > On Wed, 2019-04-10 at 05:56 +0530, akuster808 wrote: >> On 4/9/19 8:52 PM, Richard Purdie wrote: >>> I'm sorry to have to say this but the project is terminating its >>> official eclipse plugin support with immediate effect. >>

Re: [OE-core] [PATCH] pseudo: Update to gain key bugfixes

2019-04-10 Thread Seebs
On Thu, 11 Apr 2019 00:12:54 +0100 Richard Purdie wrote: > -SRCREV = "6294b344e5140f5467e6860f45a174440015304e" > +SRCREV = "6ebc7d6bc8ab973d0ba949eeb363821811ce8dc5" I would sort of recommend one of the two commits since then -- one may fix the .NET startup failures, and the other fixes

Re: [OE-core] [PATCH] pseudo: Update to gain key bugfixes

2019-04-10 Thread Otavio Salvador
On Wed, Apr 10, 2019 at 8:13 PM Richard Purdie wrote: > > Newer distros are using new versions of glibc and coreutils which use the new > glibc > renameat2 function. We need to intercept this for correct functioning of > pseudo. This > is essential to ensure new distros continue to work with

Re: [OE-core] [oe-core][PATCH] kernel-devsrc: check for localversion files in the kernel source tree

2019-04-10 Thread Bruce Ashfield
On Wed, Apr 10, 2019 at 6:56 PM Beniamin Sandu wrote: > > The kernel-devsrc rework doesn't take into account localversion > files in the kernel source tree. This might result in modules with an > incomplete version magic when building out-of-tree using the SDK. > > Before: > root@qemux86:~#

[OE-core] [PATCH] pseudo: Update to gain key bugfixes

2019-04-10 Thread Richard Purdie
Newer distros are using new versions of glibc and coreutils which use the new glibc renameat2 function. We need to intercept this for correct functioning of pseudo. This is essential to ensure new distros continue to work with the project. Also, this version has a fix for path/inode cross

[OE-core] [oe-core][PATCH] kernel-devsrc: check for localversion files in the kernel source tree

2019-04-10 Thread Beniamin Sandu
The kernel-devsrc rework doesn't take into account localversion files in the kernel source tree. This might result in modules with an incomplete version magic when building out-of-tree using the SDK. Before: root@qemux86:~# insmod hello.ko [ 42.000212] hello: version magic '5.0.3-yocto-standard

[OE-core] [PATCH] gobject-introspection.bbclass: Disable writing to $HOME/.cache/g-ir-scanner

2019-04-10 Thread Jason Wessel
Investigation of an end user going over their quota in the user's home directory showed that the gobject-instrospection is writing files into the ~/.cache/g-ir-scanner when building -native packages. The test package in this case was gdk-pixbuf-native. Setting the GI_SCANNER_DISABLE_CACHE in the

[OE-core] [PATCH v2] opkg: add ptest

2019-04-10 Thread Alejandro del Castillo
Install opkg test suite and run it as ptest. Signed-off-by: Alejandro del Castillo --- ...dd-target-for-testsuite-installation.patch | 43 +++ py-resolve-paths-before-comparision.patch | 31 + meta/recipes-devtools/opkg/opkg/run-ptest | 5 +++

[OE-core] [PATCH] u-boot: Upgrade from 2019.01 to 2019.04

2019-04-10 Thread Alistair Francis
Signed-off-by: Alistair Francis --- meta/recipes-bsp/u-boot/u-boot-common.inc | 2 +- .../{u-boot-fw-utils_2019.01.bb => u-boot-fw-utils_2019.04.bb} | 0 .../u-boot/{u-boot-tools_2019.01.bb => u-boot-tools_2019.04.bb} | 0 .../recipes-bsp/u-boot/{u-boot_2019.01.bb =>

[OE-core] [v4][PATCH 1/2] go.bbclass: Export more GO* environment variables

2019-04-10 Thread Mark Asselstine
Currently we are not doing a good job of consolidating GO environment variables used by the go build system in the go.bbclass, instead we are relying on the individual GO recipe authors to perform the exports. This can result in inconsistent build results and often binaries that are not properly

[OE-core] [v4][PATCH 2/2] goarch.bbclass: use MACHINEOVERRIDES and simplify go_map_arm()

2019-04-10 Thread Mark Asselstine
Per https://github.com/golang/go/wiki/GoArm we need to set GOARM when cross building for ARMv5, ARMv6 and ARMv7. The current approach of using TUNE_FEATURES can be error prone, as we can see today when attempting to build for Cortex-A7 which results in GOARM=''. Since the value of

Re: [OE-core] [PATCH] perf: workaround the error cased by maybe-uninitialized warning

2019-04-10 Thread Randy MacLeod
On 4/5/19 5:55 PM, Khem Raj wrote: On Thu, Apr 4, 2019 at 2:03 AM Dengke Du wrote: When enable DEBUG_BUILD, the perf build failed by the following error: libbpf.c:727:36: error: 'data' may be used uninitialized in this function [-Werror=maybe-uninitialized] This is ok until Khem commit

Re: [OE-core] [PATCH 00/16] thud-next patch review

2019-04-10 Thread akuster808
On 4/10/19 3:01 AM, Martin Jansa wrote: > Please don't forget to include: > http://lists.openembedded.org/pipermail/openembedded-core/2019-March/280094.html > and similar one for sumo: > http://lists.openembedded.org/pipermail/openembedded-core/2019-March/280093.html > in the next pull. Thanks

Re: [OE-core] Build broken with current master

2019-04-10 Thread Andreas Müller
On Wed, Apr 10, 2019 at 3:00 PM Burton, Ross wrote: > > On Tue, 9 Apr 2019 at 22:41, Andreas Müller wrote: > > > The recipe that depends on docbook-xml-dtd4-native also needs to > > > depend on libxml2-native. > > > > Do I have to go through recipes failing - or is there a chance for a > >

[OE-core] [PATCH 32/33] oeqa: Default to buffer mode for tests

2019-04-10 Thread Armin Kuster
From: Richard Purdie Currently some tests run in buffer mode and some don't. Those that don't can corrupt stdout/stderr. Switch to using buffer mode everywhere so we're consistent. If there is useful output on stdout/stderr, it will be displayed if the test fails. Signed-off-by: Richard

[OE-core] [PATCH 33/33] devtool: Split tests into multiple classes

2019-04-10 Thread Armin Kuster
From: Richard Purdie This allows better parallelism between the different tests as currently this block takes the longest time to execute. devtool tests are still all grouped into the "devtool" module for ease of exection. This also makes it easier to execute some subset of devtool tests for

[OE-core] [PATCH 31/33] oeqa/selftest/devtool: Ensure dbus is built befoe running test

2019-04-10 Thread Armin Kuster
From: Richard Purdie If dbus isn't build first the dbus dependency of dbus-wait can't be detected through pkgconfig and the test fails: AssertionError: {'DEPENDS': {'dbus'}} != {} - {'DEPENDS': {'dbus'}} + {} : Some expected variables not found in recipe: {'DEPENDS': {'dbus'}} Ensure dbus is

[OE-core] [PATCH 30/33] logging: use warning instead warn

2019-04-10 Thread Armin Kuster
From: Chen Qi The warn method is deprecated. We should use the documented warning instead. Quoting from the python's official doc: """ Note: There is an obsolete method warn which is functionally identical to warning. As warn is deprecated, please do not use it - use warning instead. """

[OE-core] [PATCH 29/33] lib/oe: Fix collections ABCs DeprecationWarning in Python 3.7+

2019-04-10 Thread Armin Kuster
From: Khem Raj - Prefer collections.abc (new in Python 3.3) over collections for abstract base classes - In Python 3.8, the abstract base classes in collections.abc will no longer be exposed in the regular collections module. This will help create a clearer distinction between the

[OE-core] [PATCH 28/33] wic: use explicit errno import

2019-04-10 Thread Armin Kuster
From: Ross Burton os.errno doesn't work in Python 3.7 and shouldn't have ever worked, so use import errno explicitly. Signed-off-by: Ross Burton Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster --- scripts/lib/wic/filemap.py | 9 + 1 file changed, 5 insertions(+), 4

[OE-core] [PATCH 27/33] wic/engine: Fix missing parted autobuilder failures

2019-04-10 Thread Armin Kuster
From: Richard Purdie OE-Core rev: a88bcbae850a2e6d182291d3f8e167aabdbe4842 broke the ability to find parted as it may be in sbin which is not in PATH for some users on some distros. Iterate on the original patch to fix this and also fix the original problem. (From OE-Core rev:

[OE-core] [PATCH 26/33] wic/engine.py: Load paths from PATH environment variable

2019-04-10 Thread Armin Kuster
From: William Bourque Load self.paths from environment variable and if it fails, fall back to hardcoded list. This is required for users that would need to load different e2fsprogs binaries if their system's ones are not recent enought (From OE-Core rev:

[OE-core] [PATCH 25/33] scripts/lib/wic/engine: Fix cp's target path for ext* filesystems

2019-04-10 Thread Armin Kuster
From: Leonardo Augusto Python subprocess' shell=True defaults to /bin/sh[1][2], which often refers to a POSIX-compliant shell. As the -e flag is not defined in the POSIX standard[3], some shells may interpret "-e" as the first argument to the echo command, causing the rest of the command line to

[OE-core] [PATCH 24/33] wic: search nonarch STAGING_DATADIR for multilib

2019-04-10 Thread Armin Kuster
From: Kai Kang It fails to build multilib image such as lib32-core-image-minimal with wic by set 'IMAGE_FSTYPES = "wic"': | ERROR: Couldn't find correct bootimg_dir, exiting When multilib is enabled, STAGING_DATADIR is expanded with MLPREFIX. But dependencies of images such as syslinux is

[OE-core] [PATCH 23/33] wic: make engine.py:get_partitions() resilient to parted/dmidecode stderr output

2019-04-10 Thread Armin Kuster
From: Geoff Parker Running wic commands on Debian 10 systems fail in scripts/lib/wic/engine.py:get_partitions() due to new stderr output captured when trying to parse the output from /sbin/parted as a non-root user. The parted command calls the dmidecode utility, which produces this error as a

[OE-core] [PATCH 22/33] scripts/wic: Be consistent about how we call bitbake

2019-04-10 Thread Armin Kuster
From: Richard Purdie Whilst its tempting to call bitbake_main(), the script also directly executes bitbake. By doing both this creates all kinds of races. Therefore change to use subprocess execution in all cases. (From OE-Core rev: 0507ec4c6069490c9a503e9e2b65f0e7b1962d34) Signed-off-by:

[OE-core] [PATCH 20/33] pkgdata.py: avoid target-sdk-dummy-provides to mess things up

2019-04-10 Thread Armin Kuster
From: Chen Qi Sometimes we meet the following failure for the test_lookup_recipe test case. AssertionError: 'zlib\nbusybox is in the RPROVIDES of target-sdk-provid[32 chars]ummy' != 'zlib\nbusybox' zlib + busybox- busybox is in the RPROVIDES of target-sdk-provides-dummy: -

[OE-core] [PATCH 21/33] wic: Support for changing the imager.

2019-04-10 Thread Armin Kuster
From: "Davis, Michael" Signed-off-by: Michael Davis Signed-off-by: Ross Burton Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster --- scripts/lib/wic/engine.py | 2 +- scripts/wic | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

[OE-core] [PATCH 17/33] resulttool/manualexecution: Enable display full steps without press enter

2019-04-10 Thread Armin Kuster
From: Yeoh Ee Peng Current manualexecution required pressing enter button to show each step information, where this was wasting execution time. Enable display full steps without needing to any press enter button. Signed-off-by: Mazliana Signed-off-by: Yeoh Ee Peng Signed-off-by: Richard

[OE-core] [PATCH 19/33] resulttool/manualexecution: Refactor and simplify codebase

2019-04-10 Thread Armin Kuster
From: Yeoh Ee Peng Simplify and removed unnecessary codes. Refactor to allow pythonic loop. Signed-off-by: Yeoh Ee Peng Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster --- scripts/lib/resulttool/manualexecution.py | 56 +++ 1 file changed, 20

[OE-core] [PATCH 18/33] resulttool/manualexecution: Fixed step sorted by integer

2019-04-10 Thread Armin Kuster
From: Yeoh Ee Peng Currently the manual execution display step by sorting the step as string, where steps were not being sorted correctly when there are more than 9 steps. Fixed the step sorting by sorting step as integer. Signed-off-by: Yeoh Ee Peng Signed-off-by: Richard Purdie

[OE-core] [PATCH 16/33] resulttool/manualexecution: Standardize input check

2019-04-10 Thread Armin Kuster
From: Yeoh Ee Peng Current input checking does not match the standard input practiced by QA team. Change the input checking to match the standard input practiced by the QA team. Signed-off-by: Yeoh Ee Peng Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster ---

[OE-core] [PATCH 14/33] resulttool: Allow store to work on single files

2019-04-10 Thread Armin Kuster
From: Richard Purdie Store operations using a single file as a source weren't working as the os.walk command didn't like being given a single file. Fix the store operation to work for single files. Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster --- scripts/lib/resulttool/store.py

[OE-core] [PATCH 15/33] resulttool: Allow extraction of ptest data

2019-04-10 Thread Armin Kuster
From: Richard Purdie Rather than simply discarding the ptest data, change the code to discard it when writing out the new testresult files, or optionally either preserve it, or write it as seperate discrete logs. This means the autobuilder should start writing out individual ptest log files as

[OE-core] [PATCH 13/33] resulttool: Enable report for single result file

2019-04-10 Thread Armin Kuster
From: Yeoh Ee Peng Current validation check function inside resulttool disallow the report for single result file although the underlying library was able to handle both directory and file as source input to report. Removed the validation check as it was no longer needed and to enable report for

[OE-core] [PATCH 10/33] oeqa/manual/kernel-dev.json: test id updated

2019-04-10 Thread Armin Kuster
From: sangeeta jain All test id (eg. @alias) inside manual testcase file shall follow the same test id naming convention from oeqa automated tests (eg. selftest, runtime, sdk, etc), where the test id consists of ... Furthermore, there shall be only 1 unique test_module per each manual

[OE-core] [PATCH 09/33] oeqa/manual/compliance-test.json: test id updated and missing test cases added

2019-04-10 Thread Armin Kuster
From: sangeeta jain Two changes made in oeqa/manual/compliance-test.json: 1. All test id (eg. @alias) inside manual testcase file shall follow the same test id naming convention from oeqa automated tests (eg. selftest, runtime, sdk, etc), where the test id consists of ... Furthermore, there

[OE-core] [PATCH 12/33] oeqa/manual/toaster: updated test id naming

2019-04-10 Thread Armin Kuster
From: Yeoh Ee Peng All test id (eg. @alias) inside manual testcase file shall follow the same test id naming convention from oeqa automated tests (eg. selftest, runtime, sdk, etc), where the test id consists of ... Furthermore, there shall be only 1 unique test_module per each manual testcases

[OE-core] [PATCH 08/33] oeqa/manual/bsp-hw.json: test id updated and obsolete test cases removed

2019-04-10 Thread Armin Kuster
From: sangeeta jain Two changes made in oeqa/manual/bsp-hw.json: 1. All test id (eg. @alias) inside manual testcase file shall follow the same test id naming convention from oeqa automated tests (eg. selftest, runtime, sdk, etc), where the test id consists of ... Furthermore, there shall be

[OE-core] [PATCH 07/33] oeqa/manual/bsp-hw.json: add non-IA tests

2019-04-10 Thread Armin Kuster
From: Mazliana QA team found that 10 manual bsp test cases from Testopia for Beaglebone, EdgeRouter, and MPC need to be up streamed [YOCTO #12650] Signed-off-by: Mazliana Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster --- meta/lib/oeqa/manual/bsp-hw.json | 260

[OE-core] [PATCH 05/33] oeqa/manual: Add manual runtime 'compliance' testcases to json

2019-04-10 Thread Armin Kuster
From: Sudhir Sharma Added json file for compliance test cases to the manual runtime tests Signed-off-by: Sudhir Sharma Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster --- meta/lib/oeqa/manual/compliance-test.json | 142 ++ 1 file changed, 142

[OE-core] [PATCH 06/33] oeqa/manual/sdk.json: Updated toolchain tarball to core-image-sato

2019-04-10 Thread Armin Kuster
From: sangeeta jain Manual test step for SDK is updated. Previously toolchain was "poky-glibc-x86_64-core-image-sato-sdk-toolchain-.sh" But toochain for core-image-sato-sdk is not available in releases after 2.1, hence changed it to "poky-glibc-x86_64-core-image-sato--toolchain-.sh Other

[OE-core] [PATCH 04/33] oeqa/manual/bsp-qemu.json: Update for QEMU_USE_KVM

2019-04-10 Thread Armin Kuster
From: Robert Yang Now QEMU_USE_KVM can only be boolean, can not contain MACHINE any more. Signed-off-by: Robert Yang Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster --- meta/lib/oeqa/manual/bsp-qemu.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[OE-core] [PATCH 02/33] oeqa/manual: Remove bitbake-selftest execution

2019-04-10 Thread Armin Kuster
From: Richard Purdie The autobuilder runs bitbake-selftest already so we don't need to execute this manually. Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster --- meta/lib/oeqa/manual/oe-core.json | 30 -- 1 file changed, 30 deletions(-) diff --git

[OE-core] [PATCH 01/33] oeqa/manual: transfer manual test cases from testopia to oeqa

2019-04-10 Thread Armin Kuster
From: Yeoh Ee Peng As part of the solution to replace Testopia, manual test cases need to be migrated to OEQA. These manual test case json files will serve two use cases. Use case#1: as input to the future commandline-based manual test runner script, where this script will display actions and

[OE-core] [PATCH 03/33] oeqa/manual/build-appliance: Drop test which is already automated

2019-04-10 Thread Armin Kuster
From: Richard Purdie The nightly-build-appliance target already tests this particular build. Signed-off-by: Richard Purdie Signed-off-by: Armin Kuster --- meta/lib/oeqa/manual/build-appliance.json | 26 -- 1 file changed, 26 deletions(-) diff --git

[OE-core] [PATCH 00/33] Sumo next patch review

2019-04-10 Thread Armin Kuster
Here are the next batch for sumo. Please review and reply in two days. Base line they passed a-full The following changes since commit 0a2db923fd17019d07d88204b355aa46590f0b97: build-appliance-image: Update to sumo head revision (2019-03-27 23:21:58 +) are available in the git repository

Re: [OE-core] Build broken with current master

2019-04-10 Thread Burton, Ross
On Tue, 9 Apr 2019 at 22:41, Andreas Müller wrote: > > The recipe that depends on docbook-xml-dtd4-native also needs to > > depend on libxml2-native. > > Do I have to go through recipes failing - or is there a chance for a > common solution? Very few recipes should be depending directly on

Re: [OE-core] Eclipse support dropped with immediate effect

2019-04-10 Thread richard . purdie
On Wed, 2019-04-10 at 05:56 +0530, akuster808 wrote: > > On 4/9/19 8:52 PM, Richard Purdie wrote: > > I'm sorry to have to say this but the project is terminating its > > official eclipse plugin support with immediate effect. > > Does this affect the stable branches as well? Yes, I think we'll

[OE-core] [PATCH] systemd: install libnss-myhostname.so when myhostname be enabled

2019-04-10 Thread Wenlin Kang
This fixes the follow issue, the cause is that net-tools needs libnss-myhostname.so when run "hostname -s". root@qemuarm64:~# hostname -s hostname: Unknown host Signed-off-by: Wenlin Kang --- meta/recipes-core/systemd/systemd_241.bb | 1 + 1 file changed, 1 insertion(+) diff --git

[OE-core] [PATCH] sanity: check_perl_modules bug fix

2019-04-10 Thread Zheng Ruoqin
Fix Python3 TypeError error in check_perl_modules: Executing bitbake, the following error message will be throwed: File ".../poky/meta/classes/sanity.bbclass", line 979, in check_sanity_eventhandler check_sanity(sanity_data) File ".../poky/meta/classes/sanity.bbclass", line 943, in

[OE-core] [oe-core][PATCH] recipetool: add missed module

2019-04-10 Thread Lei Yang
When I use recipetool to add a new recipe, it says: [snip] sys.exit(14) NameError: name 'sys' is not defined [snip] Signed-off-by: Lei Yang --- scripts/lib/recipetool/create_npm.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/lib/recipetool/create_npm.py