Re: [OE-core] [PATCH v2] cmake: remove CMAKE_ASM_FLAGS variable in toolchain file

2022-07-18 Thread Martin Beeger
Am 18.07.22 um 19:08 schrieb Khem Raj: On Mon, Jul 18, 2022 at 12:51 PM Martin Beeger wrote: As discussied in [YOCTO #14717] cmake contains a OEToolchainConfig.cmake file to configure the toolchain correctly in cross-compile build for recipes using cmake. The CMAKE_ASM_FLAGS are the

[OE-core] [PATCH v2] cmake: remove CMAKE_ASM_FLAGS variable in toolchain file

2022-07-18 Thread Martin Beeger
other compilers. So this variable might neever have worked and it is better for recipes to specify their own. Signed-off-by: Martin Beeger --- meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/meta/recipes-devtools/cmake/cmake

Re: [OE-core] [PATCH] cmake: read asm flags correctly from environment in toolchain file

2022-07-18 Thread Martin Beeger
oh wait, I failed to send v2 of this patch. Will do so. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#168242): https://lists.openembedded.org/g/openembedded-core/message/168242 Mute This Topic: https://lists.openembedded.org/mt/89138781/21656 Grou

Re: [OE-core] [PATCH] cmake: read asm flags correctly from environment in toolchain file

2022-07-18 Thread Martin Beeger
I looked further, and the variable is misspelt and should be CMAKE_AS_FLAGS to have any effect. Furthermore, it is not recommended to set it explicitly, as cmake will initialize it to the correct default. If the toolchain file from open embedded in general contains ASFLGS, cmake wills et that as

Re: [OE-core] [PATCHv2] cmake: remove CMAKE_ASM_FLAGS variable in toolchain file

2022-02-18 Thread Martin Beeger
If you provide ASFLAGS CMake will already load them into CMAKE_AS_FLAGS anyway, they will just not be force-overriden. Martin Am 17.02.22 um 20:46 schrieb Khem Raj: On 2/17/22 7:57 AM, Martin Beeger wrote: As discussied in [YOCTO #14717] cmake contains a OEToolchainConfig.cmake file to

[OE-core] [PATCHv2] cmake: remove CMAKE_ASM_FLAGS variable in toolchain file

2022-02-17 Thread Martin Beeger
other compilers. So this variable might neever have worked and it is better for recipes to specify their own. Signed-off-by: Martin Beeger --- meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/meta/recipes-devtools/cmake/cmake

Re: [OE-core] [PATCH] cmake: read asm flags correctly from environment in toolchain file

2022-02-15 Thread Martin Beeger
them to programs (in openembedded)? Am 15.02.22 um 15:18 schrieb Peter Kjellerstedt: -Original Message- From: openembedded-core@lists.openembedded.org On Behalf Of Martin Beeger Sent: den 14 februari 2022 17:32 To: Richard Purdie ; openembedded- c...@lists.openembedded.org Subject: Re

Re: [OE-core] [PATCH] cmake: read asm flags correctly from environment in toolchain file

2022-02-14 Thread Martin Beeger
I'm a little more puzzled on this one since whilst we set CFLAGS and CXXFLAGS in bitbake.conf, we don't set ASMFLAGS and it wouldn't be present in our environment. Perhaps this should be $ENV{CFLAGS} instead of ${CMAKE_C_FLAGS}? There are flags in our CFLAGS which like need to be passed to the

[OE-core] [PATCH] cmake: read asm flags correctly from environment in toolchain file

2022-02-14 Thread Martin Beeger
. This changes the toolchain so cmake correctly picks up the given ASMFLAGS instead of errorneously forcing the C flags instead. Signed-off-by: Martin Beeger --- meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes

[OE-core] [PATCH] cmake: remove bogus CMAKE_LDFLAGS_FLAGS definition from toolchain file

2022-02-11 Thread Martin Beeger
, CMAKE_EXE_LINKER_FLAGS and CMAKE_MODULE_LINKER_FLAGS to be set instead. As cmake already correctly initializes these from environment there is no need to specify the linker flags in the toolchain file at all. So this just removes the variable, as its value was also set wrong. Signed-off-by: Martin Beeger