Re: [OE-core] [PATCH] uboot-sign: fix loop in do_uboot_assemble_fitimage

2024-05-03 Thread Sean Anderson via lists.openembedded.org
On 5/3/24 11:18, Ralph Siemsen wrote: > When using multiple u-boot configurations in UBOOT_CONFIG, the helper > function uboot_assemble_fitimage_helper() was not called with all > combinations of type & binary, due to a copy-n-paste indexing error. > > Signed-off-by: Ralph Siemsen > --- >

Re: [OE-core] [PATCH 6/6] u-boot: Rework signing to remove interdependencies

2022-11-10 Thread Sean Anderson via lists.openembedded.org
On 11/9/22 18:07, Alexandre Belloni wrote: > Hi, > > On 01/11/2022 13:54:18-0400, Sean Anderson wrote: >> > That would result in a lot of messages on the mailing list and ends up >> > being a lot of work for the maintainers as well. >> >> If you use a tool like b4 [1] it can automatically

Re: [OE-core] [PATCH 6/6] u-boot: Rework signing to remove interdependencies

2022-11-01 Thread Sean Anderson via lists.openembedded.org
On 11/1/22 14:02, Alexander Kanavin wrote: > [You don't often get email from alex.kana...@gmail.com. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > On Tue, 1 Nov 2022 at 18:54, Sean Anderson via lists.openembedded.org > wrote: >> If y

Re: [OE-core] [PATCH 6/6] u-boot: Rework signing to remove interdependencies

2022-11-01 Thread Sean Anderson via lists.openembedded.org
On 11/1/22 13:44, Richard Purdie wrote: > On Tue, 2022-11-01 at 13:40 -0400, Sean Anderson wrote: >> On 11/1/22 13:29, Richard Purdie wrote: >> > On Tue, 2022-11-01 at 12:14 -0400, Sean Anderson wrote: >> > > On 10/28/22 11:37, Richard Purdie wrote: >> > > > On Fri, 2022-10-28 at 11:29 -0400, Sean

Re: [OE-core] [PATCH 6/6] u-boot: Rework signing to remove interdependencies

2022-11-01 Thread Sean Anderson via lists.openembedded.org
On 11/1/22 13:29, Richard Purdie wrote: > On Tue, 2022-11-01 at 12:14 -0400, Sean Anderson wrote: >> On 10/28/22 11:37, Richard Purdie wrote: >> > On Fri, 2022-10-28 at 11:29 -0400, Sean Anderson wrote: >> > > On 10/28/22 11:09, Richard Purdie wrote: >> > > > On Wed, 2022-10-26 at 13:21 -0400,

Re: [OE-core] [PATCH 6/6] u-boot: Rework signing to remove interdependencies

2022-11-01 Thread Sean Anderson via lists.openembedded.org
On 10/28/22 11:37, Richard Purdie wrote: > On Fri, 2022-10-28 at 11:29 -0400, Sean Anderson wrote: >> On 10/28/22 11:09, Richard Purdie wrote: >> > On Wed, 2022-10-26 at 13:21 -0400, Sean Anderson wrote: >> > > As noted in the cover letter, I ran >> > > >> > > oe-selftest -r

Re: [OE-core] [PATCH 6/6] u-boot: Rework signing to remove interdependencies

2022-10-28 Thread Sean Anderson via lists.openembedded.org
On 10/28/22 11:09, Richard Purdie wrote: On Wed, 2022-10-26 at 13:21 -0400, Sean Anderson wrote: On 10/26/22 13:00, Richard Purdie wrote: On Wed, 2022-10-26 at 12:49 -0400, Sean Anderson wrote: On 10/26/22 10:08, Richard Purdie wrote: This looks like a pretty nice improvement, I've been

Re: [OE-core] [PATCH 6/6] u-boot: Rework signing to remove interdependencies

2022-10-26 Thread Sean Anderson via lists.openembedded.org
On 10/26/22 13:00, Richard Purdie wrote: > On Wed, 2022-10-26 at 12:49 -0400, Sean Anderson wrote: >> On 10/26/22 10:08, Richard Purdie wrote: >> > This looks like a pretty nice improvement, I've been worried about how >> > entangled all this was becoming. Is there anything better we could do >> >

Re: [OE-core] [PATCH 6/6] u-boot: Rework signing to remove interdependencies

2022-10-26 Thread Sean Anderson via lists.openembedded.org
On 10/26/22 10:08, Richard Purdie wrote: > On Fri, 2022-10-21 at 19:37 -0400, Sean Anderson wrote: >> The U-Boot signing code is a bit of a mess. The problem is that mkimage >> determines the public keys to embed into a device tree based on an image >> that it is signing. This results in all sorts

[OE-core] [PATCH 6/6] u-boot: Rework signing to remove interdependencies

2022-10-21 Thread Sean Anderson via lists.openembedded.org
The U-Boot signing code is a bit of a mess. The problem is that mkimage determines the public keys to embed into a device tree based on an image that it is signing. This results in all sorts of contortions: U-Boot has to be available to the kernel recipe so that it can have the correct public keys

[OE-core] [PATCH 5/6] uboot-sign: Split off kernel-fitimage variables

2022-10-21 Thread Sean Anderson via lists.openembedded.org
In preparation for the next commit, split off several Signed-off-by: Sean Anderson --- meta/classes-recipe/kernel-fitimage.bbclass | 25 + meta/classes-recipe/uboot-config.bbclass| 3 +++ meta/classes-recipe/uboot-sign.bbclass | 19 3 files

[OE-core] [PATCH 4/6] uboot-sign: Use bitbake variables directly

2022-10-21 Thread Sean Anderson via lists.openembedded.org
uboot_fitimage_assemble is called from one place with the same arguments. Instead of using shell variables as intermediaries, simplify the function by using the bitbake variables directly. Removing a layer of indirection makes it easier to determine what values are being substituted in. Some

[OE-core] [PATCH 3/6] kernel-fitimage: Use KERNEL_OUTPUT_DIR where appropriate

2022-10-21 Thread Sean Anderson via lists.openembedded.org
We have a specific variable for the path to the boot directory. Use it instead of open-coding this path. Signed-off-by: Sean Anderson --- meta/classes-recipe/kernel-fitimage.bbclass | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[OE-core] [PATCH 0/6] u-boot: Rework signing process to remove interdependencies

2022-10-21 Thread Sean Anderson via lists.openembedded.org
This series reworks the uboot-sign and kernel-fitimage classes to cut their intertwining web of dependencies. We do this by signing the kernel image twice: once for real, and once to embed the keys into U-Boot's dtb. This cuts two of the dependencies between U-Boot and Linux's recipes, and moves

[OE-core] [PATCH 1/6] uboot-sign: Fix using wrong KEY_REQ_ARGS

2022-10-21 Thread Sean Anderson via lists.openembedded.org
When generating our SPL-verifying certificate, we use FIT_KEY_REQ_ARGS, which is intended for the U-Boot-verifying certificate. Instead, use UBOOT_FIT_KEY_REQ_ARGS. Fixes: 0e6b0fefa0 ("u-boot: Use a different Key for SPL signing") Signed-off-by: Sean Anderson ---

[OE-core] [PATCH 2/6] kernel: Clear SYSROOT_DIRS instead of replacing sysroot_stage_all

2022-10-21 Thread Sean Anderson via lists.openembedded.org
Replacing sysroot_stage_all by a no-op recipe makes it difficult for bbappends to stage files intentionally. Instead, just clear SYSROOT_DIRS, allowing other bbappends to easily add new directories. Signed-off-by: Sean Anderson --- meta/classes-recipe/kernel.bbclass | 4 +--- 1 file changed, 1

Re: [OE-core] [PATCH] dbus: Fix incorrect path for container sockets

2022-10-07 Thread Sean Anderson via lists.openembedded.org
On 10/7/22 3:23 AM, Michael Opdenacker wrote: > [You don't often get email from michael.opdenac...@bootlin.com. Learn why > this is important at https://aka.ms/LearnAboutSenderIdentification ] > > Hi Sean > > On 06.10.22 23:03, Sean Anderson via lists.openembedded.org wrote

Re: [OE-core] [PATCH] dbus: Fix incorrect path for container sockets

2022-10-06 Thread Sean Anderson via lists.openembedded.org
On 10/6/22 5:02 PM, Sean Anderson wrote: > I noticed the following warning from systemd-tmpfiles while booting: > > /usr/lib/tmpfiles.d/dbus.conf:13: Line references path below legacy > directory /var/run/, updating /var/run/dbus/containers > > The offending line [1] is > > d

[OE-core] [PATCH] dbus: Fix incorrect path for container sockets

2022-10-06 Thread Sean Anderson via lists.openembedded.org
I noticed the following warning from systemd-tmpfiles while booting: /usr/lib/tmpfiles.d/dbus.conf:13: Line references path below legacy directory /var/run/, updating /var/run/dbus/containers The offending line [1] is d @EXPANDED_RUNSTATEDIR@/dbus/containers 0755 @DBUS_USER@ - - - We

Re: [OE-core] [PATCH] rootfs.py: find .ko.zst kernel modules

2022-06-02 Thread Sean Anderson via lists.openembedded.org
Hi Luca, On 6/1/22 3:13 AM, Luca Ceresoli wrote: > [You don't often get email from luca.ceres...@bootlin.com. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification.] > > Hi Sean, > > Il giorno Tue, 31 May 2022 11:10:52 -0400 > "Sean Anderson

[OE-core] [PATCH] rootfs.py: find .ko.zst kernel modules

2022-05-31 Thread Sean Anderson via lists.openembedded.org
With CONFIG_MODULE_COMPRESS_ZSTD enabled, kernel modules will have a .ko.zst extension. This fixes depmod not being run. Fixes: 1b696a45ddb ("rootfs.py: Add check for kernel modules before running depmod") Signed-off-by: Sean Anderson --- meta/lib/oe/rootfs.py | 2 +- 1 file changed, 1

[OE-core] [PATCH] wic: Add dependencies for erofs-utils

2022-04-26 Thread Sean Anderson via lists.openembedded.org
In order to build erofs filesystems, wic must have the erofs-utils package installed into its sysroot. Fixes: 30375ce97 ("Add support for erofs filesystems") Signed-off-by: Sean Anderson --- meta/classes/image_types_wic.bbclass | 2 +- meta/recipes-core/meta/wic-tools.bb | 2 +-

Re: [OE-core] [PATCH] libpcap: Disable DPDK explicitly

2022-04-05 Thread Sean Anderson via lists.openembedded.org
On 4/5/22 11:02 AM, Mittal, Anuj wrote: > On Thu, 2022-02-10 at 15:49 -0500, Sean Anderson via > lists.openembedded.org wrote: >> libpcap looks for DPDK in the same way it looks for DAG. This can >> poison >> the build even if it doesn't find anything. Explicitly disabl

Re: [OE-core] [PATCH] libpcap: Disable DPDK explicitly

2022-04-05 Thread Sean Anderson via lists.openembedded.org
On 4/5/22 11:02 AM, Mittal, Anuj wrote: > [You don't often get email from anuj.mit...@intel.com. Learn why this is > important at http://aka.ms/LearnAboutSenderIdentification.] > > On Thu, 2022-02-10 at 15:49 -0500, Sean Anderson via > lists.openembedded.org wrote: >> l

[OE-core] [PATCH] u-boot: Fix condition for install_spl_helper

2022-04-05 Thread Sean Anderson via lists.openembedded.org
The condition for calling install_spl_helper when compiling multiple configs does not match the condition for a single config. This causes compilation failures when ${UBOOT_FITIMAGE_ENABLE} is 1 but ${SPL_SIGN_ENABLE} is not. Fixes: 5af4dfe83c2 ("u-boot: Add infrastructure to SPL verified boot")

Re: [OE-core] [PATCH] libpcap: Disable DPDK explicitly

2022-04-05 Thread Sean Anderson via lists.openembedded.org
On 2/10/22 3:49 PM, Sean Anderson wrote: > libpcap looks for DPDK in the same way it looks for DAG. This can poison > the build even if it doesn't find anything. Explicitly disable dpdk. > > Signed-off-by: Sean Anderson > --- > > meta/recipes-connectivity/libpcap/libpcap_1.10.1.bb | 3 ++- >

[OE-core] [PATCH] libpcap: Disable DPDK explicitly

2022-02-10 Thread Sean Anderson via lists.openembedded.org
libpcap looks for DPDK in the same way it looks for DAG. This can poison the build even if it doesn't find anything. Explicitly disable dpdk. Signed-off-by: Sean Anderson --- meta/recipes-connectivity/libpcap/libpcap_1.10.1.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git