[OE-core] [PATCH] Added quotes around variables to prevent word splitting in the oe-init-build-env/oe-setup-builddir shell scripts.

2022-04-05 Thread Abongwa Amahnui Bonalais
Used shellcheck to add quotes to the variables. This is to make sure that directories with names that have space between, such as "Desktop/projects/test repo/poky" will not be considered as 2 separate words. With this modification, running the command "source oe-init-build-env" will not give th

Re: [OE-core] [PATCH] Added quotes around variables to prevent word splitting in the oe-init-build-env/oe-setup-builddir shell scripts.

2022-04-05 Thread Chen Qi
Whitespace is not a valid char in builddir. There's sanity check for this in sanity.bbclass: if val.find(' ') != -1:     status.addresult("Error, you have a space in your %s directory path. Please move the installation to a directory which doesn't include a space since autotools doesn't

Re: [OE-core] [PATCH] Added quotes around variables to prevent word splitting in the oe-init-build-env/oe-setup-builddir shell scripts.

2022-04-05 Thread Abongwa Amahnui Bonalais
Hi Qi Thanks for the clarity, Therefore there is no need to put whitespaces in qoutes if it will be checked for and an error message reported concerning it in future. That means we just have to let oe-init-build-env  tell you at the early stages. Thanks I understand. -=-=-=-=-=-=-=-=-=-=-=- Links

Re: [OE-core] [PATCH] Added quotes around variables to prevent word splitting in the oe-init-build-env/oe-setup-builddir shell scripts.

2022-04-06 Thread Richard Purdie
On Wed, 2022-04-06 at 11:08 +0800, Chen Qi wrote: > Whitespace is not a valid char in builddir. There's sanity check for > this in sanity.bbclass: > if val.find(' ') != -1: >     status.addresult("Error, you have a space in your %s > directory path. Please move the installation to a dire

Re: [OE-core] [PATCH] Added quotes around variables to prevent word splitting in the oe-init-build-env/oe-setup-builddir shell scripts.

2022-04-06 Thread Abongwa Amahnui Bonalais
Hi Richard I presume it is a good change since the user will know what is wrong and be able to fix it. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#164058): https://lists.openembedded.org/g/openembedded-core/message/164058 Mute This Topic: https

Re: [OE-core] [PATCH] Added quotes around variables to prevent word splitting in the oe-init-build-env/oe-setup-builddir shell scripts.

2022-04-06 Thread Richard Purdie
On Wed, 2022-04-06 at 00:37 -0700, Abongwa Amahnui Bonalais wrote: > Hi Richard  > I presume it is a good change since the user will know what is wrong and be > able to fix it. Yes, I did merge it to master with a small fix to the subject line to clarify where the patch was being applied to. Chee

Re: [OE-core] [PATCH] Added quotes around variables to prevent word splitting in the oe-init-build-env/oe-setup-builddir shell scripts.

2022-04-06 Thread Abongwa Amahnui Bonalais
Hi Richard, I am happy to have made a positive addition. Thanks -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#164061): https://lists.openembedded.org/g/openembedded-core/message/164061 Mute This Topic: https://lists.openembedded.org/mt/90270943/21