Re: [OE-core] [PATCH] base.bbclass wipe ${S} before unpacking source

2016-03-04 Thread Mike Looijmans
You might want to assure that S is a child of WORKDIR before wiping it. Strange things would happen if someone tried setting S=$HOME in a recipe (by mistake or just for experimenting). On 23-02-16 12:36, Markus Lehtonen wrote: Make sure that we have a pristine source tree after do_unpack.

Re: [OE-core] [PATCH] base.bbclass wipe ${S} before unpacking source

2016-02-24 Thread Markus Lehtonen
On Tue, 2016-02-23 at 18:23 +, Burton, Ross wrote: > > On 23 February 2016 at 18:01, Christopher Larson > wrote: > > db isn't the only recipe doing that. The fetcher unpack method > > knows where it's unpacking to, I think if anyone should be clearing > > out the

Re: [OE-core] [PATCH] base.bbclass wipe ${S} before unpacking source

2016-02-23 Thread Burton, Ross
On 23 February 2016 at 18:01, Christopher Larson wrote: > db isn't the only recipe doing that. The fetcher unpack method knows where > it's unpacking to, I think if anyone should be clearing out the destination > first, it should. If that's true for tarballs, I agree. I

Re: [OE-core] [PATCH] base.bbclass wipe ${S} before unpacking source

2016-02-23 Thread Christopher Larson
On Tue, Feb 23, 2016 at 6:55 AM Burton, Ross wrote: > > On 23 February 2016 at 11:36, Markus Lehtonen < > markus.lehto...@linux.intel.com> wrote: > >> Make sure that we have a pristine source tree after do_unpack. >> > > Interestingly this fails on db-native rebuild for

Re: [OE-core] [PATCH] base.bbclass wipe ${S} before unpacking source

2016-02-23 Thread Burton, Ross
On 23 February 2016 at 11:36, Markus Lehtonen < markus.lehto...@linux.intel.com> wrote: > Make sure that we have a pristine source tree after do_unpack. > Interestingly this fails on db-native rebuild for me, as db is playing games with S (it's not the top of the tarball). I had a look at the

[OE-core] [PATCH] base.bbclass wipe ${S} before unpacking source

2016-02-23 Thread Markus Lehtonen
Make sure that we have a pristine source tree after do_unpack. [YOCTO #9064] Signed-off-by: Markus Lehtonen --- meta/classes/base.bbclass | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/meta/classes/base.bbclass