icecc preprocesses source files locally before shipping them off to be compiled
on remote hosts. This preprocessing removes comments, including /* fallthrough
*/
comments in switch statements that normally prevent the implicit-fallthrough
warning.
Rather than turning off -Werror by patching confi
Considering the pain that the gcc upgrade introducing that warning
caused I'll be *very* surprised if this problem is limited to json-c.
Could the icecc class forcibly disable that warning instead?
Ross
On Thu, 6 Jun 2019 at 03:06, Douglas Royds via Openembedded-core
wrote:
>
> icecc preprocesse
I struggled to find a solution that would work in the -native case, as
we need to support gcc as old as 5.4 (Ubuntu 16.04).
The problem is somewhat specific to json-c, as -Werror is hard-coded
into configure.ac in this package.
On 6/06/19 9:45 PM, Burton, Ross wrote:
Considering the pain t
FWIW: I've fixed a few upstream recipes that were doing this to use the
__attribute__((fallthrough)) instead of a comment.
Anyway, usually the correct fix is to add the package to
ICECC_SYSTEM_PACKAGE_BL in icecc.bbclass; it is maybe not ideal but
ICECC_DISABLED is the user control for enablin
__attribute__((fallthrough)) wouldn't help us with gcc 5.4 in the
-native case, of course.
I'll resubmit the patch using ICECC_SYSTEM_PACKAGE_BL
On 7/06/19 9:15 AM, Joshua Watt wrote:
FWIW: I've fixed a few upstream recipes that were doing this to use
the __attribute__((fallthrough)) instead
On Thu, 6 Jun 2019 at 22:03, Douglas Royds wrote:
> The problem is somewhat specific to json-c, as -Werror is hard-coded
> into configure.ac in this package.
Which is downright evil, and to be honest we should patch that out.
Ross
--
___
Openembedded-
