Re: [OE-core] [PATCH] json-c: fix icecc compilation

2023-11-29 Thread Marco Felsch
On 23-11-29, Alexander Kanavin wrote: > On Wed, 29 Nov 2023 at 10:36, Marco Felsch wrote: > > > I don't like removing WERROR unconditionally which decreases quality > > > checks. > > > Can we do it only in case ICECC is used? > > > Something like "${@'-DDISABLE_WERROR=ON' if bb.data.inherits_clas

Re: [OE-core] [PATCH] json-c: fix icecc compilation

2023-11-29 Thread Alexander Kanavin
On Wed, 29 Nov 2023 at 10:36, Marco Felsch wrote: > > I don't like removing WERROR unconditionally which decreases quality checks. > > Can we do it only in case ICECC is used? > > Something like "${@'-DDISABLE_WERROR=ON' if bb.data.inherits_class(icecc, > > d) else ''}" > > Good point, but IMHO I

Re: [OE-core] [PATCH] json-c: fix icecc compilation

2023-11-29 Thread Marco Felsch
...@pengutronix.de; m...@pengutronix.de > Subject: [OE-core] [PATCH] json-c: fix icecc compilation > > > Skip -Werror to make it possible to compile this recipe with ICECC else all > > fallthrough comments will be removed since we pre-process the files on the > > host before sendi

Re: [OE-core] [PATCH] json-c: fix icecc compilation

2023-11-28 Thread Peter Marko via lists.openembedded.org
-Original Message- From: openembedded-core@lists.openembedded.org On Behalf Of Marco Felsch via lists.openembedded.org Sent: Tuesday, November 28, 2023 23:48 To: openembedded-core@lists.openembedded.org Cc: yo...@pengutronix.de; m...@pengutronix.de Subject: [OE-core] [PATCH] json-c: fix

[OE-core] [PATCH] json-c: fix icecc compilation

2023-11-28 Thread Marco Felsch
Skip -Werror to make it possible to compile this recipe with ICECC else all fallthrough comments will be removed since we pre-process the files on the host before sending them to the compile nodes which then cause errors because of default -Werror switch. Fixes: caf64f85b5c5 ("json-c: update 0.13.