[OE-core] [PATCH] populate SDK: prepare calling of bb.utils for exceptions

2015-10-15 Thread Benjamin Esquivel
bb.utils.remove, bb.utils.movefile and bb.utils.mkdirhier can throw exceptions that need handling and proper error messages. [YOCTO#8213] Signed-off-by: Benjamin Esquivel --- meta/lib/oe/sdk.py | 81 ++ 1 file changed, 57 insertions(+), 24 del

Re: [OE-core] [PATCH] populate SDK: prepare calling of bb.utils for exceptions

2015-10-15 Thread Christopher Larson
On Thu, Oct 15, 2015 at 10:27 AM, Benjamin Esquivel < benjamin.esqui...@linux.intel.com> wrote: > +def movefile(self, sourcefile, destdir): > +try: > +# FIXME: this check of movefile's return code to None should > be > +# fixed within the function to use only ex

Re: [OE-core] [PATCH] populate SDK: prepare calling of bb.utils for exceptions

2015-10-16 Thread Mike Looijmans
On 15-10-15 19:27, Benjamin Esquivel wrote: bb.utils.remove, bb.utils.movefile and bb.utils.mkdirhier can throw exceptions that need handling and proper error messages. [YOCTO#8213] ... +def mkdirhier(self, dirpath): +try: +bb.utils.mkdirhier(dirpath) +except O

Re: [OE-core] [PATCH] populate SDK: prepare calling of bb.utils for exceptions

2015-10-16 Thread Richard Purdie
On Thu, 2015-10-15 at 12:27 -0500, Benjamin Esquivel wrote: > +if (bb.utils.movefile(sourcefile, destdir) == None): > +raise Exception("moving {} to {} failed".format( > +sourcefile, destdir)) Its a minor issue, however rightly or

Re: [OE-core] [PATCH] populate SDK: prepare calling of bb.utils for exceptions

2015-10-16 Thread Benjamin Esquivel
On Fri, 2015-10-16 at 11:01 +0100, Richard Purdie wrote: > On Thu, 2015-10-15 at 12:27 -0500, Benjamin Esquivel wrote: > > +if (bb.utils.movefile(sourcefile, destdir) == None): > > +raise Exception("moving {} to {} failed".format( > > +

Re: [OE-core] [PATCH] populate SDK: prepare calling of bb.utils for exceptions

2015-10-16 Thread Benjamin Esquivel
On Thu, 2015-10-15 at 19:15 -0700, Christopher Larson wrote: > > On Thu, Oct 15, 2015 at 10:27 AM, Benjamin Esquivel < > benjamin.esqui...@linux.intel.com> wrote: > > +def movefile(self, sourcefile, destdir): > > +try: > > +# FIXME: this check of movefile's return code to N

Re: [OE-core] [PATCH] populate SDK: prepare calling of bb.utils for exceptions

2015-10-16 Thread Benjamin Esquivel
Hello Mike, comments below: On Fri, 2015-10-16 at 09:00 +0200, Mike Looijmans wrote: > On 15-10-15 19:27, Benjamin Esquivel wrote: > > bb.utils.remove, bb.utils.movefile and bb.utils.mkdirhier can throw > > exceptions that need handling and proper error messages. > > > > [YOCTO#8213] > ... > > +