Re: [OE-core] [PATCH] python2: Add PACKAGECONFIG for tkinter to support tk from meta-oe

2014-07-20 Thread Martin Jansa
On Sun, Jul 20, 2014 at 09:01:05PM -0400, Jate S wrote: > The presence of the tk library determines whether python's compile > task will build tkinter. Then the presence of python-tkinter in > IMAGE_INSTALL will then determine whether it is installed. > > In the absence of tk provided by meta-oe,

Re: [OE-core] [PATCH] python2: Add PACKAGECONFIG for tkinter to support tk from meta-oe

2014-07-20 Thread Jate S
The presence of the tk library determines whether python's compile task will build tkinter. Then the presence of python-tkinter in IMAGE_INSTALL will then determine whether it is installed. In the absence of tk provided by meta-oe, the python recipe will install an empty python-tkinter package. I

Re: [OE-core] [PATCH] python2: Add PACKAGECONFIG for tkinter to support tk from meta-oe

2014-07-14 Thread Enrico Scholz
Jate S writes: > Python 2.7.x does not use an explicit configure option for tk support. > Instead, it tries to detect the tk and tcl libraries before compiling > python-tkinter. Your patch does not solve the issue of non-deterministic builds. When tk was added by some other way, python will get

Re: [OE-core] [PATCH] python2: Add PACKAGECONFIG for tkinter to support tk from meta-oe

2014-07-14 Thread Jate S
Python 2.7.x does not use an explicit configure option for tk support. Instead, it tries to detect the tk and tcl libraries before compiling python-tkinter. In PACKAGECONFIG[*], items three and four are the DEPENDS and RDEPENDS, respectively. They are only added to the python DEPENDS/RDEPENDS when

Re: [OE-core] [PATCH] python2: Add PACKAGECONFIG for tkinter to support tk from meta-oe

2014-07-14 Thread Enrico Scholz
Jate Sujjavanich writes: > +PACKAGECONFIG[tkinter] = ",,tk,tk tk-lib" What do you want to reach with this? Afais, build is not more deterministic than before and requiring both 'tk' and 'tk-lib' when 'tkinter' is *not* enabled does not look sane to me either. You probably want something like

[OE-core] [PATCH] python2: Add PACKAGECONFIG for tkinter to support tk from meta-oe

2014-07-14 Thread Jate Sujjavanich
Previously, the python recipe did not have a way to add a DEPENDS on tk. This makes the option available for users of the meta-oe/meta-oe layer. Signed-off-by: Jate Sujjavanich --- meta/recipes-devtools/python/python_2.7.3.bb |2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/recipes