Re: [OE-core] [PATCH] rng-tools: Fix crazy defaults

2019-03-05 Thread Richard Purdie
On Tue, 2019-03-05 at 07:03 +, Rasmus Villemoes wrote: > On 09/11/2018 09.54, Hongxu Jia wrote: > > Before=sysinit.target > > > > [Service] > > -ExecStart=@SBINDIR@/rngd -f -r /dev/urandom > > +ExecStart=@SBINDIR@/rngd -f -r /dev/hwrng > > SuccessExitStatus=66 > > > > [Install] > > >

Re: [OE-core] [PATCH] rng-tools: Fix crazy defaults

2019-03-05 Thread Rasmus Villemoes
On 09/11/2018 09.54, Hongxu Jia wrote: > Since commit [f1dc9ac rng-tools: Fix crazy defaults] fixed > init based on sysvinit, this fix rngd.service based on systemd. > > Signed-off-by: Hongxu Jia > --- > meta/recipes-support/rng-tools/rng-tools/rngd.service | 2 +- > 1 file changed, 1

Re: [OE-core] [PATCH] rng-tools: Fix crazy defaults

2019-03-02 Thread Rasmus Villemoes
On 09/11/2018 09.54, Hongxu Jia wrote: > Since commit [f1dc9ac rng-tools: Fix crazy defaults] fixed > init based on sysvinit, this fix rngd.service based on systemd. > > Signed-off-by: Hongxu Jia > --- > meta/recipes-support/rng-tools/rng-tools/rngd.service | 2 +- > 1 file changed, 1

[OE-core] [PATCH] rng-tools: Fix crazy defaults

2018-11-09 Thread Hongxu Jia
Since commit [f1dc9ac rng-tools: Fix crazy defaults] fixed init based on sysvinit, this fix rngd.service based on systemd. Signed-off-by: Hongxu Jia --- meta/recipes-support/rng-tools/rng-tools/rngd.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[OE-core] [PATCH] rng-tools: Fix crazy defaults

2017-11-03 Thread Richard Purdie
Feeding the output of /dev/urandom into /dev/random is pretty much insane and not something we should encourage. I can't really imagine a scenario where this would be a sensible idea since /dev/urandom if effectively derived from /dev/random. This changes the tool to default to /dev/hwrng which