Re: [OE-core] [PATCH] systemd: change syntax for SRC_URI append

2022-11-01 Thread Mikko Rapeli
Hi, On Tue, Nov 01, 2022 at 10:10:45AM +0100, Alexander Kanavin wrote: > On Tue, 1 Nov 2022 at 09:12, Peter Bergin wrote: > > This opened my eyes for the way systemd recipes are built up in oe-core. > > It seems a bit the other way around. systemd.inc contains almost only > > version

Re: [OE-core] [PATCH] systemd: change syntax for SRC_URI append

2022-11-01 Thread Martin Jansa
> I do not like bits and pieces of code scattered all over the place and gathered together by bitbake, that does not help readability. My experience is opposite, developers tend to copy whole recipes without explaining why it was copied and what's the important diff they needed compared to

Re: [OE-core] [PATCH] systemd: change syntax for SRC_URI append

2022-11-01 Thread Alexander Kanavin
On Tue, 1 Nov 2022 at 09:12, Peter Bergin wrote: > This opened my eyes for the way systemd recipes are built up in oe-core. > It seems a bit the other way around. systemd.inc contains almost only > version information. systemd_251.4.bb is huge and contains a lot of > thing that I think can be

Re: [OE-core] [PATCH] systemd: change syntax for SRC_URI append

2022-11-01 Thread Peter Bergin
On 2022-10-31 22:54, Alexander Kanavin wrote: On Mon, 31 Oct 2022 at 22:32, Peter Bergin wrote: Sure, I can do that. My aim for override those in a bbappend is just for development purposes and nothing I plan to use in production or push in public. My way of working when I realized this was to

Re: [OE-core] [PATCH] systemd: change syntax for SRC_URI append

2022-10-31 Thread Alexander Kanavin
On Mon, 31 Oct 2022 at 22:32, Peter Bergin wrote: > Sure, I can do that. My aim for override those in a bbappend is just for > development purposes and nothing I plan to use in production or push in > public. My way of working when I realized this was to build latest > master of systemd that had

Re: [OE-core] [PATCH] systemd: change syntax for SRC_URI append

2022-10-31 Thread Peter Bergin
Hi Alex, On 2022-10-31 22:24, Alexander Kanavin wrote: On Mon, 31 Oct 2022 at 22:09, Peter Bergin wrote: In order to be able to override the git repo used in a bbappend file the additions of files to SRC_URI needs to be done with :append instead of +=, otherwise those will not be added. My

Re: [OE-core] [PATCH] systemd: change syntax for SRC_URI append

2022-10-31 Thread Alexander Kanavin
On Mon, 31 Oct 2022 at 22:09, Peter Bergin wrote: > > In order to be able to override the git repo used in a bbappend > file the additions of files to SRC_URI needs to be done with :append > instead of +=, otherwise those will not be added. > > My use case for this change is to try to build

[OE-core] [PATCH] systemd: change syntax for SRC_URI append

2022-10-31 Thread Peter Bergin
In order to be able to override the git repo used in a bbappend file the additions of files to SRC_URI needs to be done with :append instead of +=, otherwise those will not be added. My use case for this change is to try to build latest systemd that is located in another repo than the one used by