Re: [OE-core] [PATCH] wic: isoimage-isohybrid: add grubefi configfile support

2016-04-21 Thread Ioan-Adrian Ratiu
On Thu, 21 Apr 2016 10:03:31 +0300 Ed Bartosh wrote: > On Wed, Apr 20, 2016 at 06:08:38PM +0300, Ioan-Adrian Ratiu wrote: > > I forgot to mention this is v2... sorry. > > > > On Wed, 20 Apr 2016 18:06:15 +0300 > > Ioan-Adrian Ratiu wrote: > > > > > The latest wic kickstart refactoring introd

Re: [OE-core] [PATCH] wic: isoimage-isohybrid: add grubefi configfile support

2016-04-21 Thread Ed Bartosh
On Wed, Apr 20, 2016 at 06:08:38PM +0300, Ioan-Adrian Ratiu wrote: > I forgot to mention this is v2... sorry. > > On Wed, 20 Apr 2016 18:06:15 +0300 > Ioan-Adrian Ratiu wrote: > > > The latest wic kickstart refactoring introduced a bootloader option > > "--configfile" which lets wks' specify a c

Re: [OE-core] [PATCH] wic: isoimage-isohybrid: add grubefi configfile support

2016-04-20 Thread Ioan-Adrian Ratiu
I forgot to mention this is v2... sorry. On Wed, 20 Apr 2016 18:06:15 +0300 Ioan-Adrian Ratiu wrote: > The latest wic kickstart refactoring introduced a bootloader option > "--configfile" which lets wks' specify a custom grub.cfg for use > while booting. This is very useful for creating stuff li

[OE-core] [PATCH] wic: isoimage-isohybrid: add grubefi configfile support

2016-04-20 Thread Ioan-Adrian Ratiu
The latest wic kickstart refactoring introduced a bootloader option "--configfile" which lets wks' specify a custom grub.cfg for use while booting. This is very useful for creating stuff like boot menus. This change lets isoimage-isohybrid use --configfile; if this option is not specified in a wks

Re: [OE-core] [PATCH] wic: isoimage-isohybrid: add grubefi configfile support

2016-04-20 Thread Ed Bartosh
Hi Ioan-Adrian, Thank you for the patch! My comment is below. Please, make sure your change doesn't break wic tests. On Wed, Apr 20, 2016 at 12:17:32PM +0300, Ioan-Adrian Ratiu wrote: > The latest wic kickstart refactoring introduced a bootloader option > "--configfile" which lets wks' specify a

[OE-core] [PATCH] wic: isoimage-isohybrid: add grubefi configfile support

2016-04-20 Thread Ioan-Adrian Ratiu
The latest wic kickstart refactoring introduced a bootloader option "--configfile" which lets wks' specify a custom grub.cfg for use while booting. This is very useful for creating stuff like boot menus. This change lets isoimage-isohybrid use --configfile; if this option is not specified in a wks