Re: [OE-core] [PATCH 1/1] runqemu: fix handling of SIGTERM and the problem of line wrapping

2018-09-24 Thread ChenQi
On 09/21/2018 11:05 PM, Burton, Ross wrote: Is there a good reason why shell=True is used in the first place? Just change the cmd to a list, stop passing shell=True, and you don't need to dance around process groups. Thanks for your suggestion. I'll send out V2 if all things go well with my lo

Re: [OE-core] [PATCH 1/1] runqemu: fix handling of SIGTERM and the problem of line wrapping

2018-09-21 Thread Burton, Ross
Is there a good reason why shell=True is used in the first place? Just change the cmd to a list, stop passing shell=True, and you don't need to dance around process groups. Ross On Fri, 21 Sep 2018 at 03:30, Chen Qi wrote: > > The current handling of SIGTERM is incorrect as the process pid return

[OE-core] [PATCH 1/1] runqemu: fix handling of SIGTERM and the problem of line wrapping

2018-09-20 Thread Chen Qi
The current handling of SIGTERM is incorrect as the process pid returned by Popen call with shell setting to True is actualy the shell instead of the qemu binary. So fix to send SIGTERM to the process group of runqemu. This ensures that all processes in the same process group, including the shell a