Re: [OE-core] [PATCH 1/2] opkg_svn.bb: Install rcS.d into ${D} instead of ${IMAGE_ROOTFS}

2011-05-21 Thread Khem Raj
On Sat, May 21, 2011 at 1:00 AM, Phil Blundell wrote: > On Fri, 2011-05-20 at 16:19 -0700, Khem Raj wrote: >> -     install -d ${IMAGE_ROOTFS}/${sysconfdir}/rcS.d >> +     install -d $D/${sysconfdir}/rcS.d > > Just as a note in passing, this sort of thing is best written as: > >        install -d

Re: [OE-core] [PATCH 1/2] opkg_svn.bb: Install rcS.d into ${D} instead of ${IMAGE_ROOTFS}

2011-05-21 Thread Phil Blundell
On Fri, 2011-05-20 at 16:19 -0700, Khem Raj wrote: > - install -d ${IMAGE_ROOTFS}/${sysconfdir}/rcS.d > + install -d $D/${sysconfdir}/rcS.d Just as a note in passing, this sort of thing is best written as: install -d "${D}${sysconfdir}/rcS.d" i.e. you don't need a slash after ${D

Re: [OE-core] [PATCH 1/2] opkg_svn.bb: Install rcS.d into ${D} instead of ${IMAGE_ROOTFS}

2011-05-20 Thread Khem Raj
On (20/05/11 16:30), Saul Wold wrote: > On 05/20/2011 04:19 PM, Khem Raj wrote: > >Remove headerfix.patch, its already applied upstream > > > Minor nit, should be $D in the subject line also right? OK it should. I have amended the commit and refreshed pull branch > > Sau! > > >Signed-off-by: Kh

Re: [OE-core] [PATCH 1/2] opkg_svn.bb: Install rcS.d into ${D} instead of ${IMAGE_ROOTFS}

2011-05-20 Thread Saul Wold
On 05/20/2011 04:19 PM, Khem Raj wrote: Remove headerfix.patch, its already applied upstream Minor nit, should be $D in the subject line also right? Sau! Signed-off-by: Khem Raj --- meta/recipes-devtools/opkg/opkg/headerfix.patch | 19 --- meta/recipes-devtools/opkg/opkg

[OE-core] [PATCH 1/2] opkg_svn.bb: Install rcS.d into ${D} instead of ${IMAGE_ROOTFS}

2011-05-20 Thread Khem Raj
Remove headerfix.patch, its already applied upstream Signed-off-by: Khem Raj --- meta/recipes-devtools/opkg/opkg/headerfix.patch | 19 --- meta/recipes-devtools/opkg/opkg_svn.bb |3 +-- 2 files changed, 1 insertions(+), 21 deletions(-) delete mode 100644 meta/reci