Re: [OE-core] [PATCH v2] glibc: don't ignore global LDFLAGS settings

2020-02-03 Thread Rasmus Villemoes
ping On 20/01/2020 16.42, Khem Raj wrote: > this patch is ok but I have reservations since += now means global > ldflags will be applied > so it would need some testing to ensure it works well. > > On Mon, Jan 20, 2020 at 1:23 AM Rasmus Villemoes > wrote: >> >> Two things: The -Wl,-rpath-link

Re: [OE-core] [PATCH v2] glibc: don't ignore global LDFLAGS settings

2020-01-20 Thread Rasmus Villemoes
On 20/01/2020 16.42, Khem Raj wrote: > this patch is ok but I have reservations since += now means global > ldflags will be applied Indeed, that's half the point of the patch. > so it would need some testing to ensure it works well. Yes, but I don't think there's any way to figure out if it

Re: [OE-core] [PATCH v2] glibc: don't ignore global LDFLAGS settings

2020-01-20 Thread Khem Raj
this patch is ok but I have reservations since += now means global ldflags will be applied so it would need some testing to ensure it works well. On Mon, Jan 20, 2020 at 1:23 AM Rasmus Villemoes wrote: > > Two things: The -Wl,-rpath-link comment is stale (due to per-recipe > staging), so we no

[OE-core] [PATCH v2] glibc: don't ignore global LDFLAGS settings

2020-01-20 Thread Rasmus Villemoes
Two things: The -Wl,-rpath-link comment is stale (due to per-recipe staging), so we no longer need to set our own LDFLAGS to avoid -Wl,-rpath-link being in there. Second, overriding LDFLAGS should be done at the recipe level so "bitbake -e" can show what is going on. Otherwise debugging why one's