Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-12-06 Thread Andre McCurdy
On Fri, Dec 3, 2021 at 10:07 AM Andre McCurdy wrote: > > On Fri, Dec 3, 2021 at 2:06 AM Richard Purdie > wrote: > > > > On Fri, 2021-12-03 at 01:39 -0800, Andre McCurdy wrote: > > > On Wed, Dec 1, 2021 at 2:33 PM Richard Purdie > > > wrote: > > > > > > > > On Tue, 2021-11-30 at 13:45 -0800,

Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-12-03 Thread Andre McCurdy
> Cc: Ross Burton ; OE Core mailing list > c...@lists.openembedded.org> > > Subject: Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically > > > > On Fri, 2021-12-03 at 01:39 -0800, Andre McCurdy wrote: > > > On Wed, Dec 1, 2021 at 2:33 PM Richar

Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-12-03 Thread Andre McCurdy
On Fri, Dec 3, 2021 at 2:06 AM Richard Purdie wrote: > > On Fri, 2021-12-03 at 01:39 -0800, Andre McCurdy wrote: > > On Wed, Dec 1, 2021 at 2:33 PM Richard Purdie > > wrote: > > > > > > On Tue, 2021-11-30 at 13:45 -0800, Andre McCurdy wrote: > > > > On Tue, Nov 30, 2021 at 1:20 PM Ross Burton

Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-12-03 Thread Peter Kjellerstedt
> -Original Message- > From: openembedded-core@lists.openembedded.org c...@lists.openembedded.org> On Behalf Of Richard Purdie > Sent: den 3 december 2021 11:07 > To: Andre McCurdy > Cc: Ross Burton ; OE Core mailing list c...@lists.openembedded.org> > Subject: R

Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-12-03 Thread Richard Purdie
On Fri, 2021-12-03 at 01:39 -0800, Andre McCurdy wrote: > On Wed, Dec 1, 2021 at 2:33 PM Richard Purdie > wrote: > > > > On Tue, 2021-11-30 at 13:45 -0800, Andre McCurdy wrote: > > > On Tue, Nov 30, 2021 at 1:20 PM Ross Burton wrote: > > > > > > > > On Tue, 30 Nov 2021 at 19:32, Andre McCurdy

Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-12-03 Thread Andre McCurdy
On Wed, Dec 1, 2021 at 2:33 PM Richard Purdie wrote: > > On Tue, 2021-11-30 at 13:45 -0800, Andre McCurdy wrote: > > On Tue, Nov 30, 2021 at 1:20 PM Ross Burton wrote: > > > > > > On Tue, 30 Nov 2021 at 19:32, Andre McCurdy wrote: > > > > This isn't equivalent - it will cause a change in

Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-12-01 Thread Richard Purdie
On Tue, 2021-11-30 at 13:45 -0800, Andre McCurdy wrote: > On Tue, Nov 30, 2021 at 1:20 PM Ross Burton wrote: > > > > On Tue, 30 Nov 2021 at 19:32, Andre McCurdy wrote: > > > This isn't equivalent - it will cause a change in behaviour for anyone > > > using PACKAGECONFIG += "foo" from a

Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-11-30 Thread Andre McCurdy
On Tue, Nov 30, 2021 at 1:20 PM Ross Burton wrote: > > On Tue, 30 Nov 2021 at 19:32, Andre McCurdy wrote: > > This isn't equivalent - it will cause a change in behaviour for anyone > > using PACKAGECONFIG += "foo" from a .bbappend. > > Correct, but this is likely the only recipe in the greater

Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-11-30 Thread Ross Burton
On Tue, 30 Nov 2021 at 19:32, Andre McCurdy wrote: > This isn't equivalent - it will cause a change in behaviour for anyone > using PACKAGECONFIG += "foo" from a .bbappend. Correct, but this is likely the only recipe in the greater ecosystem which has this behaviour, so I'm not that bothered to

Re: [OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-11-30 Thread Andre McCurdy
On Tue, Nov 30, 2021 at 8:53 AM Ross Burton wrote: > > Don't set an empty default value and them immediately assign to it. > > Signed-off-by: Ross Burton > --- > meta/recipes-support/vim/vim.inc | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

[OE-core] [PATCH v2 2/2] vim: set PACKAGECONFIG idiomatically

2021-11-30 Thread Ross Burton
Don't set an empty default value and them immediately assign to it. Signed-off-by: Ross Burton --- meta/recipes-support/vim/vim.inc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/meta/recipes-support/vim/vim.inc b/meta/recipes-support/vim/vim.inc index