Re: [OE-core] [daisy][PATCH 1/1] systemd: do not use alloca() function in case of uclibc

2014-06-03 Thread Holger Freyther
Richard Purdie writes: Hi, > Please just update that patch then rather than patching code that we've > ready patched. Is this issue uclibc specific? the usage of alloca is due me and killing a lot of malloc's in the hot path of log handling. I am late to these patches but my two cents would be

Re: [OE-core] [daisy][PATCH 1/1] systemd: do not use alloca() function in case of uclibc

2014-06-03 Thread Richard Purdie
On Tue, 2014-06-03 at 17:20 +0800, ChenQi wrote: > The use of alloca() was introduced by an oe-specific patch from Khem Raj. > > The patch is > meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch. > The upstream status of the above patch is as following. > Upstream-Status: D

Re: [OE-core] [daisy][PATCH 1/1] systemd: do not use alloca() function in case of uclibc

2014-06-03 Thread ChenQi
On 06/03/2014 05:20 PM, ChenQi wrote: On 06/03/2014 05:06 PM, Richard Purdie wrote: On Tue, 2014-06-03 at 15:42 +0800, Chen Qi wrote: The alloca() function allocates space in the stack frame of the caller, so using alloca(new_size - old_size) would possibly crash the stack, causing a segment fa

Re: [OE-core] [daisy][PATCH 1/1] systemd: do not use alloca() function in case of uclibc

2014-06-03 Thread ChenQi
On 06/03/2014 05:06 PM, Richard Purdie wrote: On Tue, 2014-06-03 at 15:42 +0800, Chen Qi wrote: The alloca() function allocates space in the stack frame of the caller, so using alloca(new_size - old_size) would possibly crash the stack, causing a segment fault error. This patch fixes the above

Re: [OE-core] [daisy][PATCH 1/1] systemd: do not use alloca() function in case of uclibc

2014-06-03 Thread Richard Purdie
On Tue, 2014-06-03 at 15:42 +0800, Chen Qi wrote: > The alloca() function allocates space in the stack frame of the caller, > so using alloca(new_size - old_size) would possibly crash the stack, > causing a segment fault error. > > This patch fixes the above problem by avoiding using this function

[OE-core] [daisy][PATCH 1/1] systemd: do not use alloca() function in case of uclibc

2014-06-03 Thread Chen Qi
The alloca() function allocates space in the stack frame of the caller, so using alloca(new_size - old_size) would possibly crash the stack, causing a segment fault error. This patch fixes the above problem by avoiding using this function in journal-file.c. [YOCTO #6201] Signed-off-by: Chen Qi