Re: [OE-core] [wic][PATCH 04/20] wic: Refactor getting bitbake variables

2015-06-30 Thread Ed Bartosh
Hi Cristopher, On Mon, Jun 29, 2015 at 02:48:30PM -0700, Christopher Larson wrote: On Mon, Jun 29, 2015 at 12:10 PM, Ed Bartosh ed.bart...@linux.intel.com wrote: +global _BITBAKE_VARS + +if image not in _BITBAKE_VARS: In general, I’d suggest using a cache class/object

[OE-core] [wic][PATCH 04/20] wic: Refactor getting bitbake variables

2015-06-29 Thread Ed Bartosh
Wic gets bitbake variables by parsing output of 'bitbake -e' command. This implementation improves this procedure as it runs 'bitbake -e' only when API is called and does it only once, i.e. in a lazy way. As parsing results are cached 'bitbake -e' is run only once and results are parsed only once

Re: [OE-core] [wic][PATCH 04/20] wic: Refactor getting bitbake variables

2015-06-29 Thread Christopher Larson
On Mon, Jun 29, 2015 at 12:10 PM, Ed Bartosh ed.bart...@linux.intel.com wrote: +global _BITBAKE_VARS + +if image not in _BITBAKE_VARS: In general, I’d suggest using a cache class/object rather than globals, similar to how it’s handled in bb.checksum, or a transparent LRU. Whenever a