Hi, Ross
Please see "[PATCH V3] e2fsprogs: Fix error SRCDIR when using usrmerge
DISTRO_FEATURES".
First, "e2fsprogs:” is added into commit message.
Then, it is fixed with ptest.patch.
Best regards,
Qiu Tingting
________________________________________
发件人: Ross Burton <ross.bur...@arm.com>
发送时间: 2023年5月11日 00:26
收件人: Qiu, Tingting/仇 婷婷
抄送: openembedded-core@lists.openembedded.org
主题: Re: [OE-core] [PATCH V2] Fix error SRCDIR when using usrmerge
DISTRO_FEATURES
First, please use the commit message convention: the shortlog should start with
"e2fsprogs:”.
> In Makefile.in, SRCDIR is set by prefix and libdir.
> @echo "SRCDIR=${prefix}${libdir}/e2fsprogs/ptest/test" >> test_one
> @echo "SRCDIR=${prefix}${libdir}/e2fsprogs/ptest/test" >> test_script
> prefix=/usr
> libdir=/usr/lib (when usrmerge is set)
> solution
> After ptest compiling, check and modify SRCDIR in test_script and test_one.
The reason is correct, but the fix is wrong.
$libdir *always* includes $prefix. This only works in non-usrmerge builds
because for historical reasons we pass ―libdir=$(base_libdir), which sets
libdir=/lib. This happens to work because /usr/lib is actually where the ptest
files are installed, but that is pure coincidence.
Also, this broken part of the Makefile is a rule that *we patch in* (see
ptest.patch), so simply fix that patch instead of working around it in with a
sed.
Ross
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#181223):
https://lists.openembedded.org/g/openembedded-core/message/181223
Mute This Topic: https://lists.openembedded.org/mt/98895832/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
