Re: [oe] [PATCH 2/2] openjdk: add openjdk-config

2019-07-21 Thread Jia, Fang
Hi, Richard Leitner How about this patch ? Could you help to give some suggestions ? Thanks, Fang On 21/02/2019 11:23, Fang Jia wrote: > * Create a new package openjdk-config which used to set variable value > for openjdk. > * The LICENSE file of openjdk-config is COPYING.MIT. > * Allow

Re: [oe] [PATCH 1/2] Revert "base-files: Define JAVA_HOME by default"

2019-05-30 Thread Jia, Fang
Hi Richard How about the test for the two patches ? Is it fine to push to master branch ? Thanks, Fang On 22/02/2019 16:52, Richard Leitner wrote: > Hi, > thanks for the patch. Looks good to me now. > I'll add it to my tests and will give feedback. > > Nonetheless things to improve for your

Re: [oe] [PATCH 1/2] Revert "base-files: Define JAVA_HOME by default"

2019-02-24 Thread Jia, Fang
Hi, Thank you so much. Next time will do as your instruction definitely. Thanks again. Regards, Fang On 22/02/2019 16:52, Richard Leitner wrote: > Hi, > thanks for the patch. Looks good to me now. > I'll add it to my tests and will give feedback. > > Nonetheless things to improve for your next