The function signing_import_pubkey_from_pem is defined twice, one of them should really be named signing_import_pubkey_from_der. Fix this and while at it fix some argument names in the comments above the functions as well.
Reported-by: Miklos Toth <miklos.t...@knorr-bremse.com> Fixes: 4a6ac691f ("add signing.bbclass as infrastructure for build artifact signing") Signed-off-by: Sascha Hauer <s...@pengutronix.de> --- meta-oe/classes/signing.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/meta-oe/classes/signing.bbclass b/meta-oe/classes/signing.bbclass index 553d74e28..ec076d968 100644 --- a/meta-oe/classes/signing.bbclass +++ b/meta-oe/classes/signing.bbclass @@ -142,10 +142,10 @@ signing_import_cert_from_pem() { signing_pkcs11_tool --type cert --write-object /proc/self/fd/0 --label "${role}" } -# signing_import_pubkey_from_der <role> <pem> +# signing_import_pubkey_from_der <role> <der> # # Import a public key from DER file to a role. To be used with SoftHSM. -signing_import_pubkey_from_pem() { +signing_import_pubkey_from_der() { local role="${1}" local der="${2}" @@ -171,7 +171,7 @@ signing_import_pubkey_from_pem() { signing_pkcs11_tool --type pubkey --write-object /proc/self/fd/0 --label "${role}" } -# signing_import_privkey_from_der <role> <pem> +# signing_import_privkey_from_der <role> <der> # # Import a private key from DER file to a role. To be used with SoftHSM. signing_import_privkey_from_der() { -- 2.39.2
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#109008): https://lists.openembedded.org/g/openembedded-devel/message/109008 Mute This Topic: https://lists.openembedded.org/mt/104524966/21656 Group Owner: openembedded-devel+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-