Re: [oe] [PATCH] Fix busybox SUID support

2010-02-26 Thread Bernhard Reutner-Fischer
On Fri, Feb 26, 2010 at 10:42:30PM +, Phil Blundell wrote: >If you're primarily worried about case (a) then building two copies of >the frontend which share a common libbusybox, one setuid and one not, >probably is a reasonable thing to do. However, as you say, busybox does >already have a fa

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-26 Thread Phil Blundell
On Fri, 2010-02-26 at 23:26 +0100, Bernhard Reutner-Fischer wrote: > SUID_DROP applets do just that before the individual applet_main is called, > i.e. drops privs. But whatever.. > If you really think you want to build the thing twice then i'd try > FEATURE_SHARED_BUSYBOX, fyi. > $ size 0_lib/{bus

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-26 Thread Bernhard Reutner-Fischer
On Fri, Feb 26, 2010 at 12:21:56PM -0800, C Michael Sundius wrote: >On Fri, Feb 26, 2010 at 10:20 AM, Koen Kooi wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 26-02-10 16:43, Mike Westerhof wrote: >> > Tom Rini wrote: >> >> I was about to just push this and I noticed that a n

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-26 Thread C Michael Sundius
On Fri, Feb 26, 2010 at 10:20 AM, Koen Kooi wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 26-02-10 16:43, Mike Westerhof wrote: > > Tom Rini wrote: > >> I was about to just push this and I noticed that a number of > >> distributions (SlugOS, Angstrom, Kaelios, micro) currently se

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-26 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26-02-10 16:43, Mike Westerhof wrote: > Tom Rini wrote: >> I was about to just push this and I noticed that a number of >> distributions (SlugOS, Angstrom, Kaelios, micro) currently set >> FEATURE_SUID=y, but it's not actually install SUID. And sin

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-26 Thread Mike Westerhof
Tom Rini wrote: > I was about to just push this and I noticed that a number of > distributions (SlugOS, Angstrom, Kaelios, micro) currently set > FEATURE_SUID=y, but it's not actually install SUID. And since I recall > some way-back-when's of "busybox SUID is dangerous / crap!", I thought > it bes

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-24 Thread Tom Rini
On Wed, 2010-02-24 at 11:19 +0100, Marcin Juszkiewicz wrote: > Dnia wtorek, 23 lutego 2010 o 20:02:56 Tom Rini napisał(a): > > I was about to just push this and I noticed that a number of > > distributions (SlugOS, Angstrom, Kaelios, micro) currently set > > FEATURE_SUID=y, but it's not actually in

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-24 Thread Marcin Juszkiewicz
Dnia wtorek, 23 lutego 2010 o 20:02:56 Tom Rini napisał(a): > I was about to just push this and I noticed that a number of > distributions (SlugOS, Angstrom, Kaelios, micro) currently set > FEATURE_SUID=y, but it's not actually install SUID. And since I recall > some way-back-when's of "busybox SU

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-23 Thread Tom Rini
On Tue, 2010-02-23 at 23:52 +0100, Michael 'Mickey' Lauer wrote: > Ah, finally someone does something about it. Next step would be to dump > tinylogin which is known broken and use busyboxes login utilities > instead. Not wanting to open that can of worms up just yet, yes, this will let distros o

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-23 Thread Michael 'Mickey' Lauer
Ah, finally someone does something about it. Next step would be to dump tinylogin which is known broken and use busyboxes login utilities instead. Great work, Tom. :M: ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org ht

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-23 Thread Phil Blundell
On Tue, 2010-02-23 at 12:02 -0700, Tom Rini wrote: > + if grep -q "CONFIG_FEATURE_SUID=y" ${WORKDIR}/defconfig; then > + install -m 4755 ${S}/busybox ${D}${base_bindir} > + else > + install -m 0755 ${S}/busybox ${D}${base_bindir} > + fi Looks good to me. p.

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-23 Thread Chris Larson
On Tue, Feb 23, 2010 at 1:14 PM, Tom Rini wrote: > On Tue, 2010-02-23 at 11:51 -0800, Khem Raj wrote: > > On Tue, Feb 23, 2010 at 11:02 AM, Tom Rini wrote: > > > I was about to just push this and I noticed that a number of > > > distributions (SlugOS, Angstrom, Kaelios, micro) currently set > >

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-23 Thread Tom Rini
On Tue, 2010-02-23 at 11:51 -0800, Khem Raj wrote: > On Tue, Feb 23, 2010 at 11:02 AM, Tom Rini wrote: > > I was about to just push this and I noticed that a number of > > distributions (SlugOS, Angstrom, Kaelios, micro) currently set > > FEATURE_SUID=y, but it's not actually install SUID. And si

Re: [oe] [PATCH] Fix busybox SUID support

2010-02-23 Thread Khem Raj
On Tue, Feb 23, 2010 at 11:02 AM, Tom Rini wrote: > I was about to just push this and I noticed that a number of > distributions (SlugOS, Angstrom, Kaelios, micro) currently set > FEATURE_SUID=y, but it's not actually install SUID.  And since I recall > some way-back-when's of "busybox SUID is dan

[oe] [PATCH] Fix busybox SUID support

2010-02-23 Thread Tom Rini
I was about to just push this and I noticed that a number of distributions (SlugOS, Angstrom, Kaelios, micro) currently set FEATURE_SUID=y, but it's not actually install SUID. And since I recall some way-back-when's of "busybox SUID is dangerous / crap!", I thought it best to post the patch first