[oe] [PATCH] added a .bb for node.js

2010-08-19 Thread AJ ONeal
--- recipes/node/files/libev-arm-cross.patch | 45 ++ recipes/node/files/node-arm-cross.patch | 31 recipes/node/node_0.1.104.bb | 28 ++ recipes/node/node_v0.1.104.bb| 23 +++ 4 files cha

Re: [oe] [PATCH] added a .bb for node.js

2010-08-18 Thread AJ ONeal
P.S. Is this correct way for me to add a recipe? I didn't notice a particular document for it on the website. AJ ONeal ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/opene

Re: [oe] [PATCH] added a .bb for node.js

2010-08-19 Thread Frans Meulenbroeks
Can't judge the patches, but will give some feedback on one of your recipe versions 2010/8/19 AJ ONeal : > diff --git a/recipes/node/node_0.1.104.bb b/recipes/node/node_0.1.104.bb > new file mode 100644 > index 000..a99eaff > --- /dev/null > +++ b/recipes/node/node_0.1.104.bb > @@ -0,0 +1,28

Re: [oe] [PATCH] added a .bb for node.js

2010-08-19 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 19-08-10 08:07, AJ ONeal wrote: > diff --git a/recipes/node/node_0.1.104.bb b/recipes/node/node_0.1.104.bb > new file mode 100644 > index 000..a99eaff > --- /dev/null > +++ b/recipes/node/node_0.1.104.bb > @@ -0,0 +1,28 @@ > +DESCRIPTION = "nod

Re: [oe] [PATCH] added a .bb for node.js

2010-08-19 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 And the PN should be nodejs On 19-08-10 08:07, AJ ONeal wrote: > --- > recipes/node/files/libev-arm-cross.patch | 45 > ++ > recipes/node/files/node-arm-cross.patch | 31 > recipes/node/node_0.1

Re: [oe] [PATCH] added a .bb for node.js

2010-08-21 Thread AJ ONeal
> > > > +do_install () { > > +install -d ${D}${bindir}/ > > +install -m 0755 ${S}/node ${D}${bindir}/ > > +} > > 'make install' doesn't work? > > No, if I do `make install` it will try to install to the host location. I tried adding ./configure --prefix=${D}, but that ends up installing to `./work/

Re: [oe] [PATCH] added a .bb for node.js

2010-08-22 Thread Frans Meulenbroeks
2010/8/22 AJ ONeal : >> > I don't know how to add the [v2] onto a patch, but I'm going to submit again > with what I have working. > There is an option with git format-patch, which I always forget. The alternative is to edit the file format-patch gave you and change the subeject line before doing

Re: [oe] [PATCH] added a .bb for node.js

2010-08-22 Thread AJ ONeal
I did git commit -m "[v2] blah blah blah" git format-patch -1 git send-email *blah* AJ ONeal On Sun, Aug 22, 2010 at 1:55 AM, Frans Meulenbroeks < fransmeulenbro...@gmail.com> wrote: > 2010/8/22 AJ ONeal : > >> > > > I don't know how to add the [v2] onto a patch, but I'm going to submit > agai

Re: [oe] [PATCH] added a .bb for node.js

2010-08-22 Thread Frans Meulenbroeks
2010/8/23 AJ ONeal : > I did > > git commit -m "[v2] blah blah blah" Not really the desired way as now [v2] becomes part of the commit message. Frans > git format-patch -1 > git send-email *blah* > > AJ ONeal ___ Openembedded-devel mailing list Openem

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 22-08-10 05:04, AJ ONeal wrote: >> >> >>> +do_install () { >>> +install -d ${D}${bindir}/ >>> +install -m 0755 ${S}/node ${D}${bindir}/ >>> +} >> >> 'make install' doesn't work? >> >> > No, if I do `make install` it will try to install to the host l

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread Paul Menzel
Am Donnerstag, den 19.08.2010, 00:15 -0600 schrieb AJ ONeal: > P.S. Is this correct way for me to add a recipe? I didn't notice a > particular document for it on the website. You are also missing a Signed-off-by line. The process is documented in the Wiki [1] including an example. (Left navigatio

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread Paul Menzel
Am Montag, den 23.08.2010, 07:45 +0200 schrieb Frans Meulenbroeks: > 2010/8/23 AJ ONeal : > > I did > > > > git commit -m "[v2] blah blah blah" > > Not really the desired way as now [v2] becomes part of the commit message. Git’s manual pages are very good: `git help format-patch`. `--subject-pref

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread AJ ONeal
> > Please also remember to update the patch queue [2]. > Update it to what? That link you gave me is very unclear It is desirable to update the state of the patch in the patch queue. This > could also be added to the script. The patch is listed as "new". I'd agree with that state. It certainl

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread AJ ONeal
> > You are also missing a Signed-off-by line. > All I do to add that is --signoff, correct? ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread AJ ONeal
> > >> > > No, if I do `make install` it will try to install to the host location. I > > tried adding ./configure --prefix=${D}, but that ends up installing to > > `./work/arm.../usr/bin/bin` > > > > > > I don't know how to add the [v2] onto a patch, but I'm going to submit > again > > with wha

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread Paul Menzel
Am Montag, den 23.08.2010, 15:25 -0600 schrieb AJ ONeal: > > > > Please also remember to update the patch queue [2]. > > > > Update it to what? > > That link you gave me is very unclear > > It is desirable to update the state of the patch in the patch queue. This > > could also be added to the s

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread Paul Menzel
Am Montag, den 23.08.2010, 15:27 -0600 schrieb AJ ONeal: > > > > You are also missing a Signed-off-by line. > > > > All I do to add that is --signoff, correct? No. Please take a look at the link I gave you [1] and the other patches sent to this list. Signed-off-by: Your Name is needed below yo

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread AJ ONeal
> > > > Please also remember to update the patch queue [2]. > > > > > > > Update it to what? > > > > That link you gave me is very unclear > > > > It is desirable to update the state of the patch in the patch queue. This > > > could also be added to the script. > > This sentence addresses the case

Re: [oe] [PATCH] added a .bb for node.js

2010-08-23 Thread J. L.
Great write up AJ once again I wasnt even aware of some of those steps. Probably why a patch I tried to send in a long while ago never showed up again nor did I hear anything. Thanks for taking the time to write out those steps and very clearly, hope to see more on your blog as well about all this.