Re: [oe] [meta-multimedia][PATCH] vlc: Use pkgconfig to find userland graphics libs

2020-04-16 Thread Khem Raj
On Wed, Apr 15, 2020 at 11:21 PM Andreas Müller wrote: > > On Thu, Apr 16, 2020 at 3:46 AM Khem Raj wrote: > My comments: > > * The commit message is a bit misleading. How about: 'vlc: Add > PACKAGECONFIG for mma/x264/fluidsynth'? > * ARM_INSTRUCTION_SET = "arm" is not mentioned. How about an ext

Re: [oe] [meta-multimedia][PATCH] vlc: Use pkgconfig to find userland graphics libs

2020-04-15 Thread Andreas M?ller
On Thu, Apr 16, 2020 at 3:46 AM Khem Raj wrote: My comments: * The commit message is a bit misleading. How about: 'vlc: Add PACKAGECONFIG for mma/x264/fluidsynth'? * ARM_INSTRUCTION_SET = "arm" is not mentioned. How about an extra patch for that? Andreas > > Add mmal, x264, fluidsynth as packag

[oe] [meta-multimedia][PATCH] vlc: Use pkgconfig to find userland graphics libs

2020-04-15 Thread Khem Raj
Add mmal, x264, fluidsynth as packageconfigs so it can be easily enabled/disabled by users Signed-off-by: Khem Raj Cc: Andreas Müller --- ...packageconfig-to-detect-mmal-support.patch | 61 +++ .../recipes-multimedia/vlc/vlc_3.0.9.2.bb | 9 ++- 2 files changed, 67 insertion