Re: [Openerp-community] [Merge] lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:openerp-product-attributes

2013-10-08 Thread Brad Clements
I have two use cases for storing product dimensions: 1. we can recommend to the picker which packaging to choose when fulfilling an order based on the items to be packed.. (aka box packing algorithm) we also estimate packed weights using product weights 2. some products are in a packaging

Re: [Openerp-community] [Merge] lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:openerp-product-attributes

2013-10-08 Thread Eric Caudal
I dont know what kind of product your are dealing with but I would keep it in cm, not m. To be more generic, I would add a UoM (length) to the fields to be able to choose between m., cm and imperial measures if necessary. (How) do you intent to link it with the packaging information? Usually thi

Re: [Openerp-community] [Merge] lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:openerp-product-attributes

2013-10-08 Thread Maxime Chambreuil (http://www.savoirfairelinux.com)
model and views are generally in the module directory, not in sub-directories. IMHO, there is no need for them with such a small module. -- https://code.launchpad.net/~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha/+merge/189956 Your team OpenERP Community is subscribed

Re: [Openerp-community] [Merge] lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:openerp-product-attributes

2013-10-08 Thread Maxime Chambreuil (http://www.savoirfairelinux.com)
Review: Needs Fixing Thanks Humberto. Minor fixes: l30,31: Can you use "from . import" ? l79: Can you fix indentation ? l121: Can you use "from . import" ? l155, datetime, as a standard Python library, should be imported before OpenERP-specific ones. l161,162: Can you fix indentation ? Can yo

[Openerp-community] [Merge] lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:openerp-product-attributes

2013-10-08 Thread hbto [Vauxoo] http://www.vauxoo.com
The proposal to merge lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:openerp-product-attributes has been updated. Description changed to: Hello Comm Guys, We want to submit the following module, product_volumentric_weight, to your review, be aware that we

[Openerp-community] [Merge] lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:openerp-product-attributes

2013-10-08 Thread hbto [Vauxoo] http://www.vauxoo.com
hbto [Vauxoo] http://www.vauxoo.com has proposed merging lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:openerp-product-attributes. Requested reviews: Nhomar - Vauxoo (nhomar) For more details, see: https://code.launchpad.net/~vauxoo/openerp-product-attri

[Openerp-community] [Merge] lp:~openerp-community/stock-logistic-flows/improve-relative-imports into lp:stock-logistic-flows

2013-10-08 Thread noreply
The proposal to merge lp:~openerp-community/stock-logistic-flows/improve-relative-imports into lp:stock-logistic-flows has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~openerp-community/stock-logistic-flows/improve-relative-imports/+merge/1