Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/gscom-70-l10n-vn into lp:openobject-addons/7.0

2013-05-16 Thread Martin Trigaux (OpenERP)
Review: Approve Hello everybody. Thank you Tien for you module and thank you Stefan for your help on this one. The module seems good to me and I can merge it into openerp. The change has been incorporated in openerp 7 addons at revision 9131 (rev-id: m...@openerp.com-20130516084659-cm326nmldkk0

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix-1105067-account_payment_reference_type into lp:openobject-addons

2013-06-07 Thread Martin Trigaux (OpenERP)
Review: Approve Thansk for the patch, these have been merged into addons 7.0 at revision 9207 (revision-id: m...@openerp.com-20130607152644-4om98wo6mu3hesfo) -- https://code.launchpad.net/~openerp-community/openobject-addons/fix-1105067-account_payment_reference_type/+merge/150553 Your team Open

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/gjanssens_l10n_be_nl into lp:openobject-addons

2013-08-21 Thread Martin Trigaux (OpenERP)
Based on this merge proposal, we have merged a fix to the bug lp:1189865. Please refer to it for more detail about how to benefit from it. https://bugs.launchpad.net/openobject-addons/+bug/1189865/comments/6 Thanks for your work Geerts ! -- https://code.launchpad.net/~openerp-community/openobjec

Re: [Openerp-community] [Merge] lp:~openerp-community/openobject-addons/fix-1127198-import-invoice-payment-date into lp:openobject-addons/7.0

2014-01-29 Thread Martin Trigaux (OpenERP)
Review: Approve Hello, Sorry for the long delay on this one and thanks for your work to fix the bug. One small remark: Please do not make write calls in on_change methods. on_change should only be for user interface, no impact on the data (eg: if I close my browser after making the change in e