Review: Resubmit
It seems you are pushing 2 modules here.
l1 === added directory 'base_partner_surname'
l800=== added directory 'crm_lead_formatted_phone'
Wouldn't it be better to make two separate merge proposals?
--
https://code.launchpad.net/~openerp-community/partner-contact-mana
@Joël the module partner_firstname doesn't exist in 6.1 it is only for 7.0 as
it hasn't been backported.
So I think it is ok to accept this one in 6.1 as it prevails on
partner_firstname and is a dependancy for other existing modules in v6.1.
However in 7.0 it would be much better to have only
Review: Needs Fixing
+1
.po files needs to be updated:
./i18n/sl.po:2226:msgid "Create and open the invoice when the user finish a
delivery order"
./i18n/s...@latin.po:2174:msgid "Create and open the invoice when the user
finish a delivery order"
./i18n/fi.po:2191:msgid "Create and open the i
Review: Disapprove
Your MP has conflicts.
And indentation could be improved
Please uses mine:
https://code.launchpad.net/~camptocamp/openobject-addons/7.0-fix-report_webkit-report-view-20120115
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1077238-chirag/+merge/151198
Y
Yannick Vaucher @ Camptocamp has proposed merging
lp:~openerp-community/openerp-swiss-localization/7.0-l10n_ch_payment_slip_add-fr-de-po
into lp:openerp-swiss-localization.
Requested reviews:
Camptocamp (camptocamp)
For more details, see:
https://code.launchpad.net/~openerp-community/openerp
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-fix-1245875-yvr into
lp:openerp-product-attributes.
Requested reviews:
Quentin THEURET @TeMPO Consulting (qt-tempo-consulting)
Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review
Related
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/openerp-product-attributes/7.0-base_custom_attributes-wiz-imp-yvr
into lp:openerp-product-attributes.
Requested reviews:
Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review
For more details, see:
https
Review: Needs Fixing
Need po files
Otherwise lgtm
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/port-add-product_multi_company_7.0-bis-jge/+merge/192872
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes.
___
Romain
I setted
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-add-product_multi_company_new-jge
as Abandonned branch
Can you check and add your fixes again?
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/port-add-product_multi_company_7.0-bis-jge/+me
Just for the records of the MP
On Thu, Oct 31, 2013 at 5:37 PM, Pedro Manuel Baeza Romero <
pedro.ba...@gmail.com> wrote:
> Well, product_price_history then ;)
>
> However, I swear that I have seen this term a lot of times on software.
>
> Regards.
>
>
> 2013/10/31 Ray Carnes
>
>> Also in Austr
Review: Approve code review, no tests
LGTM thanks for the fix
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-1259215-quickcreate-lep/+merge/198619
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes/6.1.
___
The proposal to merge
lp:~camptocamp/openerp-product-attributes/6.1-fix-1259215-quickcreate-lep into
lp:openerp-product-attributes/6.1 has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-1259215-
The proposal to merge
lp:~openerp-community/openerp-swiss-localization/7.0-l10n_ch_payment_slip_add-fr-de-po
into lp:openerp-swiss-localization has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~openerp-community/openerp-swiss-local
I'll improve a bit those french translations
--
https://code.launchpad.net/~openerp-community/openerp-swiss-localization/7.0-l10n_ch_payment_slip_add-fr-de-po/+merge/185981
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openerp-swiss-localization/7.0-l10n_ch_payment_sli
Yannick Vaucher @ Camptocamp has proposed merging
lp:~openerp-community/openerp-swiss-localization/7.0-l10n_ch_payment_slip_add-fr-de-po
into lp:openerp-swiss-localization.
Requested reviews:
Romain Deheele - Camptocamp (romaindeheele): code review, no tests
Joël Grand-Guillaume
Review: Needs Fixing code review, no tests
production_lot_custom_attributes/__openerp__.py <- data keyword
Otherwise LGTM
Thanks!
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-adding-stock_production_lot_custom_attributes-lep/+merge/195950
Your team OpenERP Community
Review: Approve code review, no tests
l.167 little old typo Dynamically instead of Dinamically
learned something about # noqa but I'm unsure I'll use it.
Otherwise LGTM
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-search-all-prodlot-attributes-lep/+merge/199335
Your
The proposal to merge
lp:~camptocamp/openerp-product-attributes/6.1-search-all-prodlot-attributes-lep
into lp:openerp-product-attributes/6.1 has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-search
Of course Leonardo I wasn't saying you should remove it. Maybe a CI server can
be configured to ignore F401 in __init__.py
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-search-all-prodlot-attributes-lep/+merge/199335
Your team OpenERP Community is subscribed to branch
The proposal to merge
lp:~camptocamp/openerp-product-attributes/6.1-search-all-prodlot-attributes-lep
into lp:openerp-product-attributes/6.1 has been updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-search-all-p
The proposal to merge
lp:~camptocamp/openerp-product-attributes/6.1-search-all-prodlot-attributes-lep
into lp:openerp-product-attributes/6.1 has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-search-all-p
The proposal to merge
lp:~agilebg/openerp-product-attributes/adding_product_category_code_7 into
lp:openerp-product-attributes has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~agilebg/openerp-product-attributes/adding_product_category_cod
Review: Approve code review, no tests
LGTM
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-search-no-lot-attributes-lep/+merge/204296
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes/6.1.
_
Review: Approve code review, no tests
LGTM thanks
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-rights-attribute_set-1254609/+merge/210809
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes/6.1.
__
Review: Needs Fixing
Instead of dict.update({split_key: m2m_list})
You can simply write
dict['split_key'] = m2m_list
It might be a bit more readable
--
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss/+merge/201321
Your team OpenERP Community is subscribed t
Review: Approve code review
LGTM
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep/+merge/211798
Your team OpenERP Community is subscribed to branch
lp:openerp-product-attributes/6.1.
___
Mailing list: htt
The proposal to merge
lp:~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep into
lp:openerp-product-attributes/6.1 has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-translate-vie
27 matches
Mail list logo
