The proposal to merge
lp:~openerp-community/openobject-addons/philubert@gmail.com_fix-bad-english
into lp:openobject-addons has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~openerp-community/openobject-addons/philubert@gmail.com_fix-bad-eng
Review: Needs Fixing technical and functional
Hello Philu,
First of all, very well done for your first merge proposal! We seldom see such
a clean first merge proposal, even from our own developers :-)
Good job with the commits, the branch, etc. Nice naming convention for the
branch, didn't even
Thanks for your proposal, we need this kind of improvements.
May I suggest that this kind of proposals be reviewed by the i18n team too?
Lionel Sausin
--
https://code.launchpad.net/~openerp-community/openobject-addons/philubert@gmail.com_fix-bad-english/+merge/49920
Your team OpenERP Community is
Lionel is right, asking the openerp-expert-localization team to review would
make sense also, as soon as it touches wording.
I usually hate to spam the expert mailing-lists by assigning them directly
though, as not all members are technical and able to review merge proposals -
plus launchpad is
Can this be merged ?
Maybe it's better to make the translators re-translate than losing this
contribution.
Lionel.
--
https://code.launchpad.net/~openerp-community/openobject-addons/philubert@gmail.com_fix-bad-english/+merge/49920
Your team OpenERP Community is subscribed to branch
lp:~openerp-c
Review: Approve
Hi philu,
your branch has been merged and i updated your blueprint (not sure it would
have been automatically done by Launchpad).
Thanks for the contribution (and thanks to Olivier who solved all the .po
conflicts in shell command!),
Quentin
--
https://code.launchpad.net/~open
6 matches
Mail list logo
