Niels Huylebroeck has proposed merging
lp:~openerp-community/openobject-server/fix-1094212-multicompany-res_partner
into lp:openobject-server/7.0.
Requested reviews:
OpenERP Core Team (openerp)
Related bugs:
Bug #1094212 in OpenERP Server: "partner search & record rules &
muliticompanies"
The proposal to merge
lp:~openerp-community/openobject-server/fix-1094212-multicompany-res_partner
into lp:openobject-server/7.0 has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~openerp-community/openobject-server/fix-1094212-multicompany-r
The proposal to merge
lp:~openerp-community/openobject-server/fix-1094212-multicompany-res_partner
into lp:openobject-server/7.0 has been updated.
Status: Merged => Needs review
For more details, see:
https://code.launchpad.net/~openerp-community/openobject-server/fix-1094212-multicompany-r
The proposal to merge
lp:~openerp-community/openobject-server/fix-1094212-multicompany-res_partner
into lp:openobject-server/7.0 has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~openerp-community/openobject-server/fix-1094212-multicompany-r
The proposal to merge
lp:~openerp-community/openobject-server/fix-1094212-multicompany-res_partner
into lp:openobject-server/7.0 has been updated.
Status: Merged => Approved
For more details, see:
https://code.launchpad.net/~openerp-community/openobject-server/fix-1094212-multicompany-res_p
The proposal to merge
lp:~openerp-community/openobject-server/fix-1094212-multicompany-res_partner
into lp:openobject-server/7.0 has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~openerp-community/openobject-server/fix-1094212-multicompany-res_p
Review: Needs Fixing
I guess a clean solution would be to completly replace the cr.execute by a
self.search, instead of doing two searches. It's also important for performance
issues.
--
https://code.launchpad.net/~openerp-community/openobject-server/fix-1094212-multicompany-res_partner/+merge/
I agree but the current state of affair was that it didn't work for
multicompany setup AND there were already 2 search queries most of the time
anyway (plenty of arguments being passed).
In fact by removing that if statement you could reason I saved time on the
python side, because that check was
A solution to give an order of magnitude performance speed would be:
a) create a "name_with_company" stored function field on res_partner to avoid
the join;
b) create an expression index[1] on "lower(name_with_company)";
c) change the query to use ('lower(%s) like lower(name_with_company)') for
This MP is set to merged but it is not really.
http://bazaar.launchpad.net/~openerp/openobject-server/7.0/revision/4786
--
https://code.launchpad.net/~openerp-community/openobject-server/fix-1094212-multicompany-res_partner/+merge/141936
Your team OpenERP Community is subscribed to branch
lp:~o
Pointing to revision 4786 because that is what the MP said that it was merged
at before I changed its status. Looks like someone merged the branch but then
made manual changes. The effect is that if you try to merge the branch now, bzr
says 'Nothing to do'. But the faulty line is still there:
h
Yes, it seem Fabien himself has merged this branch but forgot to revert it
before working on something else (the document management apparently)
This branch from Fabien was then merged by Thibault into the v7.0 branch.
http://imgur.com/kOGTTIM
--
https://code.launchpad.net/~openerp-community/op
Re-pushed with a new unique id to allow real merging this time.
--
https://code.launchpad.net/~openerp-community/openobject-server/fix-1094212-multicompany-res_partner/+merge/141936
Your team OpenERP Community is subscribed to branch
lp:~openerp-community/openobject-server/fix-1094212-multicompan
13 matches
Mail list logo
