Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/lp754339 into lp:ocb-addons

2013-10-06 Thread Ronald Portier (Therp)
Thanks also from my side! When I compare this merge proposal with the original one for 6.1 therp backports (which became ocb 6.1), I note a few things. (compare: https://code.launchpad.net/~therp-nl/therp-backports/addons-6.1-lp754339_pricelist_on_invoice_line/+merge/157829) 1. There is no lay

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/lp754339 into lp:ocb-addons

2013-10-06 Thread Stefan Rijnhart (Therp)
Review: Needs Fixing Thanks for taking the effort of forward porting (and improving) this old fix for 6.1 to 7.0! I sure hope this important fix lands in upstream one day. l.66 seems wrong. I think in 7.0 you need to append it to the invoice line's name field like the original code does in l.42