Sorry for the resubmit. I am still not familiar with the process.
--
https://code.launchpad.net/~lin-yu/purchase-wkfl/add_product_supplier_info/+merge/185197
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-review
Code fixed. Proposal resubmitted.
On 11/11/2013 09:32 PM, Guewen Baconnier @ Camptocamp wrote:
> Review: Needs Fixing
>
> Hi,
>
> l.127 the context is not propagated to the browse() method
--
LIN Yu
LIN Yu
/Project Manager/
--
*Elico Corporation, Shanghai
/OpenERP Premium Certified Training Pa
LIN Yu has proposed merging lp:~lin-yu/purchase-wkfl/add_product_supplier_info
into lp:purchase-wkfl.
Requested reviews:
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c): code review, no tests
LIN Yu (lin-yu)
Pedro Manuel Baeza (pedro.baeza): test
Guewen Baconnier @ Camptocamp (gba
Hi, El Hadji, thank you very much for these two useful modules, but can you
please add each of them on separate MPs to make easier the reviewing process?
Let me know if you need help on something.
Regards.
--
https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/6.1-fix-hr-skill-demo-
My branch only contains my module, it's not a "full" branch. So a bzr replay
should work, but a merge doesn't work. If it's a problem, I will prepare a
"full" branch of account-financial-tools with my module inside, but i'm not
sure if I will be able to push it in the same branch (if I can't, it
Review: Disapprove
Hello, just created a new MP
https://code.launchpad.net/~agilebg/account-invoicing/7.0-add_account_invoice_template/+merge/194733
--
https://code.launchpad.net/~bruno-bottacini/account-financial-tools/7.0-add_account_invoice_template/+merge/170010
Your team OpenERP Community R
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/account-invoicing/7.0-add_account_invoice_template into
lp:account-invoicing.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/account-invoicing/7.0-add_acco
Review: Needs Information
l 63: "You must have lpr installed for this module to work as-is" is it still
true?
--
https://code.launchpad.net/~camptocamp/report-print-send/7.0-base_report_to_printer_port-imp-yvr/+merge/194710
Your team Report Printing and Sending Core Editors is requested to revie
The proposal to merge
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-dutch-xlats
into lp:account-financial-report has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-accoun
Review: Approve
Thanks
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-dutch-xlats/+merge/193704
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list: https://launchpad.net/~openerp-co
Review: Approve
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/add-stock_split_picking-jge/+merge/193605
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Hello, check out this doc : http://t.co/SvNYavKAhR
There is a section where I explain the clearance date principle (page 11)
--
https://code.launchpad.net/~erwin-bassolutions/account-financial-report/7.0-report-webkit-afr-dutch-translations/+merge/193252
Your team Account Report Core Editors is s
Review: Approve
LGTM
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-sale_exception_nostock_by_line-jge/+merge/193597
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-revi
The proposal to merge
lp:~pedro.baeza/account-consolidation/7.0-translation-template-files into
lp:account-consolidation/7.0 has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~pedro.baeza/account-consolidation/7.0-translation-template-files/+
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/report-print-send/7.0-base_report_to_printer_port-imp-yvr into
lp:report-print-send.
Requested reviews:
Lorenzo Battistini - Agile BG (elbati)
Andrew (aes)
Yannick Vaucher @ Camptocamp (yvaucher-c2c)
Report Printing and Sen
Review: Approve
Approve.
Note: the module's name was purchase_to_sale in older versions which was
difficult to identify as dropshipping.
--
https://code.launchpad.net/~camptocamp/sale-wkfl/add-sale_dropshipping-jge/+merge/193601
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
Review: Approve
I approve for the move
--
https://code.launchpad.net/~openerp-community-reviewer/sale-wkfl/move_sale_exception_module_from_e-commerce-addons-jge/+merge/193567
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:~openerp-community-reviewer/sale-wkfl/move_sal
Thanks, can you merge it? Maybe you also have the answer? I don't understad the
concept of "Clearance date". If i understand i can translate. Thanks
--
https://code.launchpad.net/~erwin-bassolutions/account-financial-report/7.0-report-webkit-afr-dutch-translations/+merge/193252
Your team Account
Review: Approve
I approve for the move.
--
https://code.launchpad.net/~openerp-community-reviewer/e-commerce-addons/move_sale_exception_to_sale_wkfl_branches-jge/+merge/193570
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:~openerp-community-reviewer/e-commerce-addon
Review: Disapprove obsolete
Let's making thing clearer and gather all changes in one MP.
All changes from AES of the current MP, are included in
lp:~camptocamp/report-print-send/7.0-base_report_to_printer_port-imp-yvr (with
credits)
This MP is now obsolete. Please Refuse this MP and review th
Review: Approve
I won't block the merge for 1 untranslated term, so I approve. But I won't
merge until you ask.
--
https://code.launchpad.net/~erwin-bassolutions/account-financial-report/7.0-report-webkit-afr-dutch-translations/+merge/193252
Your team Account Report Core Editors is subscribed to
Review: Resubmit
Fixes of the current MP were made to fix
lp:~aes/report-print-send/base_report_to_printer
Thus if this one is not merged in aes MP, I think we can bypass aes MP as it
includes its changes.
I'll resubmit it.
--
https://code.launchpad.net/~camptocamp/report-print-send/7.0-base_
Review: Approve code review
LGTM
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_historical_margin-yvr/+merge/191660
Your team Margin Analysis Core Editors is subscribed to branch
lp:margin-analysis.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Review: Approve
--
https://code.launchpad.net/~pedro.baeza/account-consolidation/7.0-translation-template-files/+merge/191949
Your team Account Core Editors is subscribed to branch
lp:account-consolidation/7.0.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : o
Review: Approve
--
https://code.launchpad.net/~therp-nl/web-addons/6.1-icons/+merge/191598
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.ne
The proposal to merge
lp:~pedro.baeza/account-financial-tools/7.0-translation-template-files into
lp:account-financial-tools has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-translation-template-files
Review: Approve
--
https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-translation-template-files/+merge/191849
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewe
The proposal to merge
lp:~pedro.baeza/account-closing/7.0-translation-template-files into
lp:account-closing has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~pedro.baeza/account-closing/7.0-translation-template-files/+merge/191948
--
https
The proposal to merge lp:~therp-nl/web-addons/6.1-icons into lp:web-addons/6.1
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~therp-nl/web-addons/6.1-icons/+merge/191598
--
https://code.launchpad.net/~therp-nl/web-addons/6.1-icons/+merge/
Review: Approve
--
https://code.launchpad.net/~pedro.baeza/account-closing/7.0-translation-template-files/+merge/191948
Your team Account Core Editors is subscribed to branch lp:account-closing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-
The proposal to merge lp:~therp-nl/web-addons/lp1242637 into lp:web-addons has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~therp-nl/web-addons/lp1242637/+merge/191969
--
https://code.launchpad.net/~therp-nl/web-addons/lp1242637/+merge/1919
Review: Approve
--
https://code.launchpad.net/~therp-nl/web-addons/web_export_view_translations_de_nl/+merge/191975
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-review
The proposal to merge
lp:~therp-nl/web-addons/web_export_view_translations_de_nl into lp:web-addons
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~therp-nl/web-addons/web_export_view_translations_de_nl/+merge/191975
--
https://code.launc
The proposal to merge
lp:~pedro.baeza/account-invoice-report/invoice_webkit_description into
lp:account-invoice-report has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~pedro.baeza/account-invoice-report/invoice_webkit_description/+merge/191
Review: Approve
Thanks
--
https://code.launchpad.net/~pedro.baeza/account-invoice-report/invoice_webkit_description/+merge/191406
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewe
Review: Approve code review
LGTM
Pedro, is it ok for you now?
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_cost_incl_bom-yvr/+merge/190348
Your team Margin Analysis Core Editors is subscribed to branch
lp:margin-analysis.
--
Mailing list: https://launchpad.net/~o
The proposal to merge
lp:~camptocamp/margin-analysis/7.0-port-product_standard_margin-yvr into
lp:margin-analysis has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_standard_margin-yvr/+merge/190349
Review: Approve
--
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-port-product_standard_margin-yvr/+merge/190349
Your team Margin Analysis Core Editors is subscribed to branch
lp:margin-analysis.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : open
Review: Approve code review
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1234678-return-product-backorder-false/+merge/189069
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-revie
** Changed in: ocb-addons/7.0
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1104559
Title:
[Trunk/7.0]
Review: Approve
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1137541-partial-picking-move-destination/+merge/189072
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post t
Review: Approve
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1188629-price-surchage-uom/+merge/189106
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : opener
The proposal to merge
lp:~sebastien.beau/stock-logistic-flows/stock-logistic-flows-61-backport-stock_picking_invoice_link
into lp:stock-logistic-flows has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~sebastien.beau/stock-logistic-flows/stoc
Review: Approve
--
https://code.launchpad.net/~therp-nl/server-env-tools/7.0_email_template_template_rst/+merge/189108
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
The proposal to merge
lp:~therp-nl/server-env-tools/7.0_email_template_template_rst into
lp:server-env-tools has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~therp-nl/server-env-tools/7.0_email_template_template_rst/+merge/189108
--
https:
The proposal to merge
lp:~therp-nl/partner-contact-management/partner_firstname_dutch into
lp:partner-contact-management has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~therp-nl/partner-contact-management/partner_firstname_dutch/+merge/189
The proposal to merge lp:~therp-nl/ocb-addons/lp1104559 into lp:ocb-addons has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~therp-nl/ocb-addons/lp1104559/+merge/188817
--
https://code.launchpad.net/~therp-nl/ocb-addons/lp1104559/+merge/1888
Review: Needs Information
Hello,
I cannot print the report, I get the folowing error...
Traceback (most recent call last):
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/service/web_services.py",
line 727, in go
(result, format) = obj.create(cr, uid, ids, datas, contex
Review: Approve code review
--
https://code.launchpad.net/~therp-nl/ocb-addons/lp1104559/+merge/188817
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@
> I have made some fixes and improvements in : lp:~camptocamp/report-print-
> send/7.0-base_report_to_printer_port-imp-yvr
Is this MP obsoleted by
lp:~camptocamp/report-print-send/7.0-base_report_to_printer_port-imp-yvr ?
--
https://code.launchpad.net/~aes/report-print-send/base_report_to_printe
Is this MP obsoleted by
https://code.launchpad.net/~camptocamp/report-print-send/7.0-base_report_to_printer_port-imp-yvr/+merge/188789
?
--
https://code.launchpad.net/~aes/report-print-send/base_report_to_printer/+merge/153491
Your team Report Printing and Sending Core Editors is subscribed to b
> Up
>
> Could this one be merged with lp:~aes/report-print-send/base_report_to_printer
Which one should be merged where?
That's a bit confuse for me. The prerequisite is 'Needs fixing'. Can we cancel
this MP
https://code.launchpad.net/~aes/report-print-send/base_report_to_printer/+merge/15349
Review: Approve code review
As it is just a split of a python module, I'll grant it as: ok for the merge.
--
https://code.launchpad.net/~camptocamp/report-print-send/7.0-base_report_to_printer_port-imp-yvr-2/+merge/188825
Your team Report Printing and Sending Core Editors is subscribed to branch
l.137 An uid is missing:
user = self.pool.get('res.users').browse(cr, uid, context)
=>
user = self.pool.get('res.users').browse(cr, uid, uid, context=context)
In __openerp__.py, needs to add:
'external_dependencies': {
'python': ['cups'],
},
Once that fixed, it will be
The proposal to merge
lp:~therp-nl/partner-contact-management/no_split_for_companies into
lp:partner-contact-management has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~therp-nl/partner-contact-management/no_split_for_companies/+merge/18855
Review: Approve code review
Agree.
--
https://code.launchpad.net/~therp-nl/partner-contact-management/no_split_for_companies/+merge/188556
Your team Partner and Contact Core Editors is subscribed to branch
lp:partner-contact-management.
--
Mailing list: https://launchpad.net/~openerp-community
Review: Approve
LGTM
--
https://code.launchpad.net/~pedro.baeza/ocb-addons/account_invoice-reconciliation-fixes/+merge/188328
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : o
Review: Approve
--
https://code.launchpad.net/~camptocamp/sale-reports/7.0-sync-webkit-reports-20130926/+merge/187702
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : opene
The proposal to merge
lp:~savoirfairelinux-openerp/lp-community-utils/fix-pep8-and-add-new-projects
into lp:lp-community-utils has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/fix-pep8-and-add-new
Review: Resubmit
Hi Alexis, I tried to merge your branch in lp:account-financial-tools/7.0 but I
get:
bzr: ERROR: Branches have no common ancestor, and no merge base revision
was specified.
Can you check?
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-fiscal-posit
Review: Approve
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-fiscal-position-check-vat/+merge/186515
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewe
The proposal to merge lp:~bcim/account-financial-tools/saas1-fix_imports-jba
into lp:account-financial-tools has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~bcim/account-financial-tools/saas1-fix_imports-jba/+merge/186014
--
https://code.l
Review: Approve code review
Thanks Alexis for taking up the changes!
Finally: LGTM :-)
Lorenzo, does your comment count as an 'Approved'?
--
https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992
Your team Account Core Editors is subscribed to branch lp:accoun
Romain, what is the state of this MP?
Given the discussions, I put this MP as 'work in progress'. Please set it back
to 'Needs review' once ready.
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-lp-1204832-RDE/+merge/185545
Your team OpenERP Community Backports Team is subscribed to
The proposal to merge lp:~camptocamp/ocb-addons/7.0-fix-lp-1204832-RDE into
lp:ocb-addons has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-lp-1204832-RDE/+merge/185545
--
https://code.launchpad.net/~c
Given the discussions, I put this MP as 'work in progress'. Please set it back
to 'Needs review' once ready.
--
https://code.launchpad.net/~0k.io/ocb-server/usability-and-fix-on-res-partner-1/+merge/185339
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-server.
--
Mai
The proposal to merge lp:~0k.io/ocb-server/usability-and-fix-on-res-partner-1
into lp:ocb-server has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~0k.io/ocb-server/usability-and-fix-on-res-partner-1/+merge/185339
--
https://code.la
Review: Needs Fixing
Same comments than:
https://code.launchpad.net/~florian-dacosta/ocb-addons/7.0_purchase_line_partner_fix/+merge/185331/comments/449347
:
l.11 The context must be propagated in the read.
l.24 No mutable in keyword argument: replace "c={}" by "c=None".
l.23-24 Indentation is
I agree with you Pedro on the principle but in real life, I face unfortunately
2 problems :
1 - I am dependant to the localisation module update (as you said)
2 - I have to update more or less the whole addons (& other branches) code of
my customers which is maybe a bit heavy to handle sometime
Review: Needs Fixing
Hi,
l.11 The context must be propagated in the read.
l.24 No mutable in keyword argument: replace "c={}" by "c=None".
l.23-24 Indentation is dubious, see
http://www.python.org/dev/peps/pep-0008/#indentation
--
https://code.launchpad.net/~florian-dacosta/ocb-addons/7.0_purc
The proposal to merge lp:~agilebg/stock-logistic-report/adding_delivery_slip_7
into lp:stock-logistic-report has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~agilebg/stock-logistic-report/adding_delivery_slip_7/+merge/185048
--
https://code
Review: Approve code review
LGTM
Thanks
--
https://code.launchpad.net/~agilebg/stock-logistic-report/adding_delivery_slip_7/+merge/185048
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-report.
--
Mailing list: https://launchpad.net/~openerp-community-revie
Review: Needs Fixing
Hi,
l.127 the context is not propagated to the browse() method
--
https://code.launchpad.net/~lin-yu/purchase-wkfl/add_product_supplier_info/+merge/185197
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~open
LGTML, no test
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-literal_eval-domain/+merge/188573
Your team Product Core Editors is requested to review the proposed merge of
lp:~camptocamp/openerp-product-attributes/7.0-literal_eval-domain into
lp:openerp-product-attribut
Your MP is linked with a bug having a 'Fix released' status. Is is another bug
or was the bug not fixed?
The comment on line 22 is not inline with the states at line 32.
--
https://code.launchpad.net/~camptocamp/account-financial-tools/draft_move_vre_resubmit/+merge/194673
Your team OpenERP Comm
The proposal to merge
lp:~agilebg/account-financial-tools/adding_account_deferred_charge_7 into
lp:account-financial-tools has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~agilebg/account-financial-tools/adding_account_deferred_charge_7/+
Sorry for this long wait
I have done a resubmit with a brand new branch.
Vincent
--
https://code.launchpad.net/~camptocamp/account-financial-tools/draft_move_vre_resubmit/+merge/194673
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mail
Vincent Renaville@camptocamp has proposed merging
lp:~camptocamp/account-financial-tools/draft_move_vre_resubmit into
lp:account-financial-tools.
Requested reviews:
Guewen Baconnier @ Camptocamp (gbaconnier-c2c)
For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-t
On 11/11/2013 11:33 AM, Guewen Baconnier @ Camptocamp wrote:
>> Hello Nicolas, thanks for your review.
>> I agree the 'deferred charge' requirement can be covered by cutoff modules
> So what are you going to do with this MP?
This MP should be set as rejected, but I can't set that status.
--
htt
Yes, I'll get back to it as soon as I can; just been too busy lately.
--
https://code.launchpad.net/~dreis-pt/ocb-addons/7.0-bug1079476-dr/+merge/186394
Your team OpenERP Community Backports Team is requested to review the proposed
merge of lp:~dreis-pt/ocb-addons/7.0-bug1079476-dr into lp:ocb-ad
> Hello Nicolas, thanks for your review.
> I agree the 'deferred charge' requirement can be covered by cutoff modules
So what are you going to do with this MP?
--
https://code.launchpad.net/~agilebg/account-financial-tools/adding_account_deferred_charge_7/+merge/185171
Your team OpenERP Community
Review: Needs Fixing code review
l. 88: replace "c={}" by "c=None"
l.143: context is not propagated
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-budget-migr-add-allocation-nbi/+merge/184077
Your team Account Core Editors is subscribed to branch
lp:~camptocamp/account-budgetin
Review: Needs Fixing code review
Hi,
Can you respect the pep8 please? You can use flake8 to check that.
at l.18: the "context" argument should have a mutable type as default value,
you have to replace "context={}" by "context=None".
at l.51: 'method=True' has been deprecated in OpenERP 7.0.
p
Review: Approve code review
Notes on this module:
- the license is still GPL, should be moved to AGPL.
- A cleaning should be done (propagation of context is missing, weird
constructions or idioms).
That's not the matter of this MP though, so I approve.
Thanks.
--
https://code.launchpad.net
Review: Needs Information
I don't understand, the description of the change states 'please fix this bug,
thanks". Is it fixed?
--
https://code.launchpad.net/~jeffery9/stock-logistic-tracking/stock-logistic-tracking/+merge/180994
Your team Stock and Logistic Core Editors is subscribed to branch
Review: Approve
OK, please continue then with the current name.
Regards.
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-budget-migr/+merge/162802
Your team Account Core Editors is subscribed to branch lp:account-budgeting.
--
Mailing list: https://launchpad.net/~openerp-commun
Review: Resubmit
There are still conflicts. Can you check ?
--
https://code.launchpad.net/~laetitia-gangloff/hr-timesheet/hr_attendance_analysis_externalise_contract_calendar/+merge/182565
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet/7.0.
--
Mailing l
> Dear Joël,
> Thanks for your reply.
> I will work on it and make it more clear.
>
> BR,
Hi,
So I change your proposal to 'work in progress'. Please set it back to 'Needs
review' when you are done.
--
https://code.launchpad.net/~lin-yu/purchase-wkfl/add_purchase_po_price/+merge/180792
Your t
The proposal to merge lp:~lin-yu/purchase-wkfl/add_purchase_po_price into
lp:purchase-wkfl has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~lin-yu/purchase-wkfl/add_purchase_po_price/+merge/180792
--
https://code.launchpad.net/~li
Review: Approve code review
Thanks! What happens when you run this branch on standard OpenERP branches?
Maybe add a disclaimer about this in the module description.
Otherwise approved. I noticed that some column names changed in hr_holiday_rel
but this should be alright as it concerns a transie
Review: Approve code, functionnal
About module name, I don't think it is that important to change it.
The most important things are module title and description. What is important
with module name is to have it uniq. And as far as I know there are no other
"budget" module in community nor in of
Hi Jean, I didn't checked if you have been able to create separate proposals
for each module, if yes, can you close this MP?
--
https://code.launchpad.net/~jean-lelievre/purchase-wkfl/new_modules_purchase/+merge/180463
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.
--
Review: Abstain
> I see. In that case I am thinking that maybe we should not include fixes that
> will only lead to customers facing a regression after an upgrade. I do not
> want to block this proposal if other people disagree, so I will 'abstain' for
> now.
Agree with your point.
--
https://co
> The _get_rows_account and _get_rows_analytic methods take a 'company_id'
> argument, this one is passed to the query, but this one does not use it, so
> the lines are not multi-company aware.
> I'm not sure if it should be done directly in the query or if you should leave
> the query as is and do
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into
lp:hr-timesheet/7.0.
Requested reviews:
Nicolas Bessi - Camptocamp (nbessi-c2c): credentials
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)
Alexandre Fayolle - c
Patch was accepted in OCB addons.
Ready for review !
--
https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:hr-timesheet/7.0.
--
Mailing list: https://launchpad.net/~openerp-
> Hi, Guewen,
>
> You cannot compare a "first class" module, account or mrp, with this
> functionality addon to the account area. Even the mentioned module, analytic,
> I consider it as a past error that OpenERP cannot change because of
> compatibility, but you can see others modules with the name
I replicated the changes of the original MP.
--
https://code.launchpad.net/~camptocamp/ocb-addons/lp1191036/+merge/171050
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-
@guewen with all respect, that is a dangerous review. Of course the syntactic
aspect of the changed is trivial and can be approved but now someone could come
along and blindly merge the proposal based on the two approvals without seeing
your disclaimer. Would you please consider to review with '
Review: Needs Fixing code review
> Thanks Guewen for the review.
>
> The message is meant to be customized. If you have a way to set it right,
> please share it.
Ok. I don't think we can get it right (on 7.0 we can set web.base.url in
ir_config_parameter, I don't think that already existed in 6
1 - 100 of 106 matches
Mail list logo
