Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/port-add-product_multi_company_7.0-bis-jge into lp:margin-analysis

Review: Approve code review, test -- https://code.launchpad.net/~camptocamp/margin-analysis/port-add-product_multi_company_7.0-bis-jge/+merge/197679 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list: https://launchpad.net/~openerp-community-rev

Re: [Openerp-community-reviewer] Automatic review bot

On 12/04/2013 11:51 PM, Maxime Chambreuil wrote: Hello everyone, We recently discovered that C2C is running an automatic review bot: https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749/comments/458245 So we were wondering if this bot cou

Re: [Openerp-community-reviewer] Automatic review bot

Hello, In fact I'm the human bot :P (I have just some firefox snippets for common errors found in MP) But I think it is a good idea to automate basic styling, and consistency check. Alexandre as an author of pylint will probably be of a great help on this blueprint and has started (I do not kn

[Openerp-community-reviewer] [Bug 1257299] Re: chances: Receive Messages by Email - reported incorrectly

** Also affects: ocb-addons Importance: Undecided Status: New ** Changed in: ocb-addons Importance: Undecided => Medium ** Changed in: ocb-addons Assignee: (unassigned) => OpenERP Community Backports Team (ocb) ** Changed in: ocb-addons Status: New => Confirmed -- You

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/port-add-product_multi_company_7.0-bis-jge into lp:margin-analysis

Review: Approve code review and test OK, I approve again because the functionality hasn't changed. Regards. -- https://code.launchpad.net/~camptocamp/margin-analysis/port-add-product_multi_company_7.0-bis-jge/+merge/197679 Your team Margin Analysis Core Editors is subscribed to branch lp:margin

[Openerp-community-reviewer] Automatic review bot

Hello everyone, We recently discovered that C2C is running an automatic review bot: https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749/comments/458245 So we were wondering if this bot could be shared in lp-community-utils. We would l

Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1-sort-events-mat into lp:ocb-addons/6.1

> You might want to remove the trailing white space introduced on: l.17,26,53,54 Thanks for finding. Hope I removed them all. Please check again. Thanks -- https://code.launchpad.net/~hirt/ocb-addons/6.1-sort-events-mat/+merge/196434 Your team OpenERP Community Backports Team is subscribed to bran

Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1-sort-events-mat into lp:ocb-addons/6.1

You might want to remove the trailing white space introduced on: l.17,26,53,54 -- https://code.launchpad.net/~hirt/ocb-addons/6.1-sort-events-mat/+merge/196434 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-c

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows

Review: Needs Fixing no test, code review Please use: from openerp.osv import orm, fields and instanciate the classes with: class x_y_z(orm.Model): class a_b_c(orm.TransientModel): The other form is deprecated. In osv.py: " # deprecated - for backward compatibility. osv = Model osv_memory = Tra

Re: [Openerp-community-reviewer] OpenERP

Hi, Maxime, you have anticipated me, hehe. Of course, I approve its inclusion. I also want to propose Yann Papouin , with these credentials: https://code.launchpad.net/~yann-papouin/+registeredbranches https://code.launchpad.net/~yann-papouin/+activereviews

Re: [Openerp-community-reviewer] OpenERP

Hello everyone, I would like to propose Sandy Carter as a new member of the OpenERP Community Reviewer team. You will find its Launchpad profile here: https://launchpad.net/~sandy-carter some of his contributions: https://code.launchpad.net/~sandy-carter/+registeredbranches https://launchpad.n

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/account-financial-tools/7.0-bug-1255543-chart-update-records-wrong-dict into lp:account-financial-tools

I proceed with the merge, having two reviews and one functional, because I have readed that this fix is needed for some tasks now on l10n_fr. Regards. -- https://code.launchpad.net/~yann-papouin/account-financial-tools/7.0-bug-1255543-chart-update-records-wrong-dict/+merge/196912 Your team Open

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/account-financial-tools/7.0-bug-1255543-chart-update-records-wrong-dict into lp:account-financial-tools

The proposal to merge lp:~yann-papouin/account-financial-tools/7.0-bug-1255543-chart-update-records-wrong-dict into lp:account-financial-tools has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~yann-papouin/account-financial-tools/7.0-bug-125

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict into lp:account-financial-tools/6.1

The proposal to merge lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict into lp:account-financial-tools/6.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~yann-papouin/account-financial-tools/6.1-bug

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict into lp:account-financial-tools/6.1

I proceed with the merge, having two functional reviews and this fix is needed for some tasks now on l10n_fr, as I have readed. Regards. -- https://code.launchpad.net/~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict/+merge/196911 Your team Account Core Editor

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing

Review: Approve LGTM, no tests -- https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 Your team Account Core Editors is subscribed to branch lp:account-closing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-communi

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/account-financial-tools/7.0-bug-1255543-chart-update-records-wrong-dict into lp:account-financial-tools

Review: Approve code review and test Hello Yann: Good job. Thank -- https://code.launchpad.net/~yann-papouin/account-financial-tools/7.0-bug-1255543-chart-update-records-wrong-dict/+merge/196912 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools.

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict into lp:account-financial-tools/6.1

Review: Approve code review and test Hello Yann: Good job. Thank -- https://code.launchpad.net/~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict/+merge/196911 Your team Account Core Editors is subscribed to branch lp:account-financial-tools/6.1. -- Mailing

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows

Review: Approve code review, no test LGTM, as I said in another MP, 2 and 3 are not a reason to block the MP. -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749 Your team Stock and Logistic Core Editors is requested to review the propo

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep into lp:openerp-manufacturing/6.1

Review: Approve code review, no test 1. Technically, you are correct, while I don't personally like that style, as most __openerp__.py files won't start the item list on the same line as opening brace, I don't see this as reason to block the MP. LGTM -- https://code.launchpad.net/~camptocamp/o

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:account-invoice-report

Hello, just a word, to say that I fully agree with all Alexis comments: 1) to 4). I don't remember where it was, but I believe there was a previous merge proposal (that has probably been dropped in favor of this one), where I believe Pedro Baeza was commenting the same that trying to avoid repor

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/translation_v7_sale_order_webkit into lp:sale-reports

Review: Needs Information Looking at the french translation, it all looks good except for UoM, should it be UdM? UoM = Unit of Measure UdM = Unité de mesure -- https://code.launchpad.net/~camptocamp/sale-reports/translation_v7_sale_order_webkit/+merge/196906 Your team OpenERP Community Reviewer/

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/invoice-view-fix-mdh into lp:account-financial-tools

Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/account-financial-tools/invoice-view-fix-mdh/+merge/196582 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-com

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add-sale_stock_global_delivery_lead_time-afe into lp:sale-wkfl

Review: Needs Fixing code review __openerp__.py: pep8 issue: space before colon on 54,55,56,60,61,62,63,64,65,67,68 sale_stock: unused imports: l.97,101 timedelta, DEFAULT_SERVER_DATE_FORMAT, DATETIME_FORMATS_MAP, float_compare pep8: l.112 trailing white spaces pep8: l.115 need two spaces before

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe into lp:sale-wkfl

Review: Needs Fixing code review __init__.py: * vim comment should be the last line __openerp__.py: * pep8 issues: l.55,56,57,61,62,63,64,65,66,68,69 whitespace before colon invoice.py: * pep8: l.196 should be two lines before class invoice_view.xml: you might want to remove your commented out

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1104766-ignore-canceled-moves into lp:ocb-addons/6.1

Yann Papouin has proposed merging lp:~yann-papouin/ocb-addons/6.1-bug-1104766-ignore-canceled-moves into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1104766 in OpenERP Community Backports (Addons): "Product Return Canceled" https://bugs.

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows

1. fixed 2. Asked the community list 3. 6.1 style, I think Thanks! -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~camptocamp/stock-logis

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add_stock_picking_priority-afe into lp:stock-logistic-flows/7.0

Review: Needs Fixing code review __openerp__: pep8 issues * spaces before the colon on l.56,57,58,59,66,67,68,71 picking_priority.py: * l.123 you're not checking if ids is an int or a list, this could lead to a problem with search and an error on l.137 -- https://code.launchpad.net/~camptocam

[Openerp-community-reviewer] [Bug 1104766] Re: Product Return Canceled

** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backpor

Re: [Openerp-community-reviewer] [Merge] lp:~openerp-dev/openobject-addons/7.0-base-contact-xal into lp:openobject-addons/7.0

I have to admit that my knowledge of the OpenERP module landscape is not vast. We currently have a 6.1 installation using base_contact that we want to migrate from to 7.0. I am now wondering if this module will take care of the migration as well, I did not see any migration code in the diffs. I

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows

Review: Needs Fixing code review l.213 spelling mistake Dinamically -> Dynamically __openerp__.py is a dictionary, use pep8 style: 4 space indentation and move 'name' to its own line l.126-137 Would be nicer if these were imported from openerp: openerp.osv, openerp.tools.translate -- https://c

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:account-invoice-report

@Lorenzo I forgot to say that I am ready to do the work to have the changes that I suggest if you agree with the changes. I could do that in another branch and then propose to merge it. -- https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:account-invoice-report

Review: Needs Information Dear Lorenzo, Thank you for this very interesting module. I was looking for such a module for a new development I want to do to replace my "fleet_maintenance" module (lp:fleet-maintenance). Here are my remarks, from the most important to the least important : 1) the

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep into lp:openerp-manufacturing/6.1

Sandy, thanks for your review. 1. I think that case falls under the "Aligned with opening delimiter" rule, which should be fine. The pep8 tool indeed likes it. 2. fixed. 3. I think this is 7.0 style, while all but one of the 6.1 standard modules do "from osv". Best -- https://code.launchpad.

[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/6.1-fix-935564 into lp:ocb-addons/6.1

Pedro Manuel Baeza has proposed merging lp:~pedro.baeza/ocb-addons/6.1-fix-935564 into lp:ocb-addons/6.1. Commit message: [FIX] account_asset: correct date when making an asset from an invoice Requested reviews: OpenERP Community Backports Team (ocb) For more details, see: https://code.launch

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep into lp:openerp-manufacturing/6.1

Review: Needs Fixing code review __openerp__.py: The 1 space indentation doesn't meet pep8 criteria. l.58 Spelling mistake of 'prodution' in description stock.py: l.126-127 Should be importing from openerp.osv, openerp.tools... (see mrp_bom_product_details/mrp_bom_product_details.py) -- https:

[Openerp-community-reviewer] [Bug 935564] Re: Asset should be takes date from the invoice date rather than current date

** Changed in: ocb-addons/6.1 Assignee: (unassigned) => Pedro Manuel Baeza (pedro.baeza) ** Changed in: ocb-addons Assignee: (unassigned) => Pedro Manuel Baeza (pedro.baeza) ** Changed in: ocb-addons Status: New => Fix Released ** Changed in: ocb-addons Status: Fix Releas

[Openerp-community-reviewer] [Bug 935564] Re: Asset should be takes date from the invoice date rather than current date

** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backpor

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-947838-sale-recreate-packing-duplicates into lp:ocb-addons/6.1

Yes you're right, I always miss this context value -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-947838-sale-recreate-packing-duplicates/+merge/194523 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~o

[Openerp-community-reviewer] [Bug 1019932] Re: [trunk/7.0/6.1] [account_asset] bad asset and move lines data

** Also affects: ocb-addons Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1019932 Title: [trunk/7.0/6.1

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/openerp-hr/unique_code into lp:openerp-hr

The proposal to merge lp:~savoirfairelinux-openerp/openerp-hr/unique_code into lp:openerp-hr has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/unique_code/+merge/196184 -- https://code.launchpad.net/~savoi

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh into lp:partner-contact-management

Review: Approve code review, no tests Thanks LGTM -- https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/197400 Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~camptocamp/partner-contact-manageme

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh into lp:partner-contact-management

Duly noted, and fixed accordingly. -- https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/197400 Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~camptocamp/partner-contact-management/remove_trailin

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh into lp:partner-contact-management

Review: Needs Fixing code review, no test Thanks Matthieu, Yannick, Agree with Yannick. To keep everything between unicode and avoid automatic encode/decode, I suggest u" ".join... -- https://code.launchpad.net/~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh/+merge/1974

[Openerp-community-reviewer] [Bug 1247158] Re: [6.1, 7.0, trunk] Context is not propagated when writing translation on 'source' fields

** Changed in: ocb-server/7.0 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1247158 Title: [6.1,7.0,trunk] Context is not propagated when

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/port-mail-env-module-jge into lp:server-env-tools

Review: Approve code review, tests It works for me too. Romain -- https://code.launchpad.net/~camptocamp/server-env-tools/port-mail-env-module-jge/+merge/194482 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/remove_trailing_space_partner_mdh into lp:partner-contact-management

Review: Needs Fixing code review, no tests Hello thanks for the fix I would just suggest a little change to do the same as we did in https://code.launchpad.net/~camptocamp/partner-contact-management/7.0-fix-lastnameempty/+merge/167906 Something like: names = (record.lastname, record.firstname

[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-basic-improvement-and-test-jge into lp:margin-analysis

Joël Grand-Guillaume @ camptocamp has proposed merging lp:~camptocamp/margin-analysis/7.0-basic-improvement-and-test-jge into lp:margin-analysis. Requested reviews: Pedro Manuel Baeza (pedro.baeza) For more details, see: https://code.launchpad.net/~camptocamp/margin-analysis/7.0-basic-improve

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-basic-improvement-and-test-jge into lp:margin-analysis

Just resumbit to have a dedicated branch for that proposal -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-basic-improvement-and-test-jge/+merge/197684 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list: https://launchpad.net/~opener

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/port-add-product_multi_company_7.0-bis-jge into lp:margin-analysis

Hi, Sorry for resumbitting once again, but the thing is, after talking to others (and Maxime Chambreuil), I'm now convince that this module is more related on financial controlling rather than product attributes. Regards, -- https://code.launchpad.net/~camptocamp/margin-analysis/port-add-produ

[Openerp-community-reviewer] [Merge] lp:~0k.io/web-addons/7.0_web_m2x_options_fix_can_create_2 into lp:web-addons

Nicolas JEUDY has proposed merging lp:~0k.io/web-addons/7.0_web_m2x_options_fix_can_create_2 into lp:web-addons. Requested reviews: Web-Addons Core Editors (webaddons-core-editors) For more details, see: https://code.launchpad.net/~0k.io/web-addons/7.0_web_m2x_options_fix_can_create_2/+merge/1

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/openerp-hr/unique_code into lp:openerp-hr

Review: Approve lgtm -- https://code.launchpad.net/~savoirfairelinux-openerp/openerp-hr/unique_code/+merge/196184 Your team HR Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/openerp-hr/unique_code into lp:openerp-hr. -- Mailing list: https://launchpad.n