[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/7.0_calendar_fix_id2real_id into lp:ocb-addons

2013-12-06 Thread Etienne Hirt
Etienne Hirt has proposed merging lp:~hirt/ocb-addons/7.0_calendar_fix_id2real_id into lp:ocb-addons. Requested reviews: Holger Brunn (Therp) (hbrunn) Related bugs: Bug #1258328 in OpenERP Community Backports (Addons): "base_calendar_id2real_id: int(base_calendar_id) can return an exception

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_dispatch-yvr into lp:carriers-deliveries

2013-12-06 Thread Yannick Vaucher @ Camptocamp
Thanks for the review, I improved my code as you suggested -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_dispatch-yvr/+merge/198049 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://l

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet

2013-12-06 Thread Yannick Vaucher @ Camptocamp
@Alexandre was your question answered with my comment https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124/comments/396592? -- https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124 Your team OpenERP Community R

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet

2013-12-06 Thread Yannick Vaucher @ Camptocamp
@Maxime can you update your review Status ? Thanks -- https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-communi

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet

2013-12-06 Thread Yannick Vaucher @ Camptocamp
@stefan Thanks for the review. I added the disclaimer and reStructured __openerp__.py Please merge it -- https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_dispatch-yvr into lp:carriers-deliveries

2013-12-06 Thread Guewen Baconnier @ Camptocamp
Review: Needs Fixing ll589..600: you call get_pdf_label() twice on each picking. I think it can be called only once when the first time there is a result. -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_dispatch-yvr/+merge/198049 Your team Stock and L

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics-yvr into lp:carriers-deliveries

2013-12-06 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review Thanks! LGTM -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics-yvr/+merge/196839 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1083077 into lp:ocb-addons

2013-12-06 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review -- https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1083077/+merge/198062 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-revie

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1083077 into lp:ocb-addons

2013-12-06 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/ocb-addons/7.0-lp1083077 into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1083077 in OpenERP Community Backports (Addons): "[sale_stock ] sale line properties missing on a procurement" ht

[Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-web_translate_dialog_page into lp:web-addons

2013-12-06 Thread Guewen Baconnier @ Camptocamp
Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/web-addons/7.0-web_translate_dialog_page into lp:web-addons. Commit message: [ADD] web_translate_dialog: replace the translation view by a translation dialog like in OpenERP 6.1 Requested reviews: Web-Addons Core Editors (webad

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-base_delivery_carrier_label-yvr into lp:carriers-deliveries

2013-12-06 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review Thanks, looks good! -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-base_delivery_carrier_label-yvr/+merge/196753 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_default_webkit-yvr into lp:carriers-deliveries

2013-12-06 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review Thanks! -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_default_webkit-yvr/+merge/198050 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~op

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-base_delivery_carrier_label-yvr into lp:carriers-deliveries

2013-12-06 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/carriers-deliveries/7.0-add-base_delivery_carrier_label-yvr into lp:carriers-deliveries. Commit message: Port of delivery_base and deliver_shipping_label removing direct print logic Requested reviews: Guewen Baconnier @ Camptoca

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_default_webkit-yvr into lp:carriers-deliveries

2013-12-06 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_default_webkit-yvr into lp:carriers-deliveries with lp:~camptocamp/carriers-deliveries/7.0-add-base_delivery_carrier_label-yvr as a prerequisite. Requested reviews: Stock and L

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_dispatch-yvr into lp:carriers-deliveries

2013-12-06 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_dispatch-yvr into lp:carriers-deliveries with lp:~camptocamp/carriers-deliveries/7.0-add-base_delivery_carrier_label-yvr as a prerequisite. Requested reviews: Guewen Baconnier

[Openerp-community-reviewer] [Bug 1083077] Re: [sale_stock ] sale line properties missing on a procurement

2013-12-06 Thread Holger Brunn (Therp)
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Assignee: (unassigned) => Holger Brunn (Therp) (hbrunn) ** Changed in: ocb-addons/7.0 Importance: Undecided =>

[Openerp-community-reviewer] [Bug 1174160] Re: Pricelist report doesn't apply the "Supplier price form product form" rule.

2013-12-06 Thread Holger Brunn (Therp)
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/7.0 Assignee: (unassigned) => Holger Brunn (Therp) (hbrunn) ** Changed in: ocb-addons/7.0 Importance: Undecided =>

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:account-invoice-report

2013-12-06 Thread Lorenzo Battistini - Agile BG
On 12/05/2013 11:49 PM, Alexis de Lattre wrote: > @Lorenzo : > > I see that we agree on points 1, 3 and 4. > > My answer on point 2 : after reflexion, I eventually think that a > fields.function is fine. It will be OK for me to use another many2many field > for the link between maintenance invoic