Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1189480 into lp:ocb-addons

2013-12-09 Thread Matthieu Dietrich @ camptocamp
Review: Disapprove Please reject this MP, since https://code.launchpad.net/~camptocamp/ocb-addons/7.0-bugfix-1189480-with-perf-mdh supersedes it. -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1189480/+merge/168463 Your team OpenERP Community Backports Team is subscribed to branch

Re: [Openerp-community-reviewer] [Merge] lp:~0k.io/web-addons/7.0_web_m2x_options_fix_can_create_2 into lp:web-addons

2013-12-09 Thread Pedro Manuel Baeza
Review: Approve code review Thanks for the fixing, Nicolas. Regards. -- https://code.launchpad.net/~0k.io/web-addons/7.0_web_m2x_options_fix_can_create_2/+merge/197658 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-commu

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/70-always-check-date into lp:account-financial-tools

2013-12-09 Thread Alexis de Lattre
@Nhomar : Could you explain exactly why you disapprove this merge proposal ? I don't understand your answer. -- https://code.launchpad.net/~akretion-team/account-financial-tools/70-always-check-date/+merge/196398 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/70-always-check-date into lp:account-financial-tools

2013-12-09 Thread Nhomar - Vauxoo
Review: Approve Alexis. I discuss internally, and you are all right the most common option is by default the option you are enabling by default here. I approve now. Sorry for the delay in answer. -- https://code.launchpad.net/~akretion-team/account-financial-tools/70-always-check-date/+merge/

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/7.0-lp1259165 into lp:ocb-server

2013-12-09 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/ocb-server/7.0-lp1259165 into lp:ocb-server. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1259165 in OpenERP Community Backports (Server): "ir.attachment doesn't return _auto_init's result" https://bugs.

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/6.1-lp1259165 into lp:ocb-server/6.1

2013-12-09 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/ocb-server/6.1-lp1259165 into lp:ocb-server/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1259165 in OpenERP Community Backports (Server): "ir.attachment doesn't return _auto_init's result" https://b

[Openerp-community-reviewer] [Bug 1259165] Re: ir.attachment doesn't return _auto_init's result

2013-12-09 Thread Holger Brunn (Therp)
** Also affects: ocb-server Importance: Undecided Status: New ** Changed in: ocb-server Status: New => Fix Committed ** Changed in: ocb-server Importance: Undecided => Low ** Changed in: ocb-server Assignee: (unassigned) => Holger Brunn (Therp) (hbrunn) ** Branch unlink

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/7.0-lp1259165 into lp:ocb-server

2013-12-09 Thread Stefan Rijnhart (Therp)
Review: Approve Obvious. Thanks! -- https://code.launchpad.net/~therp-nl/ocb-server/7.0-lp1259165/+merge/198262 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-r

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/6.1-lp1259165 into lp:ocb-server/6.1

2013-12-09 Thread Stefan Rijnhart (Therp)
Review: Approve Same as https://code.launchpad.net/~therp-nl/ocb-server/7.0-lp1259165 -- https://code.launchpad.net/~therp-nl/ocb-server/6.1-lp1259165/+merge/198261 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server/6.1. -- Mailing list: https://launchpad.net/~op

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-adding-stock_production_lot_custom_attributes-lep into lp:openerp-product-attributes

2013-12-09 Thread Leonardo Pistone @ camptocamp
The proposal to merge lp:~camptocamp/openerp-product-attributes/7.0-adding-stock_production_lot_custom_attributes-lep into lp:openerp-product-attributes has been updated. Description changed to: This is to add custom magento-style attributes on serial numbers (stock.production.lot), in the sam

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/7.0-lp1259165 into lp:ocb-server

2013-12-09 Thread Pedro Manuel Baeza
Review: Approve code review Thanks! -- https://code.launchpad.net/~therp-nl/ocb-server/7.0-lp1259165/+merge/198262 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-communit

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-server/6.1-lp1259165 into lp:ocb-server/6.1

2013-12-09 Thread Pedro Manuel Baeza
Review: Approve code review Thanks! -- https://code.launchpad.net/~therp-nl/ocb-server/6.1-lp1259165/+merge/198261 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-server/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-comm

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-basic-improvement-and-test-jge into lp:margin-analysis

2013-12-09 Thread Pedro Manuel Baeza
Review: Approve LGTM Thanks! -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-basic-improvement-and-test-jge/+merge/197684 Your team Margin Analysis Core Editors is subscribed to branch lp:margin-analysis. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:kmsistemas-openerp-addons into lp:ocb-addons/6.1

2013-12-09 Thread Pedro Manuel Baeza
Review: Needs Fixing code review Hi, Jordi, thank you very much for the MP! I wonder why all the fields definition lines are overwritten on your proposal. As OCB pretends to deviate the minimum from official branches, please stay what is not incorrect as is, and only change the minimum to fix t

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-fix_conflict_rev_9651 into lp:ocb-addons

2013-12-09 Thread Pedro Manuel Baeza
Review: Approve code review Seems OK, but a little ugly, as Holger have said. We'll wait for better times on trunk... Regards. -- https://code.launchpad.net/~therp-nl/ocb-addons/7.0-fix_conflict_rev_9651/+merge/197171 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-ad

[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/6.1-fix-1223243 into lp:ocb-addons/6.1

2013-12-09 Thread Pedro Manuel Baeza
Pedro Manuel Baeza has proposed merging lp:~pedro.baeza/ocb-addons/6.1-fix-1223243 into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) For more details, see: https://code.launchpad.net/~pedro.baeza/ocb-addons/6.1-fix-1223243/+merge/198291 Improvement made on 7.0

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/6.1-fix-1223243 into lp:ocb-addons/6.1

2013-12-09 Thread Pedro Manuel Baeza
It is a cherrypicking from revisions 9458 and 9679 of 7.0 branch, manually merging conflicting lines. -- https://code.launchpad.net/~pedro.baeza/ocb-addons/6.1-fix-1223243/+merge/198291 Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~pedro.baeza/ocb-ad

[Openerp-community-reviewer] [Bug 1223243] Re: [7.0] Impossible to import a csv file with 30000 account move lines

2013-12-09 Thread Pedro Manuel Baeza
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New ** Changed in: ocb-addons/6.1 Status: New => Fix Committed ** Changed in: ocb-addons/6.1 Assignee: (unassigned) => Pedro Manuel Baeza (p

[Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-product-attributes/7.0-product-customer-code-extraction into lp:openerp-product-attributes

2013-12-09 Thread Raphaël Valyi - http : //www . akretion . com
Raphaël Valyi - http://www.akretion.com has proposed merging lp:~akretion-team/openerp-product-attributes/7.0-product-customer-code-extraction into lp:openerp-product-attributes. Requested reviews: Product Core Editors (product-core-editors) For more details, see: https://code.launchpad.net/~

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_purchase_origin into lp:account-invoicing

2013-12-09 Thread David Cormier (Savoir-faire Linux)
David Cormier (Savoir-faire Linux) has proposed merging lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_purchase_origin into lp:account-invoicing. Requested reviews: Account Core Editors (account-core-editors) For more details, see: https://code.launchpad.net/~savoirfairelinux-

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_purchase_origin into lp:account-invoicing

2013-12-09 Thread Maxime Chambreuil (http://www.savoirfairelinux.com)
Review: Approve code review -- https://code.launchpad.net/~savoirfairelinux-openerp/account-invoicing/account_invoice_purchase_origin/+merge/198321 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Po

Re: [Openerp-community-reviewer] [Merge] lp:~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix into lp:ocb-addons/6.1

2013-12-09 Thread Stefan Rijnhart (Therp)
Setting to WIP after 3 months of inactivity. -- https://code.launchpad.net/~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix/+merge/185327 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-rev

[Openerp-community-reviewer] [Merge] lp:~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix into lp:ocb-addons/6.1

2013-12-09 Thread Stefan Rijnhart (Therp)
The proposal to merge lp:~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix into lp:ocb-addons/6.1 has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~florian-dacosta/ocb-addons/6.1_purchase_line_partner_fix/+merge/185327 --

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/lp1215897 into lp:ocb-addons

2013-12-09 Thread Stefan Rijnhart (Therp)
Review: Approve Looks like the code has been updated in the meantime, even if that has not been announced in this thread (OPW review has been superseded too). Looks good now. -- https://code.launchpad.net/~camptocamp/ocb-addons/lp1215897/+merge/187192 Your team OpenERP Community Backports Team

Re: [Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/trunk_lp1237832 into lp:ocb-addons

2013-12-09 Thread Stefan Rijnhart (Therp)
Review: Approve test -- https://code.launchpad.net/~hbrunn/ocb-addons/trunk_lp1237832/+merge/190317 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lis

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/6.1_lp1237832 into lp:ocb-addons/6.1

2013-12-09 Thread Stefan Rijnhart (Therp)
Review: Approve test -- https://code.launchpad.net/~therp-nl/ocb-addons/6.1_lp1237832/+merge/190312 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer

[Openerp-community-reviewer] [Bug 1237832] Re: [6.1] [7.0] [trunk] [account_budget] doesn't recurse into analytic account's children

2013-12-09 Thread Stefan Rijnhart (Therp)
...on view accounts (last post got truncated) -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1237832 Title: [6.1] [7.0] [trunk] [account_budget] doesn't recurse into analytic account

[Openerp-community-reviewer] [Bug 1237832] Re: [6.1] [7.0] [trunk] [account_budget] doesn't recurse into analytic account's children

2013-12-09 Thread Stefan Rijnhart (Therp)
Hi Amit, maybe I don't understand, but I have tried to recreate your scenario: Two budget lines: Analytic account: Partner / Axelor, amount 500 Analytic account: Partner / Asus, amount 100. I create invoices of these amounts on these respective analytic accounts, and each line has their own amou

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/6.1-fix-1223243 into lp:ocb-addons/6.1

2013-12-09 Thread Stefan Rijnhart (Therp)
Review: Needs Fixing Hi Pedro, I know you do a lot of good work, but I am a little unhappy with a proposal that you did not even fully test yourself (thank you for your honesty though!). That's enough to warrant a disapproval as far as I'm concerned, as you can't really expect a reviewer to sp