[Openerp-community-reviewer] [Bug 1197467] Re: duplicate inventory lines produce wrong posted inventories

2014-01-16 Thread Cedric Le Brouster(OpenFire)
** Branch linked: lp:~cedric-lebrouster/openobject- addons/7.0-bug-1197467-stock-inventory -- You received this bug notification because you are a member of Stock and Logistic Core Editors, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1197467 Title: duplicate inventor

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1

2014-01-16 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing code review, no tests in mrp_split_units/__openerp__.py please use data keyword instead of deprecated init_xml update_xml demo_xml -- https://code.launchpad.net/~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep/+merge/200544 Your team Manufacture Core Editors is s

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1

2014-01-16 Thread Yannick Vaucher @ Camptocamp
Yes, I know I'm a turncoat sorry for that -- https://code.launchpad.net/~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep/+merge/200544 Your team Manufacture Core Editors is subscribed to branch lp:openerp-manufacturing/6.1. -- Mailing list: https://launchpad.net/~openerp-community-

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1

2014-01-16 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1 has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep/+merge/

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows/6.1

2014-01-16 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests Thanks for the changes LGTM -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/+merge/196749 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows/6.1. -- Mailing list: ht

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows/6.1

2014-01-16 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows/6.1 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attribute

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_one-2-lep into lp:openerp-manufacturing/6.1

2014-01-16 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing code review, no tests l265 missing context propagation fr po file should be named fr.po instead of fr_FR.po otherwise I suspect that fr translation won't be loaded Could you can also translate those terms: msgid "Quantity needs to be more that 1." msgstr "La quantité doit

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1

2014-01-16 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep/+merge/

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1

2014-01-16 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests 6.1 here not needed -- https://code.launchpad.net/~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep/+merge/200544 Your team Manufacture Core Editors is subscribed to branch lp:openerp-manufacturing/6.1. -- Mailing list: https://launchpad.net/~o

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/6.1-add-invoice-merge-lep into lp:account-invoicing/6.1

2014-01-16 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests LGTM Thanks! -- https://code.launchpad.net/~camptocamp/account-invoicing/6.1-add-invoice-merge-lep/+merge/197847 Your team Account Core Editors is subscribed to branch lp:account-invoicing/6.1. -- Mailing list: https://launchpad.net/~openerp-community-revi

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1

2014-01-16 Thread noreply
The proposal to merge lp:~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep into lp:openerp-manufacturing/6.1 has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-manufacturing/6.1-add-mrp_split_units-lep/+merge/200544

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows/6.1

2014-01-16 Thread noreply
The proposal to merge lp:~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep into lp:stock-logistic-flows/6.1 has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/stock-logistic-flows/6.1-add-mrp_open_lot_attributes-lep/

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/credit_control_report_improvement_vre into lp:account-financial-tools

2014-01-16 Thread Vincent Renaville@camptocamp
Vincent Renaville@camptocamp has proposed merging lp:~camptocamp/account-financial-tools/credit_control_report_improvement_vre into lp:account-financial-tools. Requested reviews: Account Core Editors (account-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/account-

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics_shop_logo-yvr into lp:carriers-deliveries

2014-01-16 Thread Yannick Vaucher @ Camptocamp
Thanks for the review, here I just adapt the inheritance to the changes made in dependancies -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics_shop_logo-yvr/+merge/196859 Your team Stock and Logistic Core Editors is subscribed to branch lp

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update into lp:sale-wkfl

2014-01-16 Thread Ronald Portier (Therp)
Review: Approve Tested the module and it works as expected -- https://code.launchpad.net/~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update/+merge/200611 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/purchase-wkfl/70-add-purchase_fiscal_position_update into lp:purchase-wkfl

2014-01-16 Thread Ronald Portier (Therp)
Review: Approve test tested the module and it works as expected. -- https://code.launchpad.net/~akretion-team/purchase-wkfl/70-add-purchase_fiscal_position_update/+merge/201115 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~open

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update into lp:sale-wkfl

2014-01-16 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing contributors As there are many contributors, please write it under Contributors in __openerp__.py https://doc.openerp.com/contribute/05_developing_modules/#community-guidelines If you are contributing to a module made by someone else, at the end of the description fields,

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-use-footer-tag-in-wizard into lp:openerp-rma

2014-01-16 Thread Benoit Guillot - http://www.akretion.com
Review: Approve code review LGTM -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-use-footer-tag-in-wizard/+merge/199822 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-revi

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/bug-1269036 into lp:partner-contact-management

2014-01-16 Thread Pedro Manuel Baeza
Hi, Sandy, There isn't any other solution? Doing that, you let user entry without control. Maybe you can make on write/create a check to move the value of 'name' field to this one in certain cases, and this also makes that any functionality programmed for the other field, wins compatibility wit

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/bug-1269036 into lp:partner-contact-management

2014-01-16 Thread Sandy Carter (http://www.savoirfairelinux.com)
The proposal to merge lp:~savoirfairelinux-openerp/partner-contact-management/bug-1269036 into lp:partner-contact-management has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/bug-

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/bug-1269036 into lp:partner-contact-management

2014-01-16 Thread Sandy Carter (http://www.savoirfairelinux.com)
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging lp:~savoirfairelinux-openerp/partner-contact-management/bug-1269036 into lp:partner-contact-management. Requested reviews: Partner and Contact Core Editors (partner-contact-core-editors) For more details, see: https://code.la

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/bug-1269036 into lp:partner-contact-management

2014-01-16 Thread Sandy Carter (http://www.savoirfairelinux.com)
@Pedro This should be put in as a Work in Progress, it solves an error, but there is another later: > 2014-01-16 16:02:23,609 7017 TEST oif openerp.tools.yaml_import: In order to > test the basic EDI system, I will export a partner, modify the exported EDI > document to add an attachment and ch

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/bug-1269036 into lp:partner-contact-management

2014-01-16 Thread Maxime Chambreuil (http://www.savoirfairelinux.com)
I don't know if it is technically possible, but could we use the name field to store the lastname value and have name+firstname displayed in a relationship ? -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/bug-1269036/+merge/201947 Your team Partner and Contact

[Openerp-community-reviewer] [Merge] lp:~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear into lp:account-financial-report/6.1

2014-01-16 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/account-financial-report/6.1-analytic_entries_report_fiscalyear into lp:account-financial-report/6.1. Requested reviews: Account Report Core Editors (account-report-core-editor) Related bugs: Bug #987038 in OpenERP Addons: "Analytic Entr

[Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/7.0-fetchmail_attach_from_folder into lp:server-env-tools

2014-01-16 Thread Holger Brunn (Therp)
Holger Brunn (Therp) has proposed merging lp:~therp-nl/server-env-tools/7.0-fetchmail_attach_from_folder into lp:server-env-tools. Requested reviews: Server Environment And Tools Core Editors (server-env-tools-core-editors) For more details, see: https://code.launchpad.net/~therp-nl/server-en

[Openerp-community-reviewer] [Bug 1269965] [NEW] [7.0] Method _get_lines signature changed

2014-01-16 Thread Pedro Manuel Baeza
Public bug reported: In revision 9599 (http://bazaar.launchpad.net/~ocb/ocb- addons/7.0/revision/9599), Yannick made a change in the signature of the method, adding a positional argument called 'target_move'. I know that this method is internal, but we are using it in Spain to get taxes values fo

[Openerp-community-reviewer] [Bug 1089229] Re: Sales using Secondary UoM show incorrect unit price

2014-01-16 Thread Alejandro Santana
** Also affects: ocb-addons Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1089229 Title: Sales using Se

[Openerp-community-reviewer] [Merge] lp:~alejandrosantana/ocb-addons/6.1-ocb-addons-fix-bug-1089229 into lp:ocb-addons/6.1

2014-01-16 Thread Alejandro Santana
Alejandro Santana has proposed merging lp:~alejandrosantana/ocb-addons/6.1-ocb-addons-fix-bug-1089229 into lp:ocb-addons/6.1. Commit message: [FIX] Fixes the sales order report to show correctly the unit price if UoS is definied. Also corrects the decimal precision of subtotals, total untaxed,

[Openerp-community-reviewer] [Bug 1089229] Re: Sales using Secondary UoM show incorrect unit price

2014-01-16 Thread Alejandro Santana
** Also affects: ocb-addons/6.1 Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Bac