Re: [Openerp-community-reviewer] [Merge] lp:~yannick-buron/contract-management/contract-management into lp:contract-management

2014-02-04 Thread Ronald Portier (Therp)
As for the 2nd and 3rd points: in this case I think it is best to leave the backported code as is. If there are any enhancements in the code in trunk, it will be much easier to adopt them when the backport is really a backport. If we really would like to have a module fashioned after community

Re: [Openerp-community-reviewer] [Merge] lp:~yannick-buron/contract-management/contract-management into lp:contract-management

2014-02-04 Thread Joël Grand-Guillaume
Review: Needs Fixing code review, no test Hi Yannick, Thanks for this back port and I very welcome your first (if I'm not wrong) contribution here ! I've just a couple of remarks: * Line 66: For the author part, as it's OpenERP who did it first, I think it's fair to let OpenERP here. I sugge

[Openerp-community-reviewer] [Bug 1171505] Re: [Trunk/7.0] Reply-to in email templates ignored

2014-02-04 Thread Michael Karrer
Any Update on this one? There is not even a branch or merge proposal for this patch?!? -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is a bug assignee. https://bugs.launchpad.net/bugs/1171505 Title: [Trunk/7.0] Reply-to in email templ

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1012470-fix-procurement-prioritization into lp:ocb-addons/6.1

2014-02-04 Thread Stefan Rijnhart (Therp)
Review: Approve Thanks, I checked the current 7.0 setting and it is the same as in this proposal. -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1012470-fix-procurement-prioritization/+merge/204496 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1012470-fix-procurement-prioritization into lp:ocb-addons/6.1

2014-02-04 Thread Pedro Manuel Baeza
Review: Approve code review LGTM -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1012470-fix-procurement-prioritization/+merge/204496 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-r

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters into lp:ocb-addons/6.1

2014-02-04 Thread Pedro Manuel Baeza
Review: Needs Information Hi, Yann, are those filters really so needed? -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1275659-crm-my-items-filters/+merge/204498 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launc

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1276190-percentage-char-escape into lp:ocb-addons/6.1

2014-02-04 Thread Stefan Rijnhart (Therp)
Review: Needs Fixing Hi Yann, looks like this patch disables all variable substitution: >>> '%(name)s' % {'name': 'bla'} 'bla' >>> '%(name)s'.replace('%', '%%') % {'name': 'bla'} '%(name)s' Not sure about the validity of this bug. You could view it as a usability issue that the

[Openerp-community-reviewer] [Merge] lp:~sistemas-adhoc/account-financial-tools/currency_update into lp:account-financial-tools

2014-02-04 Thread Juan José Scarafía
Juan José Scarafía has proposed merging lp:~sistemas-adhoc/account-financial-tools/currency_update into lp:account-financial-tools. Requested reviews: Pedro Manuel Baeza (pedro.baeza) For more details, see: https://code.launchpad.net/~sistemas-adhoc/account-financial-tools/currency_update/+me

Re: [Openerp-community-reviewer] [Merge] lp:~sistemas-adhoc/account-financial-tools/currency_update into lp:account-financial-tools

2014-02-04 Thread Pedro Manuel Baeza
Review: Approve LGTM Thanks! -- https://code.launchpad.net/~sistemas-adhoc/account-financial-tools/currency_update/+merge/204759 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-review

Re: [Openerp-community-reviewer] [Merge] lp:~sistemas-adhoc/account-financial-tools/currency_update into lp:account-financial-tools

2014-02-04 Thread Juan José Scarafía
Thanks you!! :) -- https://code.launchpad.net/~sistemas-adhoc/account-financial-tools/currency_update/+merge/204759 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~gkliska/server-env-tools/server-env-tools-61 into lp:server-env-tools/6.1

2014-02-04 Thread Pedro Manuel Baeza
Review: Abstain OK then, I let then the review to someone with JS skills (it's one of my pendings). Regards. -- https://code.launchpad.net/~gkliska/server-env-tools/server-env-tools-61/+merge/204699 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools

[Openerp-community-reviewer] [Merge] lp:~yannick-buron/contract-management/contract-management into lp:contract-management

2014-02-04 Thread YannickB
YannickB has proposed merging lp:~yannick-buron/contract-management/contract-management into lp:contract-management. Requested reviews: Contract Management Core Editors (contract-management-core-editors) For more details, see: https://code.launchpad.net/~yannick-buron/contract-management/cont

Re: [Openerp-community-reviewer] [Merge] lp:~gkliska/server-env-tools/server-env-tools-61 into lp:server-env-tools/6.1

2014-02-04 Thread Goran Kliska
@Pedro Yes, but I did it in a few hours using Chrome debugger (first time with OpenERP) and patching web client directly. This is my first web module and I wrote it without basic knowledge about OE web client. Results of my tests are: 1. It is not throwing errors, 2. It's working on my test cas

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1276190-percentage-char-escape into lp:ocb-addons/6.1

2014-02-04 Thread Pedro Manuel Baeza
Review: Approve code review LGTM Thanks for all the 6.1 bugfixing work! I insist in translate all possible unresolved bugs also to 7.0. Regards. -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1276190-percentage-char-escape/+merge/204708 Your team OpenERP Community Backports Tea

[Openerp-community-reviewer] [Merge] lp:~rruebner/server-env-tools/7.0_fix_mass_editing into lp:server-env-tools

2014-02-04 Thread Robert Rübner
Robert Rübner has proposed merging lp:~rruebner/server-env-tools/7.0_fix_mass_editing into lp:server-env-tools. Requested reviews: Server Environment And Tools Core Editors (server-env-tools-core-editors) For more details, see: https://code.launchpad.net/~rruebner/server-env-tools/7.0_fix_mass

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1276190-percentage-char-escape into lp:ocb-addons/6.1

2014-02-04 Thread Yann Papouin
Yann Papouin has proposed merging lp:~yann-papouin/ocb-addons/6.1-bug-1276190-percentage-char-escape into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1276190 in OpenERP Community Backports (Addons): "[6.1] format_mail raise an exception wh

[Openerp-community-reviewer] [Bug 1276190] Re: [6.1] format_mail raise an exception when % character exists in text

2014-02-04 Thread Yann Papouin
** Also affects: ocb-addons Importance: Undecided Status: New ** Changed in: ocb-addons Assignee: (unassigned) => Yann Papouin (yann-papouin) ** Changed in: ocb-addons Importance: Undecided => Low ** Changed in: ocb-addons Status: New => Fix Committed -- You received t

Re: [Openerp-community-reviewer] [Merge] lp:~gkliska/server-env-tools/server-env-tools-61 into lp:server-env-tools/6.1

2014-02-04 Thread Pedro Manuel Baeza
Review: Needs Information Don't you think this is better as a bugfix in OCB branch? Regards. -- https://code.launchpad.net/~gkliska/server-env-tools/server-env-tools-61/+merge/204699 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools/6.1. -- Mailin

[Openerp-community-reviewer] [Merge] lp:~gkliska/server-env-tools/server-env-tools-61 into lp:server-env-tools/6.1

2014-02-04 Thread Goran Kliska
Goran Kliska has proposed merging lp:~gkliska/server-env-tools/server-env-tools-61 into lp:server-env-tools/6.1. Requested reviews: Server Environment And Tools Core Editors (server-env-tools-core-editors) For more details, see: https://code.launchpad.net/~gkliska/server-env-tools/server-env-t

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_cost_incl_bom_price_history-mismatch-product-template into lp:margin-analysis

2014-02-04 Thread Joël Grand-Guillaume
Review: Approve code review + test Hi, LGTM, thanks ! Just added the same support to open historic price from product form. Regards -- https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_cost_incl_bom_price_history-mismatch-product-template/+merge/201447 Your team Margin Analysi

[Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/7.0-fix-dissociate-lep into lp:project-reporting

2014-02-04 Thread noreply
The proposal to merge lp:~camptocamp/project-reporting/7.0-fix-dissociate-lep into lp:project-reporting has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/project-reporting/7.0-fix-dissociate-lep/+merge/200695 -- https://code.launchpad

[Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/7.0-fix-dissociate-lep into lp:project-reporting

2014-02-04 Thread Alexandre Fayolle - camptocamp
The proposal to merge lp:~camptocamp/project-reporting/7.0-fix-dissociate-lep into lp:project-reporting has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/project-reporting/7.0-fix-dissociate-lep/+merge/200695 -- https://code.lau

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/7.0-fix-dissociate-lep into lp:project-reporting

2014-02-04 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/project-reporting/7.0-fix-dissociate-lep/+merge/200695 Your team Project Core Editors is subscribed to branch lp:project-reporting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : op

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/7.0-fix-dissociate-lep into lp:project-reporting

2014-02-04 Thread Matthieu Dietrich @ camptocamp
Review: Approve code review, test LGTM, tested locally. -- https://code.launchpad.net/~camptocamp/project-reporting/7.0-fix-dissociate-lep/+merge/200695 Your team Project Core Editors is subscribed to branch lp:project-reporting. -- Mailing list: https://launchpad.net/~openerp-community-reviewe