[Openerp-community-reviewer] [Merge] lp:~alejandrosantana/openerp-humanitarian-ngo/7.0-purchase-wkfl--fix-1277236 into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Alejandro Santana
Alejandro Santana has proposed merging lp:~alejandrosantana/openerp-humanitarian-ngo/7.0-purchase-wkfl--fix-1277236 into lp:openerp-humanitarian-ngo/purchase-wkfl. Commit message: [FIX] purchase_requisition_extended: Fixes typos breaking dictionaries. Requested reviews: OpenERP for Humanitari

Re: [Openerp-community-reviewer] [Openerp-community] [Merge] lp:~pedro.baeza/openerp-product-attributes/7.0-product_pricelist_fixed_price into lp:openerp-product-attributes

2014-02-06 Thread Marc Pierlot
Bonjour Est ce que quelqu'un peu me dire ce que je dos faire pour ne plus recevoir ces messages de Open ERP qui m embetetent merci de ne plus me les envoyer Tcau. 2014-02-06 11:08 GMT+01:00 Pedro Manuel Baeza : > Hi, Lionel, > > Indeed, you have to adjust all fields by XML-RPC, but that's th

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced into lp:stock-logistic-flows

2014-02-06 Thread Alexis de Lattre
@Pedro I have made the implementation: it works well, but one may consider that it's too much code for a small detail... By the way, we also had a problem with the view of invoices : I had put "Delivery Orders" for the tab of customer invoices... but, on a customer refund, it should be "Incomi

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/progressbar into lp:lp-community-utils

2014-02-06 Thread Maxime Chambreuil (http://www.savoirfairelinux.com)
Review: Approve -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/progressbar/+merge/205252 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to :

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/progressbar into lp:lp-community-utils

2014-02-06 Thread Pedro Manuel Baeza
Review: Approve code review and test Hi, Sandy, Now, it works well with both versions. Thank you very much. Regards. -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/progressbar/+merge/205252 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/add_document_multiple_records into lp:knowledge-addons

2014-02-06 Thread Sandy Carter (http://www.savoirfairelinux.com)
You have been requested to review the proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/add_document_multiple_records into lp:knowledge-addons. For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/add_document_multiple_records/+merge/205249

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/branch_pep8 into lp:lp-community-utils

2014-02-06 Thread Sandy Carter (http://www.savoirfairelinux.com)
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging lp:~savoirfairelinux-openerp/lp-community-utils/branch_pep8 into lp:lp-community-utils with lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor as a prerequisite. Requested reviews: OpenERP Community Reviewer/Maintai

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/progressbar into lp:lp-community-utils

2014-02-06 Thread Sandy Carter (http://www.savoirfairelinux.com)
I didn't test with version 2.2, I assumed it would work. What version do you have with pip? The version I used (I have Arch, not Ubuntu) is 2.3. This is the base usage of progressbar (from their documentation) progress = ProgressBar() for i in progress(range(80)): time.sleep(0.01) The problema

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor into lp:lp-community-utils

2014-02-06 Thread Sandy Carter (http://www.savoirfairelinux.com)
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging lp:~savoirfairelinux-openerp/lp-community-utils/nag_refactor into lp:lp-community-utils. Requested reviews: OpenERP Community Reviewer/Maintainer (openerp-community-reviewer) For more details, see: https://code.launchpad.net/

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/progressbar into lp:lp-community-utils

2014-02-06 Thread Pedro Manuel Baeza
Review: Needs Information It doesn't work with the version included in Ubuntu 12.04 (python-progressbar 2.2-2), but it does with the one got with pip. It says: "'ProgressBar' object is not callable" Do you know what can be happening? Regards. -- https://code.launchpad.net/~savoirfairelinux-op

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/progressbar into lp:lp-community-utils

2014-02-06 Thread Sandy Carter (http://www.savoirfairelinux.com)
The proposal to merge lp:~savoirfairelinux-openerp/lp-community-utils/progressbar into lp:lp-community-utils has been updated. Description changed to: Adds a progressbar in the console output since this script takes a long time. The progressbar is from the progressbar library. If it is availabl

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/progressbar into lp:lp-community-utils

2014-02-06 Thread Sandy Carter (http://www.savoirfairelinux.com)
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging lp:~savoirfairelinux-openerp/lp-community-utils/progressbar into lp:lp-community-utils. Requested reviews: OpenERP Community Reviewer/Maintainer (openerp-community-reviewer) For more details, see: https://code.launchpad.net/~

[Openerp-community-reviewer] [Merge] lp:~lin-yu/purchase-wkfl/add_product_supplier_info into lp:purchase-wkfl

2014-02-06 Thread noreply
The proposal to merge lp:~lin-yu/purchase-wkfl/add_product_supplier_info into lp:purchase-wkfl has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~lin-yu/purchase-wkfl/add_product_supplier_info/+merge/194777 -- https://code.launchpad.net/~lin-

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394 into lp:lp-community-utils

2014-02-06 Thread Sandy Carter (http://www.savoirfairelinux.com)
@rportier1962 As you pointed out, /usr/bin/env will take the python from the virtualenv. If you do a ls -l, you'll notice that python is a symlink to the python2 or python3 executable, depending on if you used virtualenv2 or virtualenv3. My changes will, in fact, not break any virtualenv installat

Re: [Openerp-community-reviewer] [Merge] lp:~lin-yu/purchase-wkfl/add_product_supplier_info into lp:purchase-wkfl

2014-02-06 Thread Pedro Manuel Baeza
Review: Approve I'm going to proceed to merge this one, changing the name before. Regards. -- https://code.launchpad.net/~lin-yu/purchase-wkfl/add_product_supplier_info/+merge/194777 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.ne

Re: [Openerp-community-reviewer] [Merge] lp:~lin-yu/purchase-wkfl/add_product_supplier_info into lp:purchase-wkfl

2014-02-06 Thread Pedro Manuel Baeza
I also add the pot file. -- https://code.launchpad.net/~lin-yu/purchase-wkfl/add_product_supplier_info/+merge/194777 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-review

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report

2014-02-06 Thread Alex Comba - Agile BG
The proposal to merge lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report has been updated. Description changed to: Merge proposal to fix the following bugs: https://bugs.launchpad.net/account-invoice-report/+bug/1208389 https://bugs.launch

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

2014-02-06 Thread Pedro Manuel Baeza
I think this one has been merged too fast, with only one approval, and two information requested. For the moment, I see that there's no pot file. Could you please ellaborate why this merge? Regards. -- https://code.launchpad.net/~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi/+mer

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1091268-purchase-merge-no-origin-duplicates into lp:ocb-addons/6.1

2014-02-06 Thread Pedro Manuel Baeza
Review: Approve code review OK, now I get it. About the script, it's difficult to make it automatic, but maybe bzr-replay must serve. I made all manually for the moment. It's only a little effort, but community will appreciate it if you do it! ;) Regards. -- https://code.launchpad.net/~yann-p

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/fix-unmerged-dependency into lp:openerp-humanitarian-ngo

2014-02-06 Thread Leonardo Pistone @ camptocamp
Review: Approve code review looks good, thanks -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/fix-unmerged-dependency/+merge/205209 Your team OpenERP for Humanitarian Core Editors is requested to review the proposed merge of lp:~camptocamp/openerp-humanitarian-ngo/fix-unmerg

[Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-02-06 Thread Matthieu Dietrich @ camptocamp
Matthieu Dietrich @ camptocamp has proposed merging lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management. Requested reviews: Contract Management Core Editors (contract-management-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/contract-mana

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/fix-unmerged-dependency into lp:openerp-humanitarian-ngo

2014-02-06 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging lp:~camptocamp/openerp-humanitarian-ngo/fix-unmerged-dependency into lp:openerp-humanitarian-ngo. Requested reviews: OpenERP for Humanitarian Core Editors (humanitarian-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report

2014-02-06 Thread Alex Comba - Agile BG
Alex Comba - Agile BG has proposed merging lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report. Commit message: [FIX] invoice_webkit bugs: #1208389, #1231329 and #1277024 Requested reviews: Account Core Editors (account-core-editors) Relat

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

2014-02-06 Thread noreply
The proposal to merge lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi/+merge/19653

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-899470-stock-product-available-optimization into lp:ocb-addons/6.1

2014-02-06 Thread Yann Papouin
Yann Papouin has proposed merging lp:~yann-papouin/ocb-addons/6.1-bug-899470-stock-product-available-optimization into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #899470 in OpenERP Community Backports (Addons): "[6.0][6.1][stock] get_produ

[Openerp-community-reviewer] [Bug 899470] Re: [6.0][6.1][stock] get_product_available needs optimization

2014-02-06 Thread Yann Papouin
** Summary changed: - [6.0 TRUNK][STOCK] opening menu location take 45 seconds... + [6.0][6.1][stock] get_product_available needs optimization ** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New ** C

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1

2014-02-06 Thread Alexandre Fayolle - camptocamp
I fast tracked this one and merged it a moment ago. -- https://code.launchpad.net/~camptocamp/account-financial-tools/6.1-fix-1276998/+merge/205121 Your team Account Core Editors is subscribed to branch lp:account-financial-tools/6.1. -- Mailing list: https://launchpad.net/~openerp-community-r

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1

2014-02-06 Thread noreply
The proposal to merge lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~camptocamp/account-financial-tools/6.1-fix-1276998/+merge/205121 -- https://co

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1091268-purchase-merge-no-origin-duplicates into lp:ocb-addons/6.1

2014-02-06 Thread Yann Papouin
The merge will occurs in one side or another, since a merged purchase order can be merged again and again. >>> originA = 'AAA' >>> originB = 'AAA BBB CCC' >>> originA in originB True >>> originB in originA False About the OCB 7.0, I currently concentrate my effort on pushing on OCB all 6.1 bugs

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125 into lp:openerp-fiscal-rules

2014-02-06 Thread Guewen Baconnier @ Camptocamp
Guewen Baconnier @ Camptocamp has proposed merging lp:~camptocamp/openerp-fiscal-rules/7.0-onchange_shop_id-1277125 into lp:openerp-fiscal-rules. Commit message: [FIX] onchange_shop_id should call super to initialize all the fields properly Requested reviews: Account Core Editors (account-cor

Re: [Openerp-community-reviewer] [Merge] lp:~yajo/server-env-tools/server-env-tools into lp:server-env-tools

2014-02-06 Thread Daniel Reis
Review: Approve lgtm -- https://code.launchpad.net/~yajo/server-env-tools/server-env-tools/+merge/205137 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-co

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1091268-purchase-merge-no-origin-duplicates into lp:ocb-addons/6.1

2014-02-06 Thread Pedro Manuel Baeza
Review: Needs Information Why do you need the second part of the if (and not order_infos['origin'] in porder.origin)? Please put an example. Again, I insist in the convenience of porting also this kind of patches to OCB 7.0, because the patch will arrive on trunk, not on v7. Regards. -- https

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1049415-bomfind-active-date into lp:ocb-addons/6.1

2014-02-06 Thread Pedro Manuel Baeza
Review: Approve code review Same as official. LGTM. Regards. -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1049415-bomfind-active-date/+merge/205174 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~o

[Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-icm/7.0_fix_sale_commission into lp:openerp-icm

2014-02-06 Thread Alex Comba - Agile BG
Alex Comba - Agile BG has proposed merging lp:~agilebg/openerp-icm/7.0_fix_sale_commission into lp:openerp-icm. Requested reviews: openerp-icm (openerp-icm) Related bugs: Bug #1277110 in openerp-icm: "Error while trying to install sale_commission" https://bugs.launchpad.net/openerp-icm/+bug

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1091268-purchase-merge-no-origin-duplicates into lp:ocb-addons/6.1

2014-02-06 Thread Yann Papouin
Yann Papouin has proposed merging lp:~yann-papouin/ocb-addons/6.1-bug-1091268-purchase-merge-no-origin-duplicates into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1091268 in OpenERP Community Backports (Addons): "Useless duplicates origin

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1049415-bomfind-active-date into lp:ocb-addons/6.1

2014-02-06 Thread Yann Papouin
Yann Papouin has proposed merging lp:~yann-papouin/ocb-addons/6.1-bug-1049415-bomfind-active-date into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1049415 in OpenERP Community Backports (Addons): "the BoM does not validate field active nor

[Openerp-community-reviewer] [Bug 1049415] Re: the BoM does not validate field active nor dates

2014-02-06 Thread Yann Papouin
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New ** Changed in: ocb-addons/6.1 Status: New => Fix Committed ** Changed in: ocb-addons/6.1 Assignee: (unassigned) => Yann Papouin (yann-pa

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe into lp:sale-wkfl

2014-02-06 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Needs Fixing code review, no test Still some PEP8 issues: account_invoice_reorder_lines/__init__.py:19:75: W291 trailing whitespace account_invoice_reorder_lines/__init__.py:23:1: W391 blank line at end of file account_invoice_reorder_lines/__openerp__.py:21:1: O603 Manifest "license" key

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1048547-product-variant-supplierinfo-pricelist into lp:ocb-addons/6.1

2014-02-06 Thread Pedro Manuel Baeza
Review: Approve code review I have never faced this problem, but I don't use variants. Seems OK. Regards. -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1048547-product-variant-supplierinfo-pricelist/+merge/205161 Your team OpenERP Community Backports Team is subscribed to branch

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread noreply
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/add-bid_selected_

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/add-base_partner_merge into lp:partner-contact-management

2014-02-06 Thread Guewen Baconnier @ Camptocamp
Review: Needs Information Is the dependency on portal really necessary? -- https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: h

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests LGTM -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi/+merge/200799 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list: https

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/add-bid_sel

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1048547-product-variant-supplierinfo-pricelist into lp:ocb-addons/6.1

2014-02-06 Thread Yann Papouin
Yann Papouin has proposed merging lp:~yann-papouin/ocb-addons/6.1-bug-1048547-product-variant-supplierinfo-pricelist into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1048547 in OpenERP Community Backports (Addons): "[6.1] purchase: changin

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/add-base_partner_merge into lp:partner-contact-management

2014-02-06 Thread Yannick Vaucher @ Camptocamp
Applied PEP8 as much as possible on OpenERP's code -- https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1

2014-02-06 Thread Alexis de Lattre
Review: Approve code review and tests with openerp 6.1 -- https://code.launchpad.net/~camptocamp/account-financial-tools/6.1-fix-1276998/+merge/205121 Your team Account Core Editors is subscribed to branch lp:account-financial-tools/6.1. -- Mailing list: https://launchpad.net/~openerp-communi

[Openerp-community-reviewer] [Bug 1048547] Re: [6.1] purchase: changing a product uses wrong supplier info data

2014-02-06 Thread Yann Papouin
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New ** Changed in: ocb-addons/6.1 Assignee: (unassigned) => Yann Papouin (yann-papouin) ** Changed in: ocb-addons/6.1 Importance: Undecided => M

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Romain Deheele - Camptocamp
Review: Approve code review LGTM, Romain -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi/+merge/200799 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list: https:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi into lp:openerp-humanitarian-ngo/addons-backport

2014-02-06 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi into lp:openerp-humanitarian-ngo/addons-backport has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/addo

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_other_procurement_method-nbi into lp:openerp-humanitarian-ngo

2014-02-06 Thread Nicolas Bessi - Camptocamp
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_other_procurement_method-nbi into lp:openerp-humanitarian-ngo has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-ad

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi into lp:openerp-humanitarian-ngo/addons-backport

2014-02-06 Thread noreply
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi into lp:openerp-humanitarian-ngo/addons-backport has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/addons-bac

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi into lp:openerp-humanitarian-ngo/addons-backport

2014-02-06 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests LGTM -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi/+merge/195007 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/addons-backport. -- Mailing list

[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi into lp:purchase-wkfl

2014-02-06 Thread noreply
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi into lp:purchase-wkfl has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi/+merge/196681 -- https://cod

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi into lp:purchase-wkfl

2014-02-06 Thread Romain Deheele - Camptocamp
Review: Approve code review LGTM, Regards, Romain -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi/+merge/196681 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1077931-fix-purchase-invoiced-rate into lp:ocb-addons/6.1

2014-02-06 Thread Yann Papouin
Yann Papouin has proposed merging lp:~yann-papouin/ocb-addons/6.1-bug-1077931-fix-purchase-invoiced-rate into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1077931 in OpenERP Community Backports (Addons): "[6.1][7.0][trunk] purchase progress

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1

2014-02-06 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test line 55 could use self.logger.error(error_msg) (ie. change the logging level and use a more informative message) -- https://code.launchpad.net/~camptocamp/account-financial-tools/6.1-fix-1276998/+merge/205121 Your team Account Core Editors is subscribed to br

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_1250507-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread noreply
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_1250507-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fi

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-add_framework_agreement-nbi into lp:purchase-wkfl

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + test Hi, This LGTM. I just have the little remark I already made: * Adding a LTA on a product should add a supplierinfo entry as well. A part from that, LGTM. I don't want to block it for that. Just to let you know. Regards, -- https://code.launchpad.net/~campt

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread noreply
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkf

Re: [Openerp-community-reviewer] [Merge] lp:~yajo/server-env-tools/server-env-tools into lp:server-env-tools

2014-02-06 Thread Pedro Manuel Baeza
Review: Approve Hi, Yajo, thank you for your contribution. Much appreciated. Regards. -- https://code.launchpad.net/~yajo/server-env-tools/server-env-tools/+merge/205137 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://l

[Openerp-community-reviewer] [Merge] lp:~yajo/server-env-tools/server-env-tools into lp:server-env-tools

2014-02-06 Thread Yajo
he following modules: +# * mass_editing +# +msgid "" +msgstr "" +"Project-Id-Version: OpenERP Server 7.0-20140206-002714\n" +"Report-Msgid-Bugs-To: \n" +"POT-Creation-Date: 2014-02-06 11:38+\n" +"PO-Revision-Date: 2014-02-06 12:50+0100\n"

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + test LGTM, Thanks ! -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/add-bid_selected_state_on_po-nbi/+merge/200799 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_1250507-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + test LGTM, thanks ! -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_1250507-nbi/+merge/195006 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list: h

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi into lp:openerp-humanitarian-ngo/addons-backport

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review, no tests LGTM, thanks ! -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/addons-backport-improve_on_change-nbi/+merge/195007 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/addons-backport. -- Ma

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + no tests LGTM thanks -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde/+merge/203584 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing li

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi into lp:openerp-humanitarian-ngo

2014-02-06 Thread Joël Grand-Guillaume
Review: Approve code review + test Hi, This LGTM, as all the correction have been made here : https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_other_procurement_method-nbi/+merge/205123 So I suggest merging this one first in the trunk and then proposed the *-add-o

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Nicolas Bessi - Camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde/+merge/203584 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list: https

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1

2014-02-06 Thread Pedro Manuel Baeza
Review: Approve code review OK then, I don't see that instantiation on MP, so my question was by that. Regards. -- https://code.launchpad.net/~camptocamp/account-financial-tools/6.1-fix-1276998/+merge/205121 Your team Account Core Editors is subscribed to branch lp:account-financial-tools/6.1.

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1

2014-02-06 Thread Yannick Vaucher @ Camptocamp
I'm just using the self.logger which is instantiated in Currency_rate_update_service class. This fix is a simple fix to restore currency_rate_update which is broken. -- https://code.launchpad.net/~camptocamp/account-financial-tools/6.1-fix-1276998/+merge/205121 Your team Account Core Editors is

[Openerp-community-reviewer] [Bug 1077931] Re: 6.1 progress bar invoiced_rate wrong

2014-02-06 Thread Yann Papouin
_invoiced_rate must also be clamped to avoid a rate > 100%. nb: A clamp already exists in the sale module ** Also affects: ocb-addons Importance: Undecided Status: New ** Summary changed: - 6.1 progress bar invoiced_rate wrong + [6.1][7.0][trunk] purchase progress bar invoiced_rate wro

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe into lp:sale-wkfl

2014-02-06 Thread Romain Deheele - Camptocamp
Review: Approve code review and test Hello, Nice! LGTM. Romain -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe/+merge/197175 Your team Sale Core Editors is requested to review the proposed merge of lp:~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe into lp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1

2014-02-06 Thread Pedro Manuel Baeza
Review: Needs Fixing code review Why do you put self.logger? Usual practice is to declare one variable: logger = logging.get(self.__name__) And then use it. Regards. -- https://code.launchpad.net/~camptocamp/account-financial-tools/6.1-fix-1276998/+merge/205121 Your team Account Core Editors

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-move-draft-improvements-mdh into lp:account-financial-tools

2014-02-06 Thread noreply
The proposal to merge lp:~camptocamp/account-financial-tools/7.0-move-draft-improvements-mdh into lp:account-financial-tools has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-move-draft-improvements-mdh

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1

2014-02-06 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging lp:~camptocamp/account-financial-tools/6.1-fix-1276998 into lp:account-financial-tools/6.1. Requested reviews: Account Core Editors (account-core-editors) Related bugs: Bug #1276998 in Account - Financial Tools 6.1: "commit 107 in account-fi

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-983764-partner-task-procurement into lp:ocb-addons/6.1

2014-02-06 Thread Yann Papouin
Yann Papouin has proposed merging lp:~yann-papouin/ocb-addons/6.1-bug-983764-partner-task-procurement into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #983764 in OpenERP Community Backports (Addons): "partner not filled on task with project

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-move-draft-improvements-mdh into lp:account-financial-tools

2014-02-06 Thread Frederic Clementi - Camptocamp
Review: Approve functional It rocks. :) -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-move-draft-improvements-mdh/+merge/201359 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~o

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe into lp:sale-wkfl

2014-02-06 Thread Alexandre Fayolle - camptocamp
> Thanks Alexandre. > > There is some wrong author info on the first module. actually no. This code was copied from an old branch. I updated the copyright though. -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add_reorderable_lines-afe/+merge/197175 Your team Sale Core Editors is requ

[Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-02-06 Thread Matthieu Dietrich @ camptocamp
Matthieu Dietrich @ camptocamp has proposed merging lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management. Requested reviews: Contract Management Core Editors (contract-management-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/contract-mana

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-add-sale_stock_global_delivery_lead_time-afe into lp:sale-wkfl

2014-02-06 Thread Nicolas Bessi - Camptocamp
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale_stock_global_delivery_lead_time-afe/+merge/197205 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-server/6.1-bug-1029344-translation-sync-abstract-model into lp:ocb-server/6.1

2014-02-06 Thread Yann Papouin
Yann Papouin has proposed merging lp:~yann-papouin/ocb-server/6.1-bug-1029344-translation-sync-abstract-model into lp:ocb-server/6.1. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1029344 in OpenERP Community Backports (Server): "Synchronize translation terms

[Openerp-community-reviewer] [Bug 983764] Re: partner not filled on task with project_mrp

2014-02-06 Thread Yann Papouin
** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Changed in: ocb-addons/6.1 Assignee: (unassigned) => Yann Papoui

Re: [Openerp-community-reviewer] [Merge] lp:~yannick-buron/contract-management/contract-management into lp:contract-management

2014-02-06 Thread Pedro Manuel Baeza
Hi, Joël, I would say contributors section instead of author for your first point, doesn't it? Regards. -- https://code.launchpad.net/~yannick-buron/contract-management/contract-management/+merge/204718 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:contract-managem

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced into lp:stock-logistic-flows

2014-02-06 Thread Pedro Manuel Baeza
Thanks for the effort, Alexis!! Regards. -- https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced/+merge/205051 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-c

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/openerp-product-attributes/7.0-product_pricelist_fixed_price into lp:openerp-product-attributes

2014-02-06 Thread Pedro Manuel Baeza
Hi, Lionel, Indeed, you have to adjust all fields by XML-RPC, but that's the same flaw of all OpenERP objects (for example, on invoices, you don't get automatically filled all the account related fields when you write partner_id as if you were introducing it on web client). You have two option

[Openerp-community-reviewer] [Bug 1029344] Re: Synchronize translation terms crash when abstract models are used

2014-02-06 Thread Yann Papouin
** Also affects: ocb-server Importance: Undecided Status: New ** Also affects: ocb-server/6.1 Importance: Undecided Status: New ** Also affects: ocb-server/7.0 Importance: Undecided Status: New ** Changed in: ocb-server/6.1 Importance: Undecided => Medium ** Cha

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde into lp:openerp-humanitarian-ngo/purchase-wkfl

2014-02-06 Thread Nicolas Bessi - Camptocamp
Review: Needs Fixing Check on requisition id is missing -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-fix_copy_origin-rde/+merge/203584 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Maili

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced into lp:stock-logistic-flows

2014-02-06 Thread Alexis de Lattre
I see what you mean. It's a bit "heavy", but I don't see a better solution... i'll try to find time to implement this shortly. -- https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced/+merge/205051 Your team Stock and Logistic Core Editors is subscribed t

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/openerp-product-attributes/7.0-product_pricelist_fixed_price into lp:openerp-product-attributes

2014-02-06 Thread Lionel Sausin - Numérigraphe
Review: Needs Information Dear Pedro Manuel Baeza, Thanks for your proposal, it's simpler than I expected. Reading the code I understand that you're still using the "-100% + Price" trick, aren't you? What happens if on_change() is not executed (for example records are added through XML-RPC)? T

Re: [Openerp-community-reviewer] [Merge] lp:~yannick-buron/contract-management/contract-management into lp:contract-management

2014-02-06 Thread Joël Grand-Guillaume
Hi Ronald and Yannick, Ok, after coming back on this one, I agree with you Ronald. We should leave it as is, so fixes will be much easier to port ! So @Yannick, if you can just correct 1st and 4th point and it ok for me. Regards, Joël -- https://code.launchpad.net/~yannick-buron/contract-ma