[Openerp-community-reviewer] [Bug 1292358] [NEW] [OCB] mrp test needs updating after fixing stock move state in lp:1250053

2014-03-13 Thread Stefan Rijnhart (Therp)
Public bug reported: http://bazaar.launchpad.net/~ocb/ocb-addons/7.0/revision/10001 causes "AssertionError in Python code : Production order should be confirmed." in mrp/test/bom_with_service_type_product.yml The actual state is 'ready', which corresponds to the actual problem description for lp:

Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

2014-03-13 Thread Augustin Cisterne-Kaas - www.elico-corp.com
Would not web_polymorphic_many2one be a better name (more generic) ? -- https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620 Your team Web-Addons Core Editors is requested to review the proposed merge of lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addon

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit into lp:stock-logistic-flows

2014-03-13 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Needs Fixing code review l.17 the indentation here is off, please fix or remove as it looks redundant -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit/+merge/210599 Your team Stock and Logistic Core Editors is subscribed to branch lp:

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into lp:ocb-addons

2014-03-13 Thread Pedro Manuel Baeza
Review: Approve code review Thanks! -- https://code.launchpad.net/~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245/+merge/210926 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer

[Openerp-community-reviewer] [Bug 1292245] Re: account_budget has UnicodeEncodeError when raising except_osv

2014-03-13 Thread Sandy Carter (http://www.savoirfairelinux.com)
** Also affects: ocb-addons Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1292245 Title: account_budget

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into lp:ocb-addons

2014-03-13 Thread Sandy Carter (http://www.savoirfairelinux.com)
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1292245 in OpenERP Community Backports (Addons): "account_b

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe into lp:stock-logistic-warehouse

2014-03-13 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Needs Fixing grammar Grammar mistakes in the description l.11 instances should be plural This is useful for instance This is useful for instances l.12 comma after case In which case a possible workflow In which case, a possible workflow l.12 run on sentence, consider breaking into two

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name into lp:partner-contact-management

2014-03-13 Thread Sandy Carter (http://www.savoirfairelinux.com)
You have been requested to review the proposed merge of lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name into lp:partner-contact-management. For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/partner-

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe into lp:stock-logistic-warehouse

2014-03-13 Thread Pedro Manuel Baeza
Review: Approve code review Thank you very much for expand the description! Regards. -- https://code.launchpad.net/~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe/+merge/210859 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-ware

[Openerp-community-reviewer] [Bug 1181283] Re: [7.0] Wrong entry generated on expenses

2014-03-13 Thread Yannick Vaucher @ Camptocamp
** Changed in: ocb-addons/7.0 Status: In Progress => Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1181283 Title: [7.0] Wrong e

[Openerp-community-reviewer] [Merge] lp:~arthru/ocb-addons/fix-1181283 into lp:ocb-addons

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~arthru/ocb-addons/fix-1181283 into lp:ocb-addons has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~arthru/ocb-addons/fix-1181283/+merge/204510 -- https://code.launchpad.net/~arthru/ocb-addons/fix-1181283/+merge/20

Re: [Openerp-community-reviewer] [Merge] lp:~arthru/ocb-addons/fix-1181283 into lp:ocb-addons

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Disapprove https://code.launchpad.net/~camptocamp/ocb-addons/ocb-addons-hr_expense-tax_vre/+merge/196122 fix the issue. Please comment the other MP if you think anything is wrong. Or reopen the bug if you still experience the same issue -- https://code.launchpad.net/~arthru/ocb-addons/

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-addons-hr_expense-tax_vre into lp:ocb-addons

2014-03-13 Thread noreply
The proposal to merge lp:~camptocamp/ocb-addons/ocb-addons-hr_expense-tax_vre into lp:ocb-addons has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/ocb-addons-hr_expense-tax_vre/+merge/196122 -- https://code.launchpad.net/~c

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-addons-hr_expense-tax_vre into lp:ocb-addons

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/ocb-addons/ocb-addons-hr_expense-tax_vre into lp:ocb-addons has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/ocb-addons/ocb-addons-hr_expense-tax_vre/+merge/196122 -- https://code.launchpad.

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-addons-hr_expense-tax_vre into lp:ocb-addons

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-addons-hr_expense-tax_vre/+merge/196122 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community

Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-997642-fix-services-make-to-stock into lp:ocb-addons/6.1

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests LGTM -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-997642-fix-services-make-to-stock/+merge/203903 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-commun

[Openerp-community-reviewer] [Bug 1250053] Re: Internal stock move stuck at waiting for another move

2014-03-13 Thread Yannick Vaucher @ Camptocamp
** Changed in: ocb-addons/7.0 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1250053 Title: Internal st

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico into lp:account-invoicing

2014-03-13 Thread noreply
The proposal to merge lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico into lp:account-invoicing has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~agilebg/account-invoicing/7.0-bug-1287179-hurrinico/+merge/209207 -- https://code.launchpad

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico into lp:account-invoicing

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~agilebg/account-invoicing/7.0-bug-1287179-hurrinico into lp:account-invoicing has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~agilebg/account-invoicing/7.0-bug-1287179-hurrinico/+merge/209207 -- https://code.lau

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/lp1250053 into lp:ocb-addons

2014-03-13 Thread noreply
The proposal to merge lp:~therp-nl/ocb-addons/lp1250053 into lp:ocb-addons has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~therp-nl/ocb-addons/lp1250053/+merge/197404 -- https://code.launchpad.net/~therp-nl/ocb-addons/lp1250053/+merge/197404 Y

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/lp1250053 into lp:ocb-addons

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~therp-nl/ocb-addons/lp1250053 into lp:ocb-addons has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~therp-nl/ocb-addons/lp1250053/+merge/197404 -- https://code.launchpad.net/~therp-nl/ocb-addons/lp1250053/+merge/19

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/lp1250053 into lp:ocb-addons

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve Fix dupplicated for official addons LGTM Thanks -- https://code.launchpad.net/~therp-nl/ocb-addons/lp1250053/+merge/197404 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe into lp:stock-logistic-warehouse

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve Thanks LGTM -- https://code.launchpad.net/~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe/+merge/210859 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-warehouse. -- Mailing list: https://launchpad.net/~openerp-c

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe into lp:stock-logistic-warehouse

2014-03-13 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging lp:~camptocamp/stock-logistic-warehouse/7.0-improve_stock_location_ownership-afe into lp:stock-logistic-warehouse. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see: https://code.launchpad

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

2014-03-13 Thread Alexandre Fayolle - camptocamp
my most sincere apologies to Pedro and the rest of the community. I could see no objection myself, the MP was old and I felt the information had been provided, but I may have been to quick indeed. My intent was not to hijack the process. -- https://code.launchpad.net/~camptocamp/stock-logisti

Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

2014-03-13 Thread Augustin Cisterne-Kaas - www.elico-corp.com
Thanks, Don't forget to rename the module dependence web_polymorphic to web_many2one_polymorphic in the mail organizer __openerp__.py Regards -- https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620 Your team Web-Addons Core Editors is requested to review the propos

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde into lp:carriers-deliveries

2014-03-13 Thread noreply
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde into lp:carriers-deliveries has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde/+merge/

[Openerp-community-reviewer] [Bug 1252342] Re: [7.0] POS take an image of a wrong size

2014-03-13 Thread Andrei Levin
** Also affects: ocb-addons Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1252342 Title: [7.0] POS take

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

2014-03-13 Thread Guewen Baconnier @ Camptocamp
Twice the same image, here is the second one with the move details. http://postimg.org/image/k9bx94w17/ -- https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list:

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde into lp:carriers-deliveries

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde into lp:carriers-deliveries has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde/+

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

2014-03-13 Thread Guewen Baconnier @ Camptocamp
> Hi, Guewen, thanks for the clarification. Here in Spain that operation is > forbidden by law (because you need at least declare taxes for the amount). > > Regards. Interesting. For my curiosity, if you have a sale line with 100€ taxes included and you add a second line with a rebate of -100€

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname into lp:partner-contact-management

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests Thanks for the contrib, LGTM -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/user-firstname/+merge/210710 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list:

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

2014-03-13 Thread Pedro Manuel Baeza
Hi, Guewen, thank you very much for the explanation. Improved description will certainly help others like me to understand the purpose of the module. Regards. -- https://code.launchpad.net/~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi/+merge/196530 Your team Stock and Logistic Cor

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proper refered MP was in Romain's comment https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale_sourced_and_stock_ownership/+merge/194527 Wrong team was set I fixed the link -- https://code.launchpad.net/~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi/+merge/196530 Your

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

2014-03-13 Thread Guewen Baconnier @ Camptocamp
Pedro, I agree that it would have been better if the question was answered before the merge. Now, I'm sure there was an excellent reason why the existing field couldn't be used, even if I can't remember what it is; Joël thought about this module and I remember asking him the exact same question,

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse has been updated. Description changed to: [ADD] stock_location_ownership. See https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-add-sale_sourced_and_stock_ownership/+merge

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

2014-03-13 Thread Pedro Manuel Baeza
My information request was about the convenience of the module, but anyways, it's only an opinion. Please put an MP with the pot file, or better. Regards. -- https://code.launchpad.net/~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi/+merge/196530 Your team Stock and Logistic Core Ed

Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

2014-03-13 Thread Sylvain LE GAL (GRAP)
Thanks for the changes. I'll test the module again next week. Regards. -- https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620 Your team Web-Addons Core Editors is requested to review the proposed merge of lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-ad

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-warehouse/add-stock_ownership_nbi into lp:stock-logistic-warehouse

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve Well it kinda have the whole c2c approval, developped by Guewen proposed by Nicolas, approved by Romain, commited by Alexandre and authored Joël (ok perhaps there it bugged a little here ^^) If we do an other MP for the pot file will it be ok for you ? By the way I give my appr

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit into lp:stock-logistic-flows

2014-03-13 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit/+merge/210599 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit into lp:stock-logistic-flows

2014-03-13 Thread Alexandre Fayolle - camptocamp
LGTM -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit/+merge/210599 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : o

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit into lp:stock-logistic-flows

2014-03-13 Thread Pedro Manuel Baeza
Review: Approve code review OK, Yannick, Seems enough for me. Thank you. Regards. -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit/+merge/210599 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. --

Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

2014-03-13 Thread Augustin Cisterne-Kaas - www.elico-corp.com
Hi Sylvain, Thank you for your feedback. Indeed 'web_many2one_polymorphic' is more accurate. I found a fix using javascript but I am not sure it's the best solution. -- https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620 Your team Web-Addons Core Editors is reques

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit into lp:stock-logistic-flows

2014-03-13 Thread Yannick Vaucher @ Camptocamp
@Pedro, I don't think an option is a good idea. I think it is preferable to show the variant whenever it is defined. I added a condition on to hide the column if there are no variant in all products. -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-r

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/6.1-rights-attribute_set-1254609 into lp:openerp-product-attributes/6.1

2014-03-13 Thread Leonardo Pistone - camptocamp
Leonardo Pistone - camptocamp has proposed merging lp:~camptocamp/openerp-product-attributes/6.1-rights-attribute_set-1254609 into lp:openerp-product-attributes/6.1. Requested reviews: Product Core Editors (product-core-editors) Related bugs: Bug #1254609 in OpenERP Product Attributes: "base

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

2014-03-13 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Approve Thank you -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context/+merge/210761 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : o

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

2014-03-13 Thread Lionel Sausin - Numérigraphe
There isn't one because I don't expect the core team to accept this into a stable release. The proposal for trunk was left unmerged for ages. But you're right, I'll try again - maybe it's my lucky day? v6: https://code.launchpad.net/~numerigraphe-team/openobject-addons/6.0-stock-move-cancel-conte

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into lp:ocb-addons

2014-03-13 Thread Lionel Sausin - Numérigraphe
The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into lp:ocb-addons has been updated. Description changed to: This branch improves the report model "latest inventory date", by showing the latest Stock Move as well. This helps users isolate unused products that may de

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde into lp:carriers-deliveries

2014-03-13 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Approve code review, no test -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde/+merge/210760 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~openerp-commun

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_default_webkit-yvr into lp:carriers-deliveries

2014-03-13 Thread noreply
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_default_webkit-yvr into lp:carriers-deliveries has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_labe

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into lp:ocb-addons

2014-03-13 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1291986 in OpenERP Community Backports (Addons): ""Last Product Inventories" could show th

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

2014-03-13 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Needs Information Looks great! I'm just wondering where the MP into lp:openobject-addons/7.0 is. -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context/+merge/210761 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. --

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-fix_dropshipping_1287779-afe into lp:sale-wkfl

2014-03-13 Thread noreply
The proposal to merge lp:~camptocamp/sale-wkfl/7.0-fix_dropshipping_1287779-afe into lp:sale-wkfl has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-fix_dropshipping_1287779-afe/+merge/209499 -- https://code.launchpad.net

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-fix_dropshipping_1287779-afe into lp:sale-wkfl

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/sale-wkfl/7.0-fix_dropshipping_1287779-afe into lp:sale-wkfl has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-fix_dropshipping_1287779-afe/+merge/209499 -- https://code.launchp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-fix_dropshipping_1287779-afe into lp:sale-wkfl

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve LGTM thanks -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-fix_dropshipping_1287779-afe/+merge/209499 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-rev

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname into lp:partner-contact-management

2014-03-13 Thread Sandy Carter (http://www.savoirfairelinux.com)
You have been requested to review the proposed merge of lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname into lp:partner-contact-management. For more details, see: https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/user-firstname/+merge/210710

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394-env into lp:lp-community-utils

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394-env/+merge/210217 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : o

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394-env into lp:lp-community-utils

2014-03-13 Thread Yannick Vaucher @ Camptocamp
I guess you meant embraced instead of embarrassed ? :) -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394-env/+merge/210217 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~opene

[Openerp-community-reviewer] [Bug 1291986] Re: "Last Product Inventories" could show the last move's date too

2014-03-13 Thread Lionel Sausin - Numérigraphe
** Also affects: ocb-addons Importance: Undecided Status: New ** Changed in: ocb-addons Importance: Undecided => Wishlist ** Changed in: ocb-addons Assignee: (unassigned) => Lionel Sausin - Numérigraphe (lionel-sausin) -- You received this bug notification because you are a me

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/action-after-install-dbl into lp:carriers-deliveries

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve Nice addition LGTM -- https://code.launchpad.net/~akretion-team/carriers-deliveries/action-after-install-dbl/+merge/208956 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~openerp-community-review

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe/openobject-addons/7.0-stock-latest-move into lp:openobject-addons

2014-03-13 Thread Numérigraphe
Review: Resubmit I'm deleting this merge proposal for now - it will be submitted to trunk-wms instead. -- https://code.launchpad.net/~numerigraphe/openobject-addons/7.0-stock-latest-move/+merge/169797 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~num

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_default_webkit-yvr into lp:carriers-deliveries

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Ready to be merged -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_default_webkit-yvr/+merge/198050 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~openerp-community-re

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics_shop_logo-yvr into lp:carriers-deliveries

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Can someone merge this mp ? -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-add-delivery_carrier_label_postlogistics_shop_logo-yvr/+merge/196859 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~op

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into lp:carriers-deliveries/6.1

2014-03-13 Thread Pedro Manuel Baeza
Review: Approve code review LGTM -- https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde/+merge/210772 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries/6.1. -- Mailing list: https://launchpad.net/~openerp-com

Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

2014-03-13 Thread Sylvain LE GAL (GRAP)
Review: Needs Fixing code review, test Hi, Thanks for your MP. 2 little thinks : 1/ maybe it could be great to rename the module with the type of the field. Something like : 'web_many2one_polymorphic'. 2/ I tested your code with the mail_organizer module available on lp. In this module,if

[Openerp-community-reviewer] [Bug 930044] Re: Document: "lang" cannot be added to the dynamic context

2014-03-13 Thread Lionel Sausin - Numérigraphe
Heh, turns out my proposal was silently merged long ago and is in v7.0 . Move along... ** Changed in: openobject-addons Status: Confirmed => Fix Released ** No longer affects: ocb-addons -- You received this bug notification because you are a member of OpenERP Community Backports Team, w

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into lp:carriers-deliveries/6.1

2014-03-13 Thread Romain Deheele - Camptocamp
Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into lp:carriers-deliveries/6.1. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) Related bugs: Bug #1291916 in Carriers And Deliveries

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde into lp:carriers-deliveries

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests LGTM Thanks -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde/+merge/210760 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~op

[Openerp-community-reviewer] [Bug 930044] Re: Document: "lang" cannot be added to the dynamic context

2014-03-13 Thread Lionel Sausin - Numérigraphe
** Also affects: ocb-addons Importance: Undecided Status: New ** Changed in: ocb-addons Assignee: (unassigned) => Lionel Sausin - Numérigraphe (lionel-sausin) -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to

[Openerp-community-reviewer] [Bug 1281579] Re: Broken yml test in account_payment account_financial_report_webkit

2014-03-13 Thread Yannick Vaucher @ Camptocamp
** Changed in: account-financial-report Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1281579 Title: B

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi into lp:account-financial-report

2014-03-13 Thread noreply
The proposal to merge lp:~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi into lp:account-financial-report has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi/+merge/207309 --

[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi into lp:account-financial-report

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi into lp:account-financial-report has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1281579-sbi/+merge/207

[Openerp-community-reviewer] [Merge] lp:~bcim/account-financial-report/fix-account_financial_report_webkit-force-mako into lp:account-financial-report

2014-03-13 Thread noreply
The proposal to merge lp:~bcim/account-financial-report/fix-account_financial_report_webkit-force-mako into lp:account-financial-report has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~bcim/account-financial-report/fix-account_financial_report_

Re: [Openerp-community-reviewer] [Merge] lp:~bcim/account-financial-report/fix-account_financial_report_webkit-force-mako into lp:account-financial-report

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests -- https://code.launchpad.net/~bcim/account-financial-report/fix-account_financial_report_webkit-force-mako/+merge/200014 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~op

[Openerp-community-reviewer] [Merge] lp:~bcim/account-financial-report/fix-account_financial_report_webkit-force-mako into lp:account-financial-report

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~bcim/account-financial-report/fix-account_financial_report_webkit-force-mako into lp:account-financial-report has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~bcim/account-financial-report/fix-account_financial_r

[Openerp-community-reviewer] [Bug 1291903] [NEW] sale_stock: property_ids set on procurement.order

2014-03-13 Thread Alexandre Fayolle - camptocamp
Public bug reported: The fix for https://bugs.launchpad.net/openobject-addons/+bug/1083077 merge in ocb-addons at http://bazaar.launchpad.net/~ocb/ocb- addons/7.0/revision/9733 has an issue : the field which is added in the changeset is defined in mrp, which is not a dependency of sale_stock. As

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/70-improve-dispatch-jge into lp:stock-logistic-flows

2014-03-13 Thread Leonardo Pistone - camptocamp
Review: Approve code review LGTM, thanks -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/70-improve-dispatch-jge/+merge/210598 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-rev

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

2014-03-13 Thread Pedro Manuel Baeza
Review: Approve code review Thanks for the catch! -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context/+merge/210761 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-fix_1266277-afe into lp:stock-logistic-barcode

2014-03-13 Thread noreply
The proposal to merge lp:~camptocamp/stock-logistic-barcode/7.0-fix_1266277-afe into lp:stock-logistic-barcode has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1266277-afe/+merge/208562 -- https://code.

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

2014-03-13 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1291874 in OpenERP Community Backports (Addons): "Method stock_move.action_cancel

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde into lp:carriers-deliveries

2014-03-13 Thread Pedro Manuel Baeza
Review: Approve code review Thanks for the migration. Regards. -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde/+merge/210760 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://lau

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

2014-03-13 Thread Pedro Manuel Baeza
Review: Approve code review Hi, Guewen, thanks for the clarification. Here in Spain that operation is forbidden by law (because you need at least declare taxes for the amount). Regards. -- https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215 Your team

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-fix_1266277-afe into lp:stock-logistic-barcode

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/stock-logistic-barcode/7.0-fix_1266277-afe into lp:stock-logistic-barcode has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1266277-afe/+merge/208562 -- https:/

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

2014-03-13 Thread Lionel Sausin - Numérigraphe
The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context/+merge/210761 --

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

2014-03-13 Thread Lionel Sausin - Numérigraphe
This contains unwanted changes, I'll resubmit a cleaner branch. Sorry about that. -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context/+merge/210761 Your team OpenERP Community Backports Team is requested to review the proposed merge of lp:~numerigraphe-team/o

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

2014-03-13 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons. Requested reviews: OpenERP Community Backports Team (ocb) Related bugs: Bug #1291874 in OpenERP Community Backports (Addons): "Method stock_move.action_cancel

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde into lp:carriers-deliveries

2014-03-13 Thread Romain Deheele - Camptocamp
Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/carriers-deliveries/7.0-base_delivery_carrier_files-rde into lp:carriers-deliveries. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/c

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking-dispatch-fix-page-break-tag into lp:stock-logistic-flows

2014-03-13 Thread noreply
The proposal to merge lp:~camptocamp/stock-logistic-flows/7.0-picking-dispatch-fix-page-break-tag into lp:stock-logistic-flows has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking-dispatch-fix-page-break-

[Openerp-community-reviewer] [Bug 1291874] [NEW] Method stock_move.action_cancel() loses context

2014-03-13 Thread Lionel Sausin - Numérigraphe
Public bug reported: In versions up to trunk and trunk-wms, stock_move.action_cancel() lacks a few "context" arguments when it calls the ORM. They are not necessary for the standard addons, but would make it possible to use the context in custom modules. ** Affects: ocb-addons Importance: L

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

2014-03-13 Thread Vincent Renaville@camptocamp
Review: Approve LGTM -- https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/7.0-invoice-webkit-hide-identical-ref into lp:account-invoice-report

2014-03-13 Thread noreply
The proposal to merge lp:~camptocamp/account-invoice-report/7.0-invoice-webkit-hide-identical-ref into lp:account-invoice-report has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~camptocamp/account-invoice-report/7.0-invoice-webkit-hide-identica

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/7.0-invoice-webkit-hide-identical-ref into lp:account-invoice-report

2014-03-13 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/account-invoice-report/7.0-invoice-webkit-hide-identical-ref into lp:account-invoice-report has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/account-invoice-report/7.0-invoice-webkit-hide-id

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review LGTM -- https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : opene

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

2014-03-13 Thread Yannick Vaucher @ Camptocamp
Pedro, This can be the case when a customer order a product and has a reduction that makes it at 0. The Sale Order will generate an invoice even if the price is 0. -- https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215 Your team Account Core Editors i

[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/web-addons/web_export_view__fr_translation into lp:web-addons

2014-03-13 Thread noreply
The proposal to merge lp:~sylvain-legal/web-addons/web_export_view__fr_translation into lp:web-addons has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~sylvain-legal/web-addons/web_export_view__fr_translation/+merge/207009 -- https://code.l

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/web-addons/web_export_view__fr_translation into lp:web-addons

2014-03-13 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review Thanks Sylvain. -- https://code.launchpad.net/~sylvain-legal/web-addons/web_export_view__fr_translation/+merge/207009 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl

2014-03-13 Thread Lorenzo Battistini - Agile BG
Review: Needs Information Hello Alexandre, line 223: if vals['type'] == 'service', should we run _compute_procurement_vals anyway? lines 585 and 597: as 'product_procurement_type_dropshipping' depends on 'product_procurement_type', why do the write and create methods call the '_compute_procur