quite a lot a code, and no test... :-(
Remarks:
* line 353 (in compute_delay_from_partial_rec): it would be nicer to move
reference_line = line in the else clause of the if / elif statement (makes it
clear that reference_line has avalue in all cases)
* line 381 and 383 (in get_compute_method)
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-1287072/+merge/209183
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve code review, no test
LGTM
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-credit-control-scenarios-nbi/+merge/209050
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Approve code review, tests
LGTM
--
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293582-afe/+merge/211358
Your team Product Core Editors is subscribed to branch lp:product-kitting.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Hello,
The parameter/fallback solution seems reasonable assuming that period parameter
is not mandatory.
For me you can update the MP with that solution.
Also as the change will alter data structure the revision number of the module
must be increased in MP.
I'm putting the MP in work in
Review: Approve
LGTM
--
https://code.launchpad.net/~openerp-community/server-env-tools/7.0-modules-from-openobject-extension/+merge/200744
Your team Server Environment And Tools Core Editors is requested to review the
proposed merge of
Review: Approve code review, no test
LGTM, Thanks
--
https://code.launchpad.net/~camptocamp/account-financial-tools/credit_control_report_improvement_vre/+merge/201920
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list:
Review: Needs Fixing
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Stefan Rijnhart (Therp) has proposed merging
lp:~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views into
lp:ocb-web.
Requested reviews:
OpenERP Community Backports Team (ocb)
Related bugs:
Bug #1293085 in OpenERP Community Backports (Web): [7.0] Binary field widget
in
Review: Needs Information
Hi Nicolas, did you not want to take Olivier's suggestion of refactoring out
the code that performs the encryption?
--
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
Your team OpenERP Community Backports Team is subscribed to
Review: Approve
Let's hope the change gets adopted in upstream 8.0. At that point, the
truncation will only happen when reverting back from OCB 7.0 to OpenERP 7.0. At
least in this particular case the impact of the truncation will be nil.
The custom module approach does not work for people who
I've been told it's better to use tools.ustr()
--
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245/+merge/210926
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
The proposal to merge
lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into
lp:ocb-addons has been updated.
Status: Needs review = Work in progress
For more details, see:
Sandy Carter (http://www.savoirfairelinux.com) has proposed merging
lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into
lp:ocb-addons.
Requested reviews:
Holger Brunn (Therp) (hbrunn): code review
Pedro Manuel Baeza (pedro.baeza): code review
Related bugs:
Bug
Hello,
Fixes done and basic tests added
--
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Review: Approve tested, no-review
Tested and approved.
About the first question, I don't think you can do better : even OpenERP
reloads the full page after changing it in your own preferences.
Can't help for the second question... sorry...
Just a littel improvement : don't display your widget
Review: Needs Fixing
the tests are red here
TEST test_70 openerp.tools.yaml_import: In order to test the PDF General
Ledger webkit wizard I will print report with default setting
ERROR test_70 openerp.tools.yaml_import: (u'No period found', '')
2014-03-18 16:14:12,556 23281 ERROR test_70
** Also affects: ocb-web
Importance: Undecided
Status: New
** Also affects: ocb-web/6.1
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports
Alexandre, I think the fix for this one is in addons demo data (lp:1281579).
Merged on OCB already.
--
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is subscribed to branch
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/carriers-deliveries/7.0-needed_changes_to_fit_with_stock_picking_v7_changes-rde
into lp:carriers-deliveries.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
Philippe Latouche - Savoir-faire Linux has proposed merging
lp:~savoirfairelinux-openerp/sale-wkfl/sale_dropshipping_translation into
lp:sale-wkfl.
Requested reviews:
OpenERP French translation reviewers (openerp-i18n-french-reviewers)
For more details, see:
Review: Approve
LGTM
--
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
Review: Approve code review
Thanks for including also pot file. Files are correct, but I cannot approve
french translation, due to I don't speak this language, but this is something
minor, because with this MP, translations will be available on Launchpad and
anyone could change any incorrect
23 matches
Mail list logo