Diana Rodríguez Martínez has proposed merging
lp:~dr.clearcorp/partner-contact-management/7.0-review_partner_merge into
lp:partner-contact-management.
Requested reviews:
Partner and Contact Core Editors (partner-contact-core-editors)
Related bugs:
Bug #1329972 in Partner and Contact Manageme
Review: Approve code and test
We have been testing it and is working flawlessly...
--
https://code.launchpad.net/~aristobulo/web-addons/web_fields_masks/+merge/219084
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-commu
Pedro Manuel Baeza has proposed merging
lp:~pedro.baeza/ocb-addons/6.1-product-imp-units into lp:ocb-addons/6.1.
Requested reviews:
OpenERP Community Backports (ocb)
For more details, see:
https://code.launchpad.net/~pedro.baeza/ocb-addons/6.1-product-imp-units/+merge/223111
[IMP] product: Ad
Thanks Nicolas,
I made changes accordingly.
I add a condition : only assigned pickings are selected.
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribe
fixed except: -> except Exception:
--
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-la
Review: Needs Fixing code review
Hello,
Just little things as:
- I see deprecated attribute type on form views (l.869, 906)
- l.2221: s/Euro policy level/Usd policy level
- l.1310, 1311: '==' instead of '='
Otherwise, few little typos:
- l.1709: s/writen/written
- l.1709: s/fields/field
- l.219
Review: Approve
LGTM, taking in account that previous comment on source MP are still valid.
--
https://code.launchpad.net/~camptocamp/account-financial-report/7.0-sync-afr_webkit-with-report_webkit/+merge/223058
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/account-financial-report/7.0-fix-1319109 into
lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
For more details, see:
https://code.launchpad.net/~camptocamp/account-financi
Review: Approve
It's a pragmatic approval for now because it's already a working improvement.
See
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058/comments/534749
--
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_floor_price/+me
Review: Approve
I tend to agree with Pedro.
But I would say, given that Yannick refactored several modules to use this
interface and that it seems working.
I would say, let's approve that 1st change and get the stuff working. Next, if
somebody finds it useful to kill that module and refactor d
Hi
I am asking myself about adding an object "storage.configuration" and a field
"storing_configuration_id" on the model "ir.model.fields". The idea will to use
a default storing configuration for every field (on file sytem for exemple) but
after we will be able to customise on every field from
https://wiki.python.org/moin/TimeComplexity
--
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list:
thanks for the precision.
--
https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1322191-db_maxconn/+merge/220666
Your team OpenERP Community Backports is subscribed to branch lp:ocb-server.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : opener
Review: Needs Fixing
Need fixing.
Set has a better performance than list and it should avoid duplicate.
Please see inline comment
Diff comments:
> === added directory 'picking_dispatch_wave'
> === added file 'picking_dispatch_wave/__init__.py'
> --- picking_dispatch_wave/__init__.py 1970-01-01 0
Review: Needs Fixing code review
Hello Romain and Alexandre,
diff comments + some PEP8 remarks
product_procurement_type/product.py:27:1: E302 expected 2 blank lines, found 1
product_procurement_type/product.py:34:1: E302 expected 2 blank lines, found 1
product_procurement_type/product.py:99:13:
Thanks for review.
What I understand by reading the code is that this function has 4 parts.
First it removes closed or leaked connections - none of our business here
Then it tries to re-use an iddle connection previously opened for the same
database
If no iddle connection is found for this databa
Review: Approve code review
LGTM. Thanks.
Regards.
--
https://code.launchpad.net/~akretion-team/account-financial-tools/7-account-journal-sale-refund-link-cde/+merge/223037
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: htt
Chafique DELLI has proposed merging
lp:~akretion-team/account-financial-tools/7-account-journal-sale-refund-link-cde
into lp:account-financial-tools.
Commit message:
add module 'account_journal_sale_refund_link'
Requested reviews:
Akretion Team (akretion-team)
For more details, see:
https://
Hi, Pedro.
I'm sorry, I did not pay attention, actually I had a second module that was not
merged.
That's why I cancel my MP to correct and propose again.
Regards.
--
https://code.launchpad.net/~akretion-team/account-financial-tools/7-account-journal-sale-refund-link-cde/+merge/223022
Your team
Review: Needs Fixing code review
Hi, Chaffique. Thanks for your contribution. I think it's the first you make.
Let's hope this one is the first of a lot.
In the MP, you put two modules, the one you refer in the MP description, and
account_tax_update. Please remove this second one from the MP.
Review: Approve code review, sometest without being able to exercise that code
LGTM : the connection must be closed.
But
I cannot find by reading the code a case where this branch is executed (i.e. a
logical path in which we get len(self._connections) >= self._maxconn so I'm
wondering if we a
Chafique DELLI has proposed merging
lp:~akretion-team/account-financial-tools/7-account-journal-sale-refund-link-cde
into lp:account-financial-tools.
Commit message:
add module account_journal_sale_refund_link
Requested reviews:
Akretion Team (akretion-team)
For more details, see:
https://c
Review: Approve code review, test
LGTM, thanks for the fix
--
https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order/+merge/209708
Your team OpenERP Community Backports is subscribed to branch lp:ocb-server.
--
Mailing list: https://launchpad.net/~openerp-comm
23 matches
Mail list logo
