Review: Disapprove
Moved to https://github.com/OCA/hr-timesheet/pull/7
I prefer do not delete the proposal to keep all the associated comments that
have been made.
--
https://code.launchpad.net/~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message/+merge/225275
Your team OpenE
Review: Disapprove
Moved to https://github.com/OCA/hr-timesheet/pull/7
I prefer do not delete the proposal to keep all the associated comments that
have been made.
--
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone/+merge/221374
Your team OpenERP Commu
Review: Disapprove
Moved to https://github.com/OCA/hr-timesheet/pull/7
I prefer do not delete the proposal to keep all the associated comments that
have been made.
--
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined/+merge/221250
Your team Open
Review: Disapprove
Moved to https://github.com/OCA/hr-timesheet/pull/7
I prefer do not delete the proposal to keep all the associated comments that
have been made.
--
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/+merge/221278
Your team OpenERP Community Rev
The proposal to merge
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into
lp:hr-timesheet has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone/+merge
The proposal to merge
lp:~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message
into lp:hr-timesheet has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_differenc
The proposal to merge
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into
lp:hr-timesheet has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/+merge/221278
--
http
The proposal to merge
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined
into lp:hr-timesheet has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-
Alexandre,
you can find the related PR on github here:
https://github.com/OCA/stock-logistics-workflow/pull/2
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock
Alexandre,
here you can find the related PR on github:
https://github.com/OCA/stock-logistics-workflow/pull/1
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_picking_line_description_7/+merge/219800
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-lo
Alexandre, I'll do it asap.
Cheers.
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list: https://launchpad.net/~openerp-communit
Hi Alexandre,
sure, I'll migrate it to github asap.
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_picking_line_description_7/+merge/219800
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list: https://launchpad.net/~ope
Hi Yannick,
I migrated it to https://github.com/OCA/carrier-delivery/pull/4
Cheers.
--
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is subscribed to branch
lp:~stock-logistic-core-editors/
Alex Comba - Agile BG has proposed merging
lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl.
Requested reviews:
Pedro Manuel Baeza (pedro.baeza): code review
For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/225197
The proposal to merge lp:~agilebg/purchase-wkfl/imp_product_by_supplier into
lp:purchase-wkfl has been updated.
Description changed to:
adding funciotnalities from product_search_reference.
Now it's possible to search products everywhere by supplier code
In the rev. 34 I merged
https://code.la
Ok, no problem!
I will migrate it to github asap. Thank you.
--
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is subscribed to branch
lp:~stock-logistic-core-editors/carriers-deliveries/7.0.
Hi Yannick,
does the migration still needed even if the MP has 3 approves?
I remain awaiting your confirmation before to proceed it. Thank you in advance.
--
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic
Alex Comba - Agile BG has proposed merging
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into
lp:sale-wkfl.
Commit message:
[ADD] module 'sale_line_quantity_properties_based'
Requested reviews:
Lorenzo Battistini - Agile BG (elbati)
Sale Core Editors
Lorenzo,
please have a look at my last commit, now it should be ok.
Cheers.
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-flows.
--
Mailing list
Hi Pedro,
thank you for your review and for your precious hints!
I made the changes as you suggested us. In addition I fixed a bug in rev.58.
Cheers.
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472
Your team Stock and Logistic Core
Review: Approve code review, no test
--
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is subscribed to branch
lp:stock-logistic-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Review: Approve code review
--
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:sale-reports.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-communi
Review: Approve code review
--
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Alex Comba - Agile BG has proposed merging
lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into
lp:account-invoice-report.
Commit message:
[FIX] invoice_webkit bugs: #1208389, #1231329 and #1277024
Requested reviews:
Vincent Renaville@camptocamp (vrenaville-c2c
Alex Comba - Agile BG has proposed merging
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into
lp:sale-wkfl.
Commit message:
[ADD] module 'sale_line_quantity_properties_based'
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details,
Review: Approve
--
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into
lp:purchase-report.
Alex Comba - Agile BG has proposed merging
lp:~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7 into
lp:account-invoicing.
Commit message:
[ADD] module invoice_line_no_picking_name
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https
The proposal to merge
lp:~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7 into
lp:account-invoicing has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7/+
Alex Comba - Agile BG has proposed merging
lp:~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7 into
lp:account-invoicing.
Commit message:
[ADD] module invoice_line_no_picking_name
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https
Alex Comba - Agile BG has proposed merging
lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7 into
lp:stock-logistic-flows.
Commit message:
[ADD] module picking_line_description
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details
Alex Comba - Agile BG has proposed merging
lp:~agilebg/openerp-manufacturing/adding_mrp_production_properties_7 into
lp:openerp-manufacturing.
Commit message:
[ADD] module mrp_production_properties
Requested reviews:
Manufacture Core Editors (manufacture-core-editors)
For more details, see
Thanks Sébastien for your approval.
--
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is subscribed to branch
lp:carriers-deliveries.
--
Mailing list: https://launchpad.net/~openerp-communit
Yannick wrote:
> Have you tried word-wrap: break-word and table-layout: fixed ?
Hi Yannick,
yes I tried, but it doesn't seem to work.
> I merged Vincent MP
Thank you.
> so it seems the last bug to resolve is
> https://bugs.launchpad.net/account-invoice-report/+bug/1277024
Yes, it's right.
--
The proposal to merge
lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into
lp:account-invoice-report has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit
Hi Pedro,
thank you for your review, my comments are in line.
> Contributors are put on 'contributors' key in manifest file as a list, not in
> description.
As far as I can see here
https://doc.openerp.com/contribute/05_developing_modules/#modules-description
it's written differently.
> I pre
Lorenzo,
following are listed the reasons:
'images': this key doesn't compare in
https://doc.openerp.com/trunk/server/03_module_dev_01/#manifest-file-openerp-py:
also comparing https://www.openerp.com/apps/7.0/product_by_supplier/ and
https://www.openerp.com/apps/7.0/product_supplier_info/ I n
Alex Comba - Agile BG has proposed merging
lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl.
Commit message:
[FIX] bug #1312024
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0
Alex Comba - Agile BG has proposed merging
lp:~agilebg/openerp-product-attributes/adding_product_supplier_info_7 into
lp:openerp-product-attributes.
Commit message:
[ADD] module product_supplier_info
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
https
Thanks for the tip about "Resubmit proposal", Pedro.
Cheers.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~opener
Pedro and Lorenzo,
FYI, after your approve, I still added the file icon.png (ver. #49).
Cheers.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailin
Hi Pedro,
now it should be ok, please have a look at it, thank you.
Cheers.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launc
Thanks Lorenzo,
now https://github.com/nbessi/openerp-conventions doesn't show anymore the O600
Warning.
Cheers.
--
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is requested to review the
> when 'sale' e 'sale_stock
Pedro, 'e' stands for 'and', sorry ;-)
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.
--
Mailing list: https://launchpad.net/~
Hi, Pedro, thanks a lot for your review.
I made the changes as you suggested, please have a look at them.
About:
> Don't you think that it's convenient to copy incoterm (if any) from sale
> order to picking?
This module depends on 'stock_invoice_picking' and has been designed on purpose
when '
Alex Comba - Agile BG has proposed merging
lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into
lp:account-invoicing.
Commit message:
[ADD] module stock_invoice_picking_incoterm
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https
Alex Comba - Agile BG has proposed merging
lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into
lp:carriers-deliveries.
Commit message:
[ADD] module delivery_optional_invoice_line
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/openerp-mrp-reports/7.0-add_serpentcs_mrp_webkit-afe/+merge/209039
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of
lp:~camptocamp/openerp-mrp-reports/7.0-add_serpentcs_mr
Yannick,
you are right, we had not taken into consideration that type of problem related
to formatted_note.
However, we still have to fix these two bugs:
https://bugs.launchpad.net/account-invoice-report/+bug/1208389 [1]
https://bugs.launchpad.net/account-invoice-report/+bug/1277024 [2]
[1] is
Lorenzo, my new commit should have fixed, please have a look at it.
Thank you.
--
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
-
The proposal to merge
lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into
lp:account-invoice-report has been updated.
Description changed to:
Merge proposal to fix the following bugs:
https://bugs.launchpad.net/account-invoice-report/+bug/1208389
https://bugs.launch
Alex Comba - Agile BG has proposed merging
lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into
lp:account-invoice-report.
Commit message:
[FIX] invoice_webkit bugs: #1208389, #1231329 and #1277024
Requested reviews:
Account Core Editors (account-core-editors
Alex Comba - Agile BG has proposed merging
lp:~agilebg/openerp-icm/7.0_fix_sale_commission into lp:openerp-icm.
Requested reviews:
openerp-icm (openerp-icm)
Related bugs:
Bug #1277110 in openerp-icm: "Error while trying to install sale_commission"
https://bugs.launchpad.net/o
Ok, I've just seen the corresponding merge.
Thanks, Pedro.
--
https://code.launchpad.net/~agilebg/account-financial-report/fix_account_move_line_report_xls/+merge/204500
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list: https://launchpa
Alex Comba - Agile BG has proposed merging
lp:~agilebg/account-financial-report/fix_account_move_line_report_xls into
lp:account-financial-report.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
Related bugs:
Bug #1275730 in Account - Financial Report
Lorenzo, now it should be ok.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_invoice_line_description_7/+merge/202407
Your team Account Core Editors is requested to review the proposed merge of
lp:~agilebg/account-invoicing/adding_invoice_line_description_7 into
lp:account-invoi
Lorenzo, I've just committed a fix. Please have a look at it.
--
https://code.launchpad.net/~agilebg/account-invoicing/adding_invoice_line_description_7/+merge/202407
Your team Account Core Editors is requested to review the proposed merge of
lp:~agilebg/account-invoicing/adding_invoice_line_desc
Alex Comba - Agile BG has proposed merging
lp:~agilebg/account-invoicing/adding_invoice_line_description_7 into
lp:account-invoicing.
Commit message:
[ADD] module invoice_line_description
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https
Review: Approve code review, no test
--
https://code.launchpad.net/~agilebg/account-invoicing/7.0-add_account_invoice_template/+merge/194733
Your team Account Core Editors is requested to review the proposed merge of
lp:~agilebg/account-invoicing/7.0-add_account_invoice_template into
lp:accoun
Review: Approve code review, no test
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-rights-attribute_set-1254609/+merge/196481
Your team Product Core Editors is requested to review the proposed merge of
lp:~camptocamp/openerp-product-attributes/7.0-rights-attribute_set
Review: Approve
LGTM
--
https://code.launchpad.net/~agilebg/ocb-addons/7.0-bug-1172149-elbati/+merge/195407
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-revie
Hi, Pedro, thank you for your review :)
Please have a look at my new commits, do they satisfy your needs fixing?
Cheers
--
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_description_7/+merge/190600
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.
--
Mailing lis
Alex Comba - Agile BG has proposed merging
lp:~agilebg/sale-wkfl/adding_sale_line_description_7 into lp:sale-wkfl.
Commit message:
[ADD] module sale_line_description
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/sale-wkfl
62 matches
Mail list logo
