Well... product_serial will have to be largely re-written for v8, given all the
big changes in stock management. If the modules in v7.0 stay on LP, we could
keep this branch here.
--
https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-product_serial-plus-plus/+merge/195144
Your
Review: Approve code review and test
Alexandre, could you replay my commit revno 249 in the branch
lp:~akretion-team/openerp-product-attributes/70-update-and-fix-product-gtin ;
it's a small code simplification.
--
Review: Approve code review and test
BTW, for those who want to make EAN8 work in the POS, here is the patch for
odoo master :
http://people.via.ecp.fr/~alexis/ean8-pos-works.diff
--
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe/+merge/222760
Your
Alexis de Lattre has proposed merging
lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into
lp:partner-contact-management.
Requested reviews:
Partner and Contact Core Editors (partner-contact-core-editors)
For more details, see:
https://code.launchpad.net/~akretion
@Holger
I had a quick look at your code. Let's try to look at it together tomorrow or
Friday to see what's common, what's different, and see if we can enhance the
partner_relation module with some ideas from your module.
--
No problem ; I'm in Louvain la neuve until Friday afternoon.
--
https://code.launchpad.net/~akretion-team/partner-contact-management/add-partner_relation/+merge/220726
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
I won't do a bug report on the official branch myself and a new MP because it
will certainly be ignored and I don't have motivation nor time (cf
https://lists.launchpad.net/banking-addons-drivers/msg00053.html). I did this
bug report and MP on OCB because other members of the banking-addons
This MP fixes the bug... but I still get a crash when I try to update a partner
and add a SIREN + NIC. On a recent ocb 7.0 with an up-to-date
lp:account-financial-tools merged with
lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde,
I get this crash :
Server
The bug is in the invalidation function _get_partner_change in company.py : the
invalidation function should be :
def _get_partner_change(self, cr, uid, ids, context=None):
return self.pool['res.company'].search(
cr, uid, [('partner_id', 'in', ids)], context=context)
Review: Approve code review and test
Thanks Yannick for applying the fix. I have tested the new branch and it works
well.
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090
Your team OpenERP Community Reviewer/Maintainer is
Alexis de Lattre has proposed merging
lp:~akretion-team/partner-contact-management/add-partner_relation into
lp:partner-contact-management.
Requested reviews:
Partner and Contact Core Editors (partner-contact-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team
Alexis de Lattre has proposed merging
lp:~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into
lp:hr-timesheet.
Requested reviews:
HR Core Editors (hr-core-editors)
Related bugs:
Bug #1316456 in HR - Timesheet Management: hr_timesheet_task : can't save
new task : Analytic
Alexis de Lattre has proposed merging
lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into
lp:account-financial-report/6.1.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
Related bugs:
Bug #1274194 in Account - Financial Report: Wrong
Just adding a small comment to say that Raphaël Valyi discovered a bug when
doing a -u crm_claim_rma with that branch (it breaks on the duplicate
constraint). We started digging to find a solution, but we didn't had time to
implement it yet.
--
OK, let's go and merge it in the main branch now :)
--
https://code.launchpad.net/~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi/+merge/216451
Your team Account Core Editors is subscribed to branch lp:account-analytic.
--
Mailing list:
Review: Approve code review and tests
Nice update. Thank you Stefan.
I am pushing to you a branch with pep8 stuff and the additional of the field in
the tree view (and not just form view).
--
There it is :
https://code.launchpad.net/~akretion-team/account-analytic/account-analytic-required-pep8/+merge/216497
--
https://code.launchpad.net/~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi/+merge/216451
Your team Account Core Editors is subscribed to branch
Alexis de Lattre has proposed merging
lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma with
lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup as a prerequisite.
Requested reviews:
OpenERP RMA (openerprma)
For more details, see:
https://code.launchpad.net
@Nicolas:
I confirm that it returns 404 if you try to download a wrong country.
I have taken into account your other remarks in my last commits (unless the
tests ; I don't have experience in this). I am not sure I fully understand the
benefit of the FOR UPDATE NOWAIT in this particular case...
@Nicolas
As I said in my comment, I think that it's better for the module
base_location_geonames_import to sit right next to the base_location
module, so that it's easier to find for users of the base_location module. We
could even imagine that the wizard that is provided by
Alexis de Lattre has proposed merging
lp:~akretion-team/partner-contact-management/base-location-geonames-import into
lp:partner-contact-management.
Requested reviews:
Partner and Contact Core Editors (partner-contact-core-editors)
For more details, see:
https://code.launchpad.net/~akretion
I see that this module got merged without modification, and none of the points
that I raise in my review were addressed, which is a bit surprising.
For example, the point 3 that I raised was :
on the invoice line, you add a field 'displayed_lot_id' but you don't use it
anywhere. What is this
I confirm that the addition of
field name=context{'default_state': 'open'}/field
in crm/wizard/crm_phonecall_to_phonecall_view.xml
fixes the bug.
The other changes are not related to the bug.
--
https://code.launchpad.net/~jeffery9/ocb-addons/ocb-addons/+merge/193883
Your team OpenERP Community
@Alexandre
Thanks for your review.
You are right, the fact that I don't call super() on
_create_pickings_and_procurements() in the module product_serial_sale_stock is
a big problem and I am aware of that. But, unfortunately, I didn't find a
solution that includes calling super(). If you think
Alexis de Lattre has proposed merging
lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/account-closing/70-forecast-prepaid/+merge
Alexis de Lattre has proposed merging
lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
For more details, see:
https://code.launchpad.net/~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank/+merge
@Yannick:
As I said, this MP is a first step towards a split ; as you can see, it
introduce 2 new modules : product_serial_sale_stock and
product_serial_purchase. I am about to do an MP on lp:openerp-manufacturing for
product_serial_mrp.
BUT I didn't say that i'll do all the work for the
Review: Approve code review and tests
Thanks Alexandre for the MP and the additionnal test.
--
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1281687-afe/+merge/207116
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list:
I see what you mean. It's a bit heavy, but I don't see a better solution...
i'll try to find time to implement this shortly.
--
https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced/+merge/205051
Your team Stock and Logistic Core Editors is subscribed to
@Pedro
I have made the implementation: it works well, but one may consider that it's
too much code for a small detail...
By the way, we also had a problem with the view of invoices : I had put
Delivery Orders for the tab of customer invoices... but, on a customer
refund, it should be Incoming
@Pedro:
You are right, it doesn't select the right invoice view for returns. If you
have a better idea, please tell me.
--
https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced/+merge/205051
Your team Stock and Logistic Core Editors is subscribed to
Alexis de Lattre has proposed merging
lp:~akretion-team/stock-logistic-flows/70-picking-priority-small-enhancements
into lp:stock-logistic-flows.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team
Public bug reported:
I just found a regression in OCB : the following bug is present in an
up-to-date OCB 7.0 environnement, but it is not present in an up-to-date
official environnement ! Here are the steps to reproduce the problem :
1) Get an up-to-date OCB 7.0 environnement (server, web,
Review: Approve tests only
I confirm that this MP solves the bug Crash when clicking on Split in Serial
Numbers https://bugs.launchpad.net/ocb-addons/+bug/1271139
So this patch is now in production :)
--
@Luc
I am surprised that your customer base never asked for analytic account in the
journal export. Most of my customers use analytic accounting and your module
account_journal_report_xls export is quite convenient to export journals to
another accounting software (for the customers who have
Alexis de Lattre has proposed merging
lp:~akretion-team/sale-wkfl/70-sale-validity-enhanced into lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/sale-wkfl/70-sale-validity-enhanced/+merge/201762
Review: Approve code review
LGTM. Thanks Luc for this new MP.
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/update-7.0-account_move_line_report_xls/+merge/200990
Your team Account Report Core Editors is requested to review the proposed merge
of
Alexis de Lattre has proposed merging
lp:~akretion-team/purchase-wkfl/70-add-purchase_fiscal_position_update into
lp:purchase-wkfl.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/purchase-wkfl/70-add
@Alexandre :
Thanks for the merge... but it doesn't contain the new list of default fields
we decided above in the function _report_xls_fields() in account_move_line.py.
Could you update it ?
--
@Luc
I approve your proposal for the new list of default fields !
--
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report.
--
Mailing list:
Just a quick note about what I discovered while trying to backport the module
to OpenERP 6.1 : the ORM function resolve_2many_commands exists in OpenERP 6.1
under a different name : resolve_o2m_commands_to_record_dicts
But, unfortunately, when trying to use it, I often get :
File
Alexis de Lattre has proposed merging
lp:~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update into
lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update
@Graeme
I agree with your remarks about the fact that a fiscal position is not
dependant on a product. But, as you say, implementing it without relying on the
product is not really possible, because if you already had a fiscal position
and you change to another fiscal position, that you can't
Alexis de Lattre has proposed merging
lp:~akretion-team/account-financial-tools/70-reversal-fix-improve into
lp:account-financial-tools.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/account-financial-tools/70
Thanks for all these comments !
I have started to implement the on_change approch, cf the code in this branch :
lp:~akretion-team/account-invoicing/70-invoice_fiscal_position_update-onchange
But, during the implementation, I have been confronted to the following problem
:
In the code of the
@Graeme
Thanks for pointing me to resolve_2many_commands. I managed to make the
on_change work in the interface (the tax and account fields are properly
updated), but I get a crash when I save... so it's not usable for the moment.
The current code is here :
Alexis de Lattre has proposed merging
lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update into
lp:account-invoicing.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/account-invoicing/70-add
@Yannick
All your remarks are now integrated.
--
https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992
Your team Account Core Editors is subscribed to branch lp:account-closing.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to :
About the crash that I mentionned 2 comments above, the reason is quite obvious
when you look at the code in report/move_line_list_xls.py in the function
generate_xls_report() : the variable debit_pos is declared and initialized in a
block of code under :
if 'balance' in wanted_list':
and
Review: Approve
This is a great workaround for a very very annoying problem of OpenERP : 2
modules inherit the same on_change to add arguments and it makes the 2 modules
incompatible. Almost all experienced OpenERP developers were already confronted
to this headache. This seems a clever and
@Nhomar :
Could you explain exactly why you disapprove this merge proposal ? I don't
understand your answer.
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-always-check-date/+merge/196398
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
Review: Needs Information
Dear Lorenzo,
Thank you for this very interesting module. I was looking for such a module for
a new development I want to do to replace my fleet_maintenance module
(lp:fleet-maintenance).
Here are my remarks, from the most important to the least important :
1) the
@Lorenzo
I forgot to say that I am ready to do the work to have the changes that I
suggest if you agree with the changes. I could do that in another branch and
then propose to merge it.
--
@Nhomar :
I don't understand your answer. My collegues at Akretion France don't
understand it either. Could you explain it again ?
@Sylvain :
Of course, I could use the mass edit module to set all journals to
allow_date=True. But it find your suggestion too complicated for such a simple
Here is result of the Akretion-Noviat code sprint on SEPA credit transfer to
add the additionnal features of the module account_pain inside the module
account_banking_sepa_credit_transfer :
https://code.launchpad.net/~akretion-team/banking-addons/70-akretion-noviat-sepa-sprint
But before I
My branch only contains my module, it's not a full branch. So a bzr replay
should work, but a merge doesn't work. If it's a problem, I will prepare a
full branch of account-financial-tools with my module inside, but i'm not
sure if I will be able to push it in the same branch (if I can't, it
@Lorenzo
You're welcome ! I am happy that you like my modules.
@Guewen
I replaced the raise by an assert
--
https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992
Your team Account Core Editors is subscribed to branch lp:account-closing.
--
Mailing list:
57 matches
Mail list logo
