Review: Disapprove obsolete
Project has moved into github.
https://github.com/odoo-pos/odoo-pos/tree/7.0
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_fix_pos_change_pricelist/+merge/228833
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Review: Disapprove obsolete
Project has moved into github.
https://github.com/odoo-pos/odoo-pos/tree/7.0
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_restaurant/+merge/228822
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of lp:~sylv
Review: Disapprove obsolete
Project has moved into github.
https://github.com/odoo-pos/odoo-pos/tree/7.0
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_select_customer/+merge/228826
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Mai
Review: Disapprove obsolete
Project has moved into github.
https://github.com/odoo-pos/odoo-pos/tree/7.0
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_backup_draft_orders/+merge/228829
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Review: Disapprove obsolete
Project has moved into github.
https://github.com/odoo-pos/odoo-pos/tree/7.0
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_second_header/+merge/228820
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Maili
Hi again Pedro,
Is it Ok for you now ?
Regards.
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_fix_pos_change_pricelist/+merge/228833
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Mailing list: https://launchpad.net/~openerp-commun
Hi Leonardo,
I commit the fix about comment. Can you update your status if all is ok for you
now ?
Regards.
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_select_customer/+merge/228826
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
-
Hi Pedro,
I did the change. Are you ok with the new Merge Proposal ?
Regards.
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_second_header/+merge/228820
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Mailing list: https://launchpa
OK !
Done.
thank you for your patience.
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_select_customer/+merge/228826
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post
Hi again !
I did the changes, writing the first part instead of the second part. The
result is not the same in the part 1. That breaks the display of the
description. Are you sure about what you said ? Please see the screenshot in
the links.
Regards.
(TEST 1) -> http://hpics.li/d8c3c94
Possi
How. Thank you for that information.
I did'nt know how RST compiler works.
I'll change that.
Regards.
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_select_customer/+merge/228826
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Mailin
As said to @lpistone, this will change the display of the description. Doesn't
it ?
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_select_customer/+merge/228826
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Mailing list: https://la
Hi Pedro,
You kept your 'Needs Information'.
Is it a blocking point ?
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_backup_draft_orders/+merge/228829
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Mailing list: https://launchpad.
@lpistone:
I Just saw your comment. I'm not sure to understand why there is extra """. Are
you talking about L79 of the Merge proposal for exemple ? If yes:
print ("""aaa"""
""" bbb""")
>> aaa bbb
print (""" aaa
bbb""")
>> aaa
>> bbb
In that case, the first behaviour is wanted because the se
Fully agree with you!
But out of the scope of this module.
If you use this module, pricelist will not work; OK.
But if you dont use this module, pricelist will not work either!
The defaultprice list doesn't work as said in my link (and in your link too.
;-) )
My PoV: It's not a problem of pos_sel
Hi Pedro,
And about the online requirement, I'm not agree with that.
My PoV is:
Point Of Sale - Front-End is a module that HAS TO work OFFLINE. If not it's not
possible to use it.
Try to say to a customer: Hey ! I have a software but you can't sell if you
have a problem with your Internet Pr
Hi pedro,
Yes, it is quite a big job to realize. We have to load all the pricelist
behaviour and write the algorithm in Javascript. Pricelist is a big algorithm
depending of quantity, date and other pricelist recursively. I think this is
why it's not managed in Odoo by default.
For that, I wr
Hi. Yes this is notified in the manifest __openerp__.py file. ("Non covered
feature" section). It would very interesting but it is a big work and i didn't
planned to work on that immediately.
I dont understand the need fixing. It's not a bug. It is just a non covered
case. (As many thinks in op
Hi. Thanks for the review. I.
'Ll change that in a while. Regards.
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_fix_pos_change_pricelist/+merge/228833
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:openerp-pos.
--
Mailing list: https://launchpad.net/~
> I dont know if its necessary license header at XML template.
>
> LGTM
Hi. Thanks for the review. My PoV is that code is python file + xml + css + js
files. So i put licences in all filds basically.
Regards.
--
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_second_header/+merge/2
> Hi, Sylvain, thanks for the module. You have to put files inside a directory
> called 'pos_second_header' or something similar, but the rest LGTM.
Hi thanks for the review. Sorry i'll change that when i'll go back from
hollidays.
Regards.
--
https://code.launchpad.net/~sylvain-legal/openerp-p
> It works good, but I miss the functionality to recover the order again in the
> POS frontend. Is there any possibility to do that?
Yes. It could be possible. I didn't planned to do that but I 'll review
proposal that realize that.
Regards.
--
https://code.launchpad.net/~sylvain-legal/openerp-p
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/openerp-pos/7.0_fix_pos_change_pricelist into lp:openerp-pos.
Commit message:
[ADD] Add new module to manage correctly changes of pricelist in Point Of Sale
Requested reviews:
OpenERP Community Reviewer/Maintainer (openerp-community
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/openerp-pos/7.0_pos_backup_draft_orders into lp:openerp-pos
with lp:~sylvain-legal/openerp-pos/7.0_pos_second_header as a prerequisite.
Commit message:
[ADD] Add new module to backup a draft order in Front End Point Of Sale
Requested
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/openerp-pos/7.0_pos_select_customer into lp:openerp-pos with
lp:~sylvain-legal/openerp-pos/7.0_pos_second_header as a prerequisite.
Commit message:
[ADD] Add new module to select customers in Front End Point Of Sale
Requested reviews
The proposal to merge lp:~sylvain-legal/openerp-pos/7.0_pos_second_header into
lp:openerp-pos has been updated.
Description changed to:
new module "pos_second_header" that add a second toolbar in the point of sale
module (front-end).
This module is useless alone, but some modules depend on it.
The proposal to merge lp:~sylvain-legal/openerp-pos/7.0_pos_restaurant into
lp:openerp-pos has been updated.
Description changed to:
This module add extra-features for point of Sale module related to restaurant.
For the time being, it adds:
- pos_table model to select the table of the customers;
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/openerp-pos/7.0_pos_restaurant into lp:openerp-pos with
lp:~sylvain-legal/openerp-pos/7.0_pos_second_header as a prerequisite.
Commit message:
[ADD] Add new module to manage restaurant informations in Point Of Sale
Requested reviews
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/openerp-pos/7.0_pos_second_header into lp:openerp-pos.
Commit message:
[ADD] Add new module to display a second header in Point Of Sale
Requested reviews:
OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)
For more
Review: Disapprove
Sorry,
This repository is now readonly. (More information here:
https://docs.google.com/spreadsheets/d/tamE9XSJzreFklZ8ocImXmw/htmlview?pli=1#gid=0)
plz rewiew the Pull request on github.
https://github.com/OCA/server-tools/pull/8
--
https://code.launchpad.net/~sylvain-lega
The proposal to merge
lp:~sylvain-legal/server-env-tools/7.0-module_parent_dependencies into
lp:server-env-tools has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-module_parent_dependencies/+merge
The proposal to merge
lp:~sylvain-legal/server-env-tools/7.0-module_parent_dependencies into
lp:server-env-tools has been updated.
Description changed to:
Add a module 'module_parent_dependencies' that allows admin user to see the
modules that depend of a target modules. (direct and undirect d
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/server-env-tools/7.0-module_parent_dependencies into
lp:server-env-tools.
Requested reviews:
Server Environment And Tools Core Editors (server-env-tools-core-editors)
For more details, see:
https://code.launchpad.net/~sylvain-legal
Hi, Yannick, Thanks for the review. About you're comment, I agree but I'm not
sure that is a good MP to do this kind of change. My MP is just "make 3 modules
pep8 compliant". I thought that we have to do distinct MP for distinct work.
Don't you think ?
Regards.
--
https://code.launchpad.net/~s
Thanks, I did'nt know that information.
Regards.
--
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch
lp:~webaddons-core-editors/web-addons/7.0.
--
Mailing list: https://launchpad.net/~opener
Hi Holger,
Maybe I'm fully lost, but I thought, for the OCA project, that we had to work
on Launchpad for 7.0 (with sync on Github) and on Github for 8.0 serie.
Regards.
--
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core E
If you want to review this MP, better bzr branch locally this branch and use a
meld-like tools to see the differencies, because the diff tools of launchpad is
not very good for that.
Regards.
--
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-flake8/+merge/225456
Your team Server
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/server-env-tools/7.0-flake8 into lp:server-env-tools.
Commit message:
[REF] flake8 for 'mass_editing', 'auth_admin_passkey', 'disable_openerp_online'
modules;
Requested reviews:
Server Environment And
Review: Abstain
Hi.
Sorry, I totally forgot to review again that MP.
--
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Hi,
i can change it because you did'nt merge it.
BTW i put --fixes=lp:xxx too. (Launchpad indicates that correctly).
Regards.
*Sylvain LE GAL*
* Service informatiqueGroupement Régional Alimentaire de Proximité*
3 Grande rue des feuillants 69001 Lyon
*Bureau : *(+33) 09.72.32.33.17
*Astreinte
The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into
lp:server-env-tools has been updated.
Commit Message changed to:
[ADD] Regression Tests;
[FIX] Uncaught error is raised when the admin user tries to connect with a bad
login and his password;
[ADD] Test for the fixed
Hi Stéphane,
I don't have a precise idea about that.
I'm pretty in favor to keep that feature because :
- it works for admin user and doesn't bug with non-admin users;
- It works if admin user decide to change default ACL;
I'm agree : it's not very clean. (but OpenERP Core is not very clean in t
Review: Approve code review, test
LGTM.
Sorry for the late.
+++
--
https://code.launchpad.net/~acsone-openerp/web-addons/bug-1303944-sbi/+merge/216422
Your team Web-Addons Core Editors is requested to review the proposed merge of
lp:~acsone-openerp/web-addons/bug-1303944-sbi into lp:web-addons
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools.
Commit message:
[FIX] bug #1319391;
[ADD] Tests;
Requested reviews:
Server Environment And Tools Core Editors (server-env-tools-core-editors)
Related bugs:
Bug #1319391 in
Review: Needs Information no review
Hi,
Yes this is weird because launchpad says "Diff against target: 0 lines". Are
you sure that your new MP is valid ?
Regards.
--
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors
Review: Approve code review, no test
Thanks a lot !
--
https://code.launchpad.net/~stefan-therp/ocb-addons/7.0-lp1311628-dont_overwrite_empty_mail_catchall_domain/+merge/216877
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpa
Hi,
There wasn't any answer to Pedro's question. Does this MP need review ?
Regards.
--
https://code.launchpad.net/~akretion-team/multi-company/multi-company-action-user/+merge/179179
Your team Multi Company Core Editors is subscribed to branch lp:multi-company.
--
Mailing list: https://launc
Review: Approve code review, no test
good feature. (and good project I just discovered!)
LGTM.
Regards.
--
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:lp-community-util
Hi yannick,
Thanks to update your review status. I put quote in the translation file.
@all : 7 approves, Thanks !
Regards.
--
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
Your team Server Environment And Tools Core Editors is subscribed to bra
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons.
Requested reviews:
Guewen Baconnier @ Camptocamp (gbaconnier-c2c)
Pedro Manuel Baeza (pedro.baeza): code review and test
arthru (arthru): tested, no-review
For more
Following reviews on another merge proposal i did, I changed this MP. (non
functional changes : just pep8, copyright & typos changes).
regards.
--
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289
Your team Web-Addons Core Editors is subscribed to bra
The proposal to merge lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company
into lp:web-addons has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289
--
https://code.
Review: Approve code review, no test
Hi,
Looks Great to me.
Regards.
--
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316
Your team Server Environment And Tools Core Editors is subscribed to branch
lp:server-env-tools.
--
Mailing list: https://laun
Review: Abstain
Hi Lorenzo,
If this module is useless can you update the MP status ? ("Delete proposal to
merge").
regards.
--
https://code.launchpad.net/~agilebg/server-env-tools/add_textual_database_name/+merge/209184
Your team Server Environment And Tools Core Editors is requested to revi
@Yannick, @Pedro :
Are you Ok with the changes I did ? If yes, can you update your status ?
@Holger,
Thanks for that information (about ctx access), I didn't know. (And Thanks to
Stephan & You about your suggestions to improve algorithm & module
compatibility).
Sharing modules takes time but i
Hum :
1/ About the swap : Sorry, I did it. rev75 :
http://bazaar.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/revision/75
2/ About the template, The code sends an email like that :
"""
Admin user used his passkey to login with {login}.
Technicals informations belows :
Hi Holger,
Thanks for your review. In order of your remarks:
- typo changed;
- About 'literal_eval' import, I just copied / pasted some of the code written
in the file ./addons/auth_signup/res_users.py. But OK, I changed it.
- About 'email.template'. At the beginning, I just not wanted to man
Hi,
Thanks a lot for your review Yannick and your question.
First, I'm pretty beginner in OpenSource World, and I have no problem with
changing the declaration of the copyright.
My point of view is :
- It's a pitty to make more heavy code source with a lot of Copyright code;
Sometimes I rev
Thanks for your review.
About the call of do_action, yes it's possible via client actions. But in full
web it doesn't seem to work. But I'm not openerp-web-expert.
If somebody find a solution more elegant we can update the code in a second
time.
Regards.
--
https://code.launchpad.net/~sylvain
Hi Guewen,
I changed import call.
About the reload, the self.do_action('reload') doesn't work. I think because
I'm in a instance.web.Widget class.
Can you say me how to call this function ? I 'rgreped' 'do_action' in
web-addons without results.
As Arthru said, openerp call window.location.re
Hi Pedro,
Thanks for your review.
I did modifications about import & pep8.
About description in __openerp__.py file : In other modules, there is a big
header with that kind of informations (company name, date, link to AGPL
licences, people who wrote the module).
In my modules, I just put a
@Stefan (rev65) : (about remark #2) I updated the algorithm to manage the
special case where admin and user has the same password. In that case, when the
user log in, only admin user will receive a mail to inform him that there is a
security lake. Is that OK with you ?
@Davide (rev66) : I adde
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into
lp:server-env-tools.
Commit message:
[ADD] new module 'auth_admin_passkey' that allow admin user (uid=1) to login
with any login and his password.
Requested reviews:
Davide
The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey
into lp:server-env-tools has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
--
https
Hi,
@Stefan,
Remarks 1 : I didn't understand what your 'wild' idea can fix. (about possible
compatibility problem).
Remarks 2 : Héhé. Yes I thought of that very specific case without solution. I
finally found a workaround to manage this case and I'll update the Merge
Proposal in a while. (Wor
Thanks for your reviews and for your interests.
@Stefan :
Sorry if was not clear : I'm not sure that is possible to do that with a glue
module, and how. I just guess !
What I want :
- define in a predictive way the order of the call of the 2 functions :
auth_crypt.res_users.check_credentials(
For information :
The link for the MP of the dependencies :
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
--
https://code.launchpad.net/~ajite/server-env-tools/7.0-server-env-tools-0001/+merge/209653
Your team Server Environment And Tools Core Editors is requ
Review: Needs Information code review and test
Hi,
It works. But if the user tip an incorrect database name, there is a non
managed error server-side.
OperationalError: FATAL: database "test_module" does not exist
If the user has to input manually the database name my opinion is that the
mes
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into
lp:server-env-tools.
Commit message:
[ADD] new module 'auth_admin_passkey' that allow admin user (uid=1) to login
with any login and his password.
Requested reviews:
Server E
Hi Pedro,
Thank you for your review !
I'm not sure to understand what you said about question 2. It's preferible to
hide company name displayed by the 'web' module or the company name displayed
by 'web_easy_swich_company' ?
In few word, should I change something ?
Regards.
--
https://code.l
Hi Arthru,
I did the improvement you asked, hidding the widget if the user has right only
in one company.
Thanks for your review.
Regards.
--
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289
Your team Web-Addons Core Editors is requested to review
Thanks for the changes.
I'll test the module again next week.
Regards.
--
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is requested to review the proposed merge of
lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-ad
Review: Needs Fixing code review, test
Hi,
Thanks for your MP.
2 little thinks :
1/ maybe it could be great to rename the module with the type of the field.
Something like : 'web_many2one_polymorphic'.
2/ I tested your code with the mail_organizer module available on lp.
In this module,if
Hi Alexandre,
Are you agree with the changes I commit ?
Regards.
--
https://code.launchpad.net/~sylvain-legal/web-addons/web_field_float_compute/+merge/207006
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-rev
Hi Guewen,
Are you ok with my fix ? If yes can you change your "need fixing" status.
Regards.
--
https://code.launchpad.net/~sylvain-legal/web-addons/web_export_view__fr_translation/+merge/207009
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https:/
Hi all,
I propose for merging this little module I did, that allow users to switch from
a company to another more easily.
2 questions :
1/ l242, I wrote "window.location.reload()" to reload the page after the change
of the value 'company_id' of the current user. It works fine but I wonder i
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons.
Requested reviews:
Web-Addons Core Editors (webaddons-core-editors)
For more details, see:
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company
Thanks for your review.
I made the suggested changes.
I didn't know that there was differences between French and English abount
space & punctuation.
http://french.stackexchange.com/questions/46/pourquoi-place-t-on-une-espace-avant-les-ponctuations-fortes-why-is-there-a
Interesting.
Regards.
Done.
thanks Guewen and sorry for the basic mistake ...
--
https://code.launchpad.net/~sylvain-legal/web-addons/web_export_view__fr_translation/+merge/207009
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-revi
The proposal to merge lp:~sylvain-legal/web-addons/web_field_float_compute into
lp:web-addons has been updated.
Description changed to:
Propose for merge a module ' web_widget_float_formula' that improve float field
behaviour.
in all the numeric field (float, integer, etc.) the user can tip a f
Hi Pedro,
Thanks for your review. I changed the name of the module and put an image
without company logo and more informative.
Regards.
--
https://code.launchpad.net/~sylvain-legal/web-addons/web_field_float_compute/+merge/207006
Your team Web-Addons Core Editors is subscribed to branch lp:we
Review: Approve functional test
Nice !
it works perfectly.
--
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/197238
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-revie
Review: Approve code review, no test
LGTM.
--
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_ir_actions_act_window_scroll/+merge/197168
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/web-addons/web_export_view__fix_1271719 into lp:web-addons.
Commit message:
[FIX] 'web_export_view' : now export only selected items.
Requested reviews:
Web-Addons Core Editors (webaddons-core-editors)
Related bugs:
Bu
Review: Approve functional test
Thanks !
LGTM.
--
https://code.launchpad.net/~therp-nl/web-addons/7.0_web_ckeditor/+merge/200564
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-co
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/web-addons/web_export_view__fr_translation into lp:web-addons.
Commit message:
[ADD] Add FR translation for 'web_export_view' module
Requested reviews:
Web-Addons Core Editors (webaddons-core-editors)
For more details,
Sylvain LE GAL (GRAP) has proposed merging
lp:~sylvain-legal/web-addons/web_field_float_compute into lp:web-addons.
Requested reviews:
Web-Addons Core Editors (webaddons-core-editors)
For more details, see:
https://code.launchpad.net/~sylvain-legal/web-addons/web_field_float_compute/+merge
Review: Approve module used, no code review
Hi,
I used this module some times in V7, like Stephen to export datas (demo or not)
and only for that this module is very usefull. For exemple to write this file,
that populate french departments,
(http://bazaar.launchpad.net/~sylvain-legal/openerp-g
Hi.
So it seems that most people are not agree with "solution 3" and prefer the
"solution 1".
If everybody is ok (except Nhomar, sorry), I propose to merge this proposition.
+++
--
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-my_OpenERP_is_not_unsupported/+merge/199896
Your team
Hi Nhomar. Thank for sharing your opinion.
I think your point of view is not ok for all the situations. You're talking
about customers and you say "don't lie to them / Don't hide OpenERP SA
importance to them". (or something like that if I correctly understand). It's
respectable.
In my personna
Hi Nicolas,
Yes I think that we need to be "impartial" as you said.
But this MP is OK for me. If you're using this module, so you're using branches
(Git / LP) and you're not using online module management. because this is a the
aim of 'disable_openerp_online' module.
So, people who use 'disable
Review: Approve code review, no test
Hi.
Thanks. LGTM.
--
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-my_OpenERP_is_not_unsupported/+merge/199896
Your team Server Environment And Tools Core Editors is requested to review the
proposed merge of
lp:~therp-nl/server-env-tools/7.0-m
Review: Approve code review, no test
Hi.
It's OK for me.
Sorry for the delay.
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-always-check-date/+merge/196398
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailin
Review: Needs Information
Hi,
About the debate on "init" function :
Why not doing the following :
1/ keep the code :
- _defaults [...]
- def _allow_date_always_active [...]
- _constraints [...]
2/ remove the code :
- def init [...]
the init function only does a mass edit, it isn't ? So it'
Review: Approve code review, no test
LGTM.
Just one thing : you can maybe remove the three commented lines with print()
function.
+++
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-currency-rate-date-check/+merge/187009
Your team OpenERP Community Reviewer is subscrib
95 matches
Mail list logo
