Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into
lp:account-invoice-report.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/account-invoi
The proposal to merge
lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into
lp:account-invoice-report has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice
Lorenzo Battistini - Agile BG has proposed merging
lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into
lp:account-invoice-report.
Requested reviews:
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903): code review
Alexis de Lattre (alexis-via)
Joël Gra
The proposal to merge
lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into
lp:account-invoice-report has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_productio
Review: Needs Fixing code review and test
Hi, Lorenzo, thank you very much for your efforts.
Only one minor thing:
- Please correct summary field to have "Display" instead of "Dislpay".
Regards.
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot
On 10/16/2013 02:09 PM, Pedro Manuel Baeza wrote:
> Only one minor thing:
>
> - Please correct summary field to have "Display" instead of "Dislpay".
Oops. Done. Thanks.
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team O
Review: Approve code review and test
Thank you!
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer is subscribed to branch
lp:account-invoice-report.
--
Mailing list: https://launchpad.net/~op
Review: Approve code review, no tests
LGTM !
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer is subscribed to branch
lp:account-invoice-report.
--
Mailing list: https://launchpad.net/~opene
Review: Needs Information
Dear Lorenzo,
Thank you for this very interesting module. I was looking for such a module for
a new development I want to do to replace my "fleet_maintenance" module
(lp:fleet-maintenance).
Here are my remarks, from the most important to the least important :
1) the
@Lorenzo
I forgot to say that I am ready to do the work to have the changes that I
suggest if you agree with the changes. I could do that in another branch and
then propose to merge it.
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/
Hello,
just a word, to say that I fully agree with all Alexis comments: 1) to 4).
I don't remember where it was, but I believe there was a previous merge
proposal (that has probably been dropped in favor of this one), where I believe
Pedro Baeza was commenting the same that trying to avoid repor
On 12/04/2013 05:01 PM, Alexis de Lattre wrote:
> 1) the dependancy on invoice_webkit is not a good idea. I would really like
> to use this module, but I use aeroo reports. That would require splitting the
> module in 2 :
> - one generic module "account_invoice_prodlots" that adds the field
> pr
@Lorenzo :
I see that we agree on points 1, 3 and 4.
My answer on point 2 : after reflexion, I eventually think that a
fields.function is fine. It will be OK for me to use another many2many field
for the link between maintenance invoice lines and prodlots, or inherit the
fields.function. And i
On 12/05/2013 11:49 PM, Alexis de Lattre wrote:
> @Lorenzo :
>
> I see that we agree on points 1, 3 and 4.
>
> My answer on point 2 : after reflexion, I eventually think that a
> fields.function is fine. It will be OK for me to use another many2many field
> for the link between maintenance invoic
Review: Needs Fixing code review
Hello Lorenzo,
Please remove the AUTHORS.txt file and add its content to the module
description.
Thanks.
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer/Mai
Hello Maxime,
i have removed the file and added the author to the module.
Thanks.
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
Review: Approve
--
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-invoice-report.
--
Mailing list: https://launchpad.net/~openerp-community-revi
I see that this module got merged without modification, and none of the points
that I raise in my review were addressed, which is a bit surprising.
For example, the point 3 that I raised was :
<<
on the invoice line, you add a field 'displayed_lot_id' but you don't use it
anywhere. What is this
18 matches
Mail list logo
